Issue 770877 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	lfg@chromium.org
Closed:	Oct 2017
Cc:	jbroman@chromium.org adithyas@chromium.org lfg@chromium.org
Components:	Blink>Bindings
EstimatedDays:	----
NextAction:	----
OS:	Linux , Android , Windows , Chrome , Mac
Pri:	3
Type:	Bug

Improve access on childNodes

Project Member Reported by lfg@chromium.org, Oct 2 2017

Issue description

If a node is appended/removed from the ChildNodeList, blink invalidates the entire CollectionIndexCache, which means we need to (linearly) recompute the size during the next array access.

See attached microbenchmark for the problematic pattern.

node-list-change.html
396 bytes View Download

Project Member

Comment 1 by bugdroid1@chromium.org, Oct 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ac0cee74768ad2391241bb89985ee4b51520ee3

commit 7ac0cee74768ad2391241bb89985ee4b51520ee3
Author: Lucas Furukawa Gadani <lfg@chromium.org>
Date: Tue Oct 03 13:45:06 2017

Do not invalidate the cached node count when inserting single nodes.

Bug:  770877 
Change-Id: Ie8b07e9d4d0e043f00b8881be49bf58981f5af72
Reviewed-on: https://chromium-review.googlesource.com/690795
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506019}
[modify] https://crrev.com/7ac0cee74768ad2391241bb89985ee4b51520ee3/third_party/WebKit/Source/core/dom/ChildNodeList.cpp
[modify] https://crrev.com/7ac0cee74768ad2391241bb89985ee4b51520ee3/third_party/WebKit/Source/core/dom/ChildNodeList.h
[modify] https://crrev.com/7ac0cee74768ad2391241bb89985ee4b51520ee3/third_party/WebKit/Source/core/dom/CollectionIndexCache.h
[modify] https://crrev.com/7ac0cee74768ad2391241bb89985ee4b51520ee3/third_party/WebKit/Source/core/dom/ContainerNode.cpp
[modify] https://crrev.com/7ac0cee74768ad2391241bb89985ee4b51520ee3/third_party/WebKit/Source/core/dom/ContainerNode.h
[modify] https://crrev.com/7ac0cee74768ad2391241bb89985ee4b51520ee3/third_party/WebKit/Source/core/dom/Element.cpp

Comment 2 by lfg@chromium.org, Oct 3 2017

Status: Fixed (was: Assigned)

►

Issue 770877 link

Issue metadata

Improve access on childNodes

Issue description

Comment 1 by bugdroid1@chromium.org, Oct 3 2017

Comment 1 Deleted

Comment 2 by lfg@chromium.org, Oct 3 2017

Comment 2 Deleted

Sign in to add a comment