New issue
Advanced search Search tips

Issue 770874 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Remove unsupported policies from ADM/ADMX file

Project Member Reported by zmin@chromium.org, Oct 2 2017

Issue description

A policy that is not supported by certain version of Chrome should not be put into ADM/ADMX file or any other policies related documentation in that version of Chrome.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/adab685e64d889724b76e4c3660992d8647cab83

commit adab685e64d889724b76e4c3660992d8647cab83
Author: Owen Min <zmin@chromium.org>
Date: Wed Oct 04 17:16:46 2017

TemplateWriter: checks supported version on each platform

TemplateWriter.IsPolicySupported and
TemplateWriter.IsPolicySupportedOnPlatform are now checking whether the
currect version is supported or not. It will affect the generation of
html documentation, adm/admx file, etc.

TEST: components/policy/tools/template_writers/test_suite_all.py
Bug:  770874 


Change-Id: I6fcecfaae5c87197b7829bb102afc407d2120779
Reviewed-on: https://chromium-review.googlesource.com/687870
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506423}
[modify] https://crrev.com/adab685e64d889724b76e4c3660992d8647cab83/components/policy/BUILD.gn
[modify] https://crrev.com/adab685e64d889724b76e4c3660992d8647cab83/components/policy/tools/template_writers/policy_template_generator_unittest.py
[modify] https://crrev.com/adab685e64d889724b76e4c3660992d8647cab83/components/policy/tools/template_writers/template_formatter.py
[modify] https://crrev.com/adab685e64d889724b76e4c3660992d8647cab83/components/policy/tools/template_writers/writers/mock_writer.py
[modify] https://crrev.com/adab685e64d889724b76e4c3660992d8647cab83/components/policy/tools/template_writers/writers/template_writer.py
[modify] https://crrev.com/adab685e64d889724b76e4c3660992d8647cab83/components/policy/tools/template_writers/writers/template_writer_unittest.py

Comment 2 by zmin@chromium.org, Oct 4 2017

Status: Fixed (was: Started)

Sign in to add a comment