New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 770871 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 753595



Sign in to add a comment

Move delete temporary pages which are in abandoned temporary archives directory to another task.

Project Member Reported by romax@chromium.org, Oct 2 2017

Issue description

The temporary pages consistency check currently contains 3 steps, and the first step of it should be separated from the other 2, since it's a one-time check when Chrome starts, while the other 2 need to run periodically.
 

Comment 1 by romax@chromium.org, Oct 2 2017

Blocking: 753595

Comment 2 by romax@chromium.org, Oct 2 2017

The first step should also include the processing of archive files in abandoned directory, after which the abandoned directory should be empty.

Comment 3 by romax@chromium.org, Oct 5 2017

more context from the CL:

There will be a new task for doing:
Delete all temporary pages (and their files) if the file path is in abandoned dir.

And this will be executed when the chrome starts for the first time, and it shouldn't be executed routinely as other implemented steps.

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e00be28bb57af66640efa959fc0587182b20d468

commit e00be28bb57af66640efa959fc0587182b20d468
Author: Yafei Duan <romax@chromium.org>
Date: Tue Nov 21 04:34:58 2017

[Offline Pages] Separate legacy pages clearing from Consistency Check.

Removed the clearing of the pages in legacy archives directory from the
temporary pages consistency check, and created a new task for it.
The new task should only be executed when there is a Chrome version
upgrade detected within Offline Page Model, which will be introduced in
the future.

Bug:  770871 
Change-Id: I6a6a4c5910da16c11281242dab424ceae4636dbe
Reviewed-on: https://chromium-review.googlesource.com/710525
Commit-Queue: Yafei Duan <romax@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518115}
[modify] https://crrev.com/e00be28bb57af66640efa959fc0587182b20d468/components/offline_pages/core/BUILD.gn
[add] https://crrev.com/e00be28bb57af66640efa959fc0587182b20d468/components/offline_pages/core/model/clear_legacy_temporary_pages_task.cc
[add] https://crrev.com/e00be28bb57af66640efa959fc0587182b20d468/components/offline_pages/core/model/clear_legacy_temporary_pages_task.h
[add] https://crrev.com/e00be28bb57af66640efa959fc0587182b20d468/components/offline_pages/core/model/clear_legacy_temporary_pages_task_unittest.cc
[modify] https://crrev.com/e00be28bb57af66640efa959fc0587182b20d468/components/offline_pages/core/model/clear_storage_task_unittest.cc
[modify] https://crrev.com/e00be28bb57af66640efa959fc0587182b20d468/components/offline_pages/core/model/offline_page_model_taskified_unittest.cc
[add] https://crrev.com/e00be28bb57af66640efa959fc0587182b20d468/components/offline_pages/core/model/offline_page_test_util.cc
[add] https://crrev.com/e00be28bb57af66640efa959fc0587182b20d468/components/offline_pages/core/model/offline_page_test_util.h
[modify] https://crrev.com/e00be28bb57af66640efa959fc0587182b20d468/components/offline_pages/core/model/temporary_pages_consistency_check_task.cc
[modify] https://crrev.com/e00be28bb57af66640efa959fc0587182b20d468/components/offline_pages/core/model/temporary_pages_consistency_check_task.h
[modify] https://crrev.com/e00be28bb57af66640efa959fc0587182b20d468/components/offline_pages/core/model/temporary_pages_consistency_check_task_unittest.cc

Comment 5 by romax@chromium.org, Nov 21 2017

Status: Fixed (was: Assigned)

Sign in to add a comment