FTP requests don't go through the WebRequest extension API |
||||
Issue descriptionChrome Version : 61.0.3163.100 What steps will reproduce the problem? 1. Write a simple extension that installs a RequestFilter to handle ftp://*/* and http://*/* URLs. 2. Notice that the filter works for the HTTP requests, but not for the FTP requests (e.g. console.log). (An example FTP URL is ftp://ftp.freebsd.org.) What is the expected result? The API should handle FTP as well as HTTP. The documentation (https://developer.chrome.com/extensions/webRequest#type-RequestFilter and https://developer.chrome.com/extensions/match_patterns) seems to suggest that FTP URLs should be filtered. What happens instead of that? The filter never runs for FTP requests.
,
Oct 3 2017
#1: Well, we document that it works, and FTP support still exists in Chrome, so we should do what we say. I found this bug while implementing an extension to block FTP or upgrade it to HTTPS. So for my particular use case, this bug is actually security-relevant. If it's easier to remove FTP support, well, I'm all in favor of that, as you know. :) But unless and until we do that, the WebRequest API should work as documented (and for all web resource request types).
,
Oct 3 2017
I'm not arguing it's not worth implementing, I'm just not sure we want to add the infrastructure to support it until extensions are hooked up using the URLLoader API. Hooking up something twice requires more time, and adds more attack surface area in the meantime (And is particularly likely to get a less careful review, since it's code that will likely be gone within a year).
,
Jul 13
We should at least update the documentation. Who owns that?
,
Jul 13
,
Jul 13
(If it isn't worth wiring FTP up to extensions, is it work maintaining support at all? Can we just drop it on the floor? :) )
,
Jul 13
FTP is in maintenance mode, and we're not adding any features to it. We'd love to remove it, but suspect usage is still much too high to do that.
,
Jul 13
~0.03% of downloads across ~0.08% of users over the last month, according to `Download.TargetConnectionSecurity`. ~0.003% of top-level navigations across 0.13% of users over the last month, according to `Navigation.MainFrameSchemeDifferentPage`. Not huge numbers. Not tiny, but not huge. +lassey@.
,
Jul 13
It would be interesting to see what portion of that usage could be upgraded to HTTPS (i.e. with something like palmer@'s extension) |
||||
►
Sign in to add a comment |
||||
Comment 1 by mmenke@chromium.org
, Oct 3 2017