Replace with mojo apis. See ash/README.md and go/mustash.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7846707dfd7a410cf6ee9f7a2d8a082f5a56e54e commit 7846707dfd7a410cf6ee9f7a2d8a082f5a56e54e Author: Evan Stade <estade@chromium.org> Date: Mon Oct 02 22:21:56 2017 Remove an ash reference from UserManagerScreenHandler. This is used for the "manage people" bubble accessible from the avatar menu. It doesn't compile on Chrome OS so the USE_ASH blocks are obsolete. The JS is shared with the Chrome OS login screen, which still uses kKeyCanRemove, so we can't delete the flag altogether. Bug: 770866 Change-Id: I55f63800f98e28ebd9358812c3b634b65041a904 Reviewed-on: https://chromium-review.googlesource.com/695944 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#505814} [modify] https://crrev.com/7846707dfd7a410cf6ee9f7a2d8a082f5a56e54e/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4fc238b5768ec2e605237f5e65e9d0e766f52243 commit 4fc238b5768ec2e605237f5e65e9d0e766f52243 Author: Evan Stade <estade@chromium.org> Date: Tue Oct 03 00:35:28 2017 Remove obsolete special casing in ntp_resource_cache.cc The showApps property is only used by ntp4.js, which despite its name is the apps page, which is non-Chrome OS desktop only. Bug: 770866 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I16e313cb01f28dbe76cc42f79f42d6bb4d126f7c Reviewed-on: https://chromium-review.googlesource.com/695710 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#505884} [modify] https://crrev.com/4fc238b5768ec2e605237f5e65e9d0e766f52243/chrome/browser/resources/ntp4/new_tab.js [modify] https://crrev.com/4fc238b5768ec2e605237f5e65e9d0e766f52243/chrome/browser/resources/ntp4/page_list_view.js [modify] https://crrev.com/4fc238b5768ec2e605237f5e65e9d0e766f52243/chrome/browser/ui/webui/ntp/ntp_resource_cache.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/22fe401782d9883ad24a36ecb02c56176211d4bc commit 22fe401782d9883ad24a36ecb02c56176211d4bc Author: Evan Stade <estade@chromium.org> Date: Mon Oct 23 17:23:58 2017 Tighten up DEPS rules for ash includes in chrome/browser/ui/webui/. Better reflects current state of mash effort. TBR=nyquist@chromium.org,pam@chromium.org Bug: 770866 Change-Id: I947fb7e5b280e3047f8408b74087fbe5a4c12f87 Reviewed-on: https://chromium-review.googlesource.com/723645 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#510830} [modify] https://crrev.com/22fe401782d9883ad24a36ecb02c56176211d4bc/chrome/browser/ui/webui/DEPS [modify] https://crrev.com/22fe401782d9883ad24a36ecb02c56176211d4bc/chrome/browser/ui/webui/chromeos/DEPS [add] https://crrev.com/22fe401782d9883ad24a36ecb02c56176211d4bc/chrome/browser/ui/webui/settings/DEPS
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0b89310afab4325da545ff3835dc2d5c70c3dc73 commit 0b89310afab4325da545ff3835dc2d5c70c3dc73 Author: James Cook <jamescook@chromium.org> Date: Sat Jan 06 00:11:48 2018 cros: Tighten DEPS on ash in //chrome/browser/ui/webui For go/mustash code in //chrome cannot depend on //ash. Remove the "+ash" DEPS entry from //c/b/ui/webui and switch to per-file deps in the few remaining places. This will catch issues like the mash browser_tests failure in crbug.com/798797 at the checkdeps stage. Bug: 770866 Test: buildtools/checkdeps/checkdeps.py Change-Id: I5d1a5687c7ea1885803fa5b1841d6f88b66ed3d8 Reviewed-on: https://chromium-review.googlesource.com/853152 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#527442} [modify] https://crrev.com/0b89310afab4325da545ff3835dc2d5c70c3dc73/chrome/browser/ui/webui/chromeos/DEPS [add] https://crrev.com/0b89310afab4325da545ff3835dc2d5c70c3dc73/chrome/browser/ui/webui/chromeos/emulator/DEPS [add] https://crrev.com/0b89310afab4325da545ff3835dc2d5c70c3dc73/chrome/browser/ui/webui/chromeos/first_run/DEPS [modify] https://crrev.com/0b89310afab4325da545ff3835dc2d5c70c3dc73/chrome/browser/ui/webui/chromeos/login/DEPS [delete] https://crrev.com/b96ecb3473acfc0b70fe38e713c6d09a07e3f2dc/chrome/browser/ui/webui/settings/DEPS [add] https://crrev.com/0b89310afab4325da545ff3835dc2d5c70c3dc73/chrome/browser/ui/webui/settings/chromeos/DEPS [modify] https://crrev.com/0b89310afab4325da545ff3835dc2d5c70c3dc73/chrome/browser/ui/webui/settings/md_settings_ui.cc
I'm not working on this right now, so throwing it back in the pool. I may pick it up again later.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ab528d092410f3ad5704d7212ac171ae97605c49 commit ab528d092410f3ad5704d7212ac171ae97605c49 Author: James Cook <jamescook@chromium.org> Date: Tue Jan 09 01:38:44 2018 cros: Move login_constants.h to //ash/public/cpp The file contains constants that are shared between webui login code in chrome and views-based login code in ash. Since the file just contains constants, move it to //ash/public. This makes it clear it's OK for go/mustash and eliminates a DEPS entry. Bug: 770866 Test: compiles, checkdeps Change-Id: I726c0bcce7bbe2b7622728deb76b717cd37acba0 Reviewed-on: https://chromium-review.googlesource.com/853218 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#527859} [modify] https://crrev.com/ab528d092410f3ad5704d7212ac171ae97605c49/ash/BUILD.gn [modify] https://crrev.com/ab528d092410f3ad5704d7212ac171ae97605c49/ash/login/ui/lock_screen.cc [modify] https://crrev.com/ab528d092410f3ad5704d7212ac171ae97605c49/ash/login/ui/login_auth_user_view.cc [modify] https://crrev.com/ab528d092410f3ad5704d7212ac171ae97605c49/ash/login/ui/login_password_view.cc [modify] https://crrev.com/ab528d092410f3ad5704d7212ac171ae97605c49/ash/login/ui/login_pin_view.cc [modify] https://crrev.com/ab528d092410f3ad5704d7212ac171ae97605c49/ash/login/ui/login_user_view.cc [modify] https://crrev.com/ab528d092410f3ad5704d7212ac171ae97605c49/ash/public/cpp/BUILD.gn [rename] https://crrev.com/ab528d092410f3ad5704d7212ac171ae97605c49/ash/public/cpp/login_constants.h [modify] https://crrev.com/ab528d092410f3ad5704d7212ac171ae97605c49/ash/wallpaper/wallpaper_controller.cc [modify] https://crrev.com/ab528d092410f3ad5704d7212ac171ae97605c49/ash/wallpaper/wallpaper_view.cc [modify] https://crrev.com/ab528d092410f3ad5704d7212ac171ae97605c49/chrome/browser/ui/webui/chromeos/login/DEPS [modify] https://crrev.com/ab528d092410f3ad5704d7212ac171ae97605c49/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9a795ad4744d54ebad122411d6ce5e15a4471861 commit 9a795ad4744d54ebad122411d6ce5e15a4471861 Author: James Cook <jamescook@chromium.org> Date: Fri Apr 20 22:39:18 2018 cros: Remove ash::Shell access from first-run webui handler The old code was reaching into ash to get the shelf alignment. This won't work with out-of-process ash (see //ash/README.md). Convert to using ash/public/cpp and profile pref. This enables the first run browser_tests under mash. Bug: 770866, 756057 Test: browser_tests --enable-features=Mash Change-Id: I43b202ef255301f637593e24a588a42bacdc7fff Reviewed-on: https://chromium-review.googlesource.com/1022523 Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#552499} [delete] https://crrev.com/d4f22170f747a4b2edabf0d41ce69a8482754b89/chrome/browser/ui/webui/chromeos/first_run/DEPS [modify] https://crrev.com/9a795ad4744d54ebad122411d6ce5e15a4471861/chrome/browser/ui/webui/chromeos/first_run/first_run_ui.cc [modify] https://crrev.com/9a795ad4744d54ebad122411d6ce5e15a4471861/testing/buildbot/filters/mash.browser_tests.filter
Comment 1 by est...@chromium.org
, Oct 2 2017