New issue
Advanced search Search tips

Issue 770862 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Jan 2018
Cc:
jbroman@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 718595



Sign in to add a comment

Change SSV::GetWireData to return base::span rather than blink::StringView

Project Member Reported by mek@chromium.org, Oct 2 2017 
When the method was added base::span didn't exist, so it was written to use StringView. But it makes a lot more sense for the method to return a base::span<const uint8_t>.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 3 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8659ba6b629883a9c71852315add64622509d0c3

commit 8659ba6b629883a9c71852315add64622509d0c3
Author: Jeremy Roman <jbroman@chromium.org>
Date: Wed Jan 03 21:35:12 2018

Have SerializedScriptValue::GetWireData return a base::span.

StringView wasn't an ideal type, since this is binary data, not character data.

Bug:  770862 
Change-Id: I24108f10f8171815d52704d028a93fd01e2f44cf
Reviewed-on: https://chromium-review.googlesource.com/710674
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526826}
[modify] https://crrev.com/8659ba6b629883a9c71852315add64622509d0c3/third_party/WebKit/Source/DEPS
[modify] https://crrev.com/8659ba6b629883a9c71852315add64622509d0c3/third_party/WebKit/Source/bindings/core/v8/serialization/SerializedScriptValue.h
[modify] https://crrev.com/8659ba6b629883a9c71852315add64622509d0c3/third_party/WebKit/Source/bindings/core/v8/serialization/SerializedScriptValueTest.cpp
[modify] https://crrev.com/8659ba6b629883a9c71852315add64622509d0c3/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModulesTest.cpp
[modify] https://crrev.com/8659ba6b629883a9c71852315add64622509d0c3/third_party/WebKit/Source/core/messaging/BlinkCloneableMessageStructTraits.h
[modify] https://crrev.com/8659ba6b629883a9c71852315add64622509d0c3/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/8659ba6b629883a9c71852315add64622509d0c3/third_party/WebKit/Source/modules/indexeddb/IDBTestHelper.cpp
[modify] https://crrev.com/8659ba6b629883a9c71852315add64622509d0c3/third_party/WebKit/Source/modules/indexeddb/IDBValueWrapping.cpp
[modify] https://crrev.com/8659ba6b629883a9c71852315add64622509d0c3/third_party/WebKit/Source/modules/indexeddb/IDBValueWrapping.h
[modify] https://crrev.com/8659ba6b629883a9c71852315add64622509d0c3/third_party/WebKit/Source/modules/notifications/NotificationData.cpp

Comment 2 by jbroman@chromium.org, Jan 3 2018

Status: Fixed (was: Available)
►

Sign in to add a comment