New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 770861 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

usb added printer does not trigger component download

Project Member Reported by xiaochu@chromium.org, Oct 2 2017

Issue description

1) connect star printer via usb
2) enable component download flag #enable-cros-component
3) navigate to chrome://settings/cupsPrinters' and click add printer
4) star printer shows up as auto discovered, click add and printer is NOT added

addition:

1) manually added epson printer is able to trigger component download
2) call component API before hand to download star printer driver first. Then star printer can be added via usb.
 
Description: Show this description
@justincarlson it looks like the ppd_filters extracted from ppd file is empty which is why it does not trigger component download:

https://cs.chromium.org/chromium/src/chrome/browser/chromeos/printing/printer_configurer.cc?q=CrOSComponent&sq=package:chromium&dr=C&l=239

Comment 3 Deleted

Which specific ppd is involved?
the auto discovered printer shows 'TSP743II (STR_T-001) (USB) TSP743II (STR_T-001)'

i'm not sure which ppd file it is using. i can add printf to see exact ppd file name if you can point to me the place.
The driver should be starcupsdrv-3.6.0-tsp700II.ppd.gz, then.

It contains this at line 13:

*cupsFilter:            "application/vnd.cups-raster 0 rastertostar"

Nothing obvious yet as to why this would be mis-parsed. 

I print the ppd_contents string it shows me corrupted encoding:

^_~K^H^Hvu�V^B^Ctsp700II.ppd^@�]^?o�6��^?~A�^N~D~@^B3^CLlR~R%��^K�$3m~@�$H2���X^Tj�$�s,C��N?�#%J^V^?�K�C�~X$^V��!///oh^]������w���rA~F�E�Y^\��oo>V�K����w�j�0~[W��h���l*~Z?^U~[�C��C>l~^֫��^@�a�P-W~['~I����T�W^[�!7�~B�s���0����tzyy��.^E�U�9<^V^O�C]�^Cdtw��V�������W~G��_���47z-P~T��E��꡼�^X����^O~K�}Q^?^?~u�^P������B~X&��%yy
uw^?�����~T������������~G���-^_^N�~]�G�~L�F��b}^mW�N"��CٵV�r�����qX��L�r��~U���^V��z���Wm&�m~Vg^B��.v^\H���a_��h^Z�5���K��-^Bs�\��ϫ~G�Sq
�l~V��<d^H���xCLD<�ӳ�t�~Z��^R>~_����~@�        ��j]��T^Mo��X�~D�.�����7��m�~A~�~K�2n��rG�(~]�~L�~_�����=��^RQ٫����~V�����^[?s����~[Oy�OE�*~]~W7^\R߭�~T�rJ��o~[       ��~G�v�u[&ݤ�}���;~HY�^C��~Yh����-~K]�!^O���
~Y~XǷ[��Ku��R�uUO^Z��ԫ~M~X��~N�^VR=~R^F� ^Q^_^F�����|�$on�~KE?'W�rU~P��7|:�7~B��^~V��^\�,7^O_^W~DNɻ�׻r^?�^^~M~O.��,ȿ������)��^P~�5~Q��n_�L�o�~R<��^_�~Xt&�~Y~R�^?'?�|[���A��?l^Z^S���~S�~W�~I'~O���?���^��_�r��
�~F�&<��~G��Y��B~_-K"Z�NteS��a�?  O^�^MyC2�_�$!�~J;r�~@^N�~R_~J�%���C!��g��^ZY�^^^_�~Z{��L�g~R��~T߶q=��C~^��~V~\^?��#<�><�~N~Sb�T�^\��p�ʲm��^O�-y��^P�~&^�ʢ~x&��~Jߩ��GӬ����N�^W9~_~@~X�^?"G�~F��^W��~J~W�����;;
�dO^T���Ni�~S>U�S7}B}��^T�~Y~[>~[���^T��M?�}��
}��gl�~S~�������ȧS~E~_�T:`��^#~_R~U~^:�c�5�)S�~Y~K>�^Z�T�z4v�ϼF>U�^^M\�s�~QOմGS^G}��F�~Z���E~_�~M|5���E~_�~M|5���A~_R�~Q��=:w��^#~_�Y~O��^:�^]�z�^O;`~K|�y���Q~>��~[��A^OX_�1{�g�A���c}����~^~U�[���b~O�K=;��r~OO
��^^�~Wzvz_�^^�~K=f/�����=�^W{�^�Y��~U{�/�~X�Գӧ^^#_^V{�Z���s~O~Q/~K=f-�����=v,�~X�Գ�'^^#~_^N�^^~M���<F>^]�=~Z~L�~_{~L|:L{4^]A���c�b~OYK=;}�3�~Gi~Ofc�s~_~Q?L{4^_A���c�b~OYK=;}�1��0��1Y�[��^F�^^�~UzP�S��W����Z��
]��~B�9dt~_���ʽ~F=Q�^S'��r��O^U��M���k�g
��M���k�3~E>s�{+�^Z�\��~]��ʽ~F~���������
>��8��=~V{-=U��~C�_���3~U~^��^S�~QOլ�8��=~V{-�~Z�^\�{��r��W�~^�t/�X���j�s~\��^^˽~V^M{~Nӽ�c��ҫi�q�~W{,�Zz5�9N�r~O�^C�Ԭ�\Y�_��E�^^���Z����~F�~O^_��X�e��^6�t~OM^S_�^�~_�ecO�^D��r/�O����{^M��r/�O����{^M��r/�O���
��{^M��r/�O����{~B�W�~W��{��ӽ~F>�^X�m�~W~M<�k�s~O~Q�^V{���=A����~N�{��ӽ~F>�^X�t~X�~\�{^M��c��a�s~^�5�s~O~QO~Gi�y�'�}~U{��t/^[y��Ч>#^?~X�~\�{^M}�3�~Gi�y�'�}~U{��t/^[y����^^#~_^M�^^^[~S�|~U{��t/^[w�'#~_z^]�:~'��
�r�yt�I|"��~U{l���k�~S^A{2~J�W��Ч^C�t^\��r��~_^M�g��=~U{^M}6| ���{*�^Z�|@~_~O��U�5��^A�|^\}�1��rO���=A~_{~L������^Hz_�^K�~F�l^L}�1��0���=A?�^X�t~X���~^| ~_{~L|:L{�r~O��*�Z�a�s~W{~B>�^Y�ô�.�^D}�3�~Gi�]�qz_�^K?LL
{�rO��^^#~_^M�^^^[~S�|~U{]䫡~O~W[m�S��W�����r�;��U�B��~^<^T�~Gú�^T^]~U)�^R^N)�B��^?^V^B~U��^Q��g,^m^ZH��QpM��O~Rf3���~@E^A^N~H�]��v�~@n~E֧^V�^R^E񸮪�Uw;2!��^^pw���-�~S^O�����-fs�@b;��~C�^X�~]�^Mp8Y�~R   ��¡�
^VJ�)�^S��^N��l~Zl|*��]~S�^[~A~N�g~T~Qln�ed~V~]J�T�'�W^B^G~_| �eI�~W���ծ�r�^X��4E�m��^H�N^Q~B�6�^T��~OU^L�6~N~R~Cy^U~C^M�G���k�4vT%^U@#�ѣ*�^@^Z)~M^^UI^E�Hi��J*~@FJ�GUR^A4R^Z=�~R
| ~Q��Q~UT^@~M~TN~O��^Bh�tzL%^U@#��c*�^@^Z)~]^^SI^E�H��~XJ*~@FJ��TR^A4R:=�~R
| ~Q��1~UT^@~M~TN~O��^Bh�4zT%^U@#eF>�~R
�~Q2~G^O���h��^^~LPI��H)�^N~UT^@~M~TB�PI^E�H)�^N~UT^@~M~TB�PI^E�H)�^N~UT^@~M~TB�PI^E�H)�^N~UT^@~M~TJ~O��^Bh�Tz\%^U@#���*�^@^Z)~U^^WI^E�H���J*~@FJ��UR^A4R*=�~R
| ~QR�q~UT^@~M~TJ~O��^Bh�^Tz~GJ*~@FJ~O|L%^UB#�^O^_SI~E�H^]{�VI��Hi��J*~@FJ�GUR^A4R^Z=�~R
| ~Q��Q~UT^@~M~TF~O��^Bh�4zT%^U@#�ѣ*�^@^Z)~]^^SI^E�H��~XJ*~@FJ��TR^A4R:=�~R
| ~Q��1~UT^@~M~TN~O��^Bh�tzL%^U@#��c*�^@^Z)~]^^SI^E�Hi��J*~@F�~L|X%^UB#e^N^_VI~E�Hu=^X�~R��~QR�^]*�^@^Z)~Eޡ~R
| ~QR�^]*�^@^Z)~Eޡ~R
| ~QR�^]*�^@^Z)~Eޡ~R
| ~QR�^]*�^@^Z)~U^^WI^E�H���J*~@FJ��UR^A4R*=�~R
| ~QR�q~UT^@~M~TJ~O��^Bh�Tz\%^U@#���*�^@^Z)~U^^WI^E�H)�^N~UT^@~M~T^^�~XJ*~DFJ^_>�~R
�~Q�z0F%�_#��;TR^A4R
�C%^U@#��;TR^A4R
�C%^U@#��;TR^A4R
�C%^U@#��;TR^A4R*=�~R
| ~QR�q~UT^@~M~TJ~O��^Bh�Tz\%^U@#���*�^@^Z)~U^^WI^E�H���J*~@FJ��UR^A4R*=�~R
| ~QR�^]*�^@^Z)=�1~UT^H~M~T>|L%�_#5�^A ��.�~Qt~@�ǻ𧧳J^?B
^?:��Q�#nQ~J�^��.^K~KhGi'V�N4=~[~R��v^ZUá�fa^X�$�_���#rv�^D��%6f~Zb�   �Lg~Xi6�L3�t~^c�9b��^Xf:�LS��My�^@Ls��Mi^F~X�2^L5e~Hi~Bz~X�~H�^L�0M^P�9�a~Z¦<���3�4�=~\!�9��^\6M)��9b^Z�^^fH4�=��ᣭ�a�| ^Em��^D�'�''�:C�^^
S�~S~Sa      �'�''�^TJOLON�)~T~^~X~^~\LS(=1=9^Y�`zbzr2MS��Jr2Ms��Jr2L�����d~Z&~H~Gi~L~Z�^P^O�^D5~]#^^�)f
�'�''�4�<~\��9��^\3^E�^S�~S~Si^Z#^^fh4~A�~I����a~J�"�hz�^_j�Y�Xz�^_H~D,���?L^H~Z~B��^?^P^P4^E�S�^P^_h
���^A<�^TNO��s| i~Jz^X�~^r4=^]^_Z^CL��t|�^L2MP^OC�S~N���~C^~P�^\�0T=�hz:>`^E~Y��~G3�4�=~\æpz:>~T^D~Yƨ~G^Y^RMpz^Z<^L�~@<L^]�| -~R~^2�zb�^DNO^YV=�~VPzʰ�I~Z^B�)ê'i
��^L�~^�)~P~^2�zjM��~Ta�~S4M^Q^OC�~S4�^Q^OC�Sk
��^L�~^�i~Bx^X�~^��^L�0T=I�9�a�zjM��~Ta�~S4M1^Og�i~Ny8�L��~Ta�~S4~M^Q^O34~Z| �~Ta�S�a~J�"�Hz��4��^^��| �Կ�^K[B��^?�^V1^E�S�F+b
���MR�^THO�^[~\�)~T~^�7'^Q�^T�0~X~^Z�^\�0~X~^^ZS(=^]��~CM^S��`zjMg~H~G���~Z�^Q^O~C��1~E���^M,�4�<~\��9��^\3~E���M^_�4F<��h~B����~V^E�a~J�"�pzz~W�>۬�N��HO      �^Q��T@��3�~M�~[^Uvӧb� ��x�A�y�^Q_۲�X�~T~[^]�1_C~~
@�-~C~H�to�(`��^DQ��[^Q~LNt4��^H<5�  E�3^C~^M^Qxf��9^B�u8^O^W^D>7�)�~Yab~M��)ap��y���L~G'~Xg~FI3~R^_/~D�^S^]>�<3L~N~Q�^P^S^L>��)�~YL~G��gr^M�s^]^F~_��^X�^L�g~U'^W�3=��^L�o��E�^B~V��~K_�~|J^D�^S^S^M-W�^W�H~<       ^H~_Y��r5^?~Q~K��^?~@��~DC���~E-~R^_�^A��*(~R^_~G^Aé^A~G~V���X$?n^B~F�&|^F{F�j"�q^N0<5��r5^?�~J��%���~D�~Hgr^C^N-W�^W�H~|^@^Hg��B���^E��^L�n����j^\#G��=~B�~I~N^F~W�q\^\Iy9^B~_^Yph�^Z��~Q~To#�\~G~C��8�~M�<^Z~AA
k�k^N/W�~X7~R�c^L�tx~ByF�]sx�^ZG�~Q~T�b�T~C~C��8�~M��^U~Cg:<G=~Skpp�^Zǰ~Q~T^?"p��*�\~M���3^T��~J~G~W��X5j�~K^Q~DNL4�\-ǧ~Q~T^G~B�~Y^En_�~Vc�H��@xn�~A�j9^N~M��^M~Dk��~T��pj�~A�j9�~L��^K~F�&|^F{F�]�~\
~F�^F^\X�~V��H�~U`xf�s�3�^A^G~V��X2~R�^]^P��Y^E~V�����^L�n����j9f~LZ�I^D�^S^S^M,W�qb$�^] |f~A�~W���0~R� ^P~^~[p`�Z~N^G#)O^@��rm�^D0~\^Zp`�Z~N�"��>^L~OM�^L�~L�\���axj�~A�j9�~K���0<3�9�~Y�~@^C��rL^W�ǯA83g^UX�~V㸸
�3^T��~N^G~W���-~R^O^S[^HlGm~Q|^X�
7~Oע�a޶?W�^_W�rU�,�xâ�n4��c�zz�/x�f����竢~Zmv����^?�~Pos���M~A��Pr�m�%�?�~Ii�~V~Q�Z���1��x�h�~A��Qλ��w$c"/^@6� ����F~L^Z#�~|���~Vqg��^Bf�,^R��u�*7���rp~F~Tpx~K~V^?3�~G�:l^W����^^��~KI�3��
���o+~H?�q�-��~D~^�^?~N~C4/~G^?j�;\��^K2�~QwZ����^~Z~H/|z#�~M^�~V�u9i�~Y��S��~D�~S-~C��{~L�'!��n�I�;�^?&�~E��^R�;�SQ��^A�|�]\=^~\t?���y��#�~@���^O����
Q^_a^W`������,�~G�IrF�^KҾ�t�G��^�v������D~~W�G^@��i��oF�z`w�^L^S=~Bλ�9��^N^_0oi�~A�y^PHd.$~\^O�s�^?^V~W�~[e�| a��^R�^[LE~G�|U�Wź^C�~W^@~Z}�Y�~C~J~_^G8u��~E2~A^W�C7FvF��^CϢ{l~\G~KŰ�����~Mr��~B:�^AB��^Ls~@�F))
~@� ~Ox-^HΡ^H(v�^Wu�{Y�@��I{~A~\W~[=O�^C_^]�w|C�IZ~D����,�DD^?���~K{�^M"�^L~X~I~Z\T~D_!�~R��u^N0���~PN^F^V~D~B&�h�^T^S^F~Z�G~Sxh���O�Y^^-�  2�����~U�^\ֻ��jDX^N�~E~R����^P~O^On� �j�^�v�HQ~F2�~Pi^K��      ~]~R~WW
�����,M7^O�hg%�N�;vh�N�~K[�~X�ŧ�%�]��~RS���~N^W~C~S�^T�Yk7�v�S���.�v�)vyk~Ws��^T�yk7�v�S�h^_.��~_b��L^S4'E^M~UaCE�P(p,�mp^S=7�9PO~Q�^O^?�����ؾ�k�L~N^R7�~L^]زHUp�]~�~Iv�A^^W^[^H�&G�Ah�g�^B`��_�~E^]�:����^Q���77
�~Sk�Sm~U\%~[�7���^N~Q�z׼%�^["���n�^V]�a�c?ۦc^KO^N�)VѴ[�|i���~Y�T|��T*>qf^L^U~_~NXH�Ŭ�Qӥ^Q^VYߧ�S~Ne��Z����~Y�X~]��G�ķv�~Yo�FO�~D~O~]{   ^_?��`��K~C��/^MN~Y^?irJ^@H~S�^V^A��-^Dn�mY�ů=~C^Hh/��ߵO�^_��~[�~EE
�aB�Q�f�~]M~X�~Y���Ilm~N���$�6'~R[�~B^U~PJ@:��;�d�Ĥ@.m!�^^4�d�^[^PS6 ^Fn@��~@^X8^_^L�~@~X{^Cb�m@�^[6 ^Fo@��~@�~H^M~H�^[^P;i^Cb'm@��^M~H~]�^A�^S7 v�^F�N�~@�7l@^L�~@~X�^A�1^[^PC6 v�^F�N�~@ة^[^P;u^Cb�n@��^M~H~]�^^
A�o�~@^X�^A1c^Cb�^M~H~A^[^P�7 ~Fo@^L�~@^X�^A1�^F�\^[^P^[�^A1d^Cb�^M���^W�5�^Q~Y�~V��oe���^>�u%�~M^D~D�^X"AD| H^C^[~^�a�^S�^V
�^]��xz�.~KZ~@�^?��~[/~[~U�^@ji��p^K~Hj�\o^FF�^?=~^2~J6�^P^O��=5�/^?^?�,����^Gm�?~R^?�^@^@

Oh dear.

Those are gzipped contents, which CUPS handles just fine, but the *browser* is not unzipping the contents when looking for filters, which is why it's not finding any. 
(If your epson ppd that you're experimenting with is *not* gzipped, that would explain why it works...)
ok, can you suggest a fix?
We need to conditionally unzip the ppd contents before we attempt to extract the filter lines.  Probably checking the magic number at the start of the stream is sufficient for determining whether the contents are zipped.

We'll have to be a little careful to limit the size of the uncompressed ppd, or to change the filter scan to be streaming.  It looks like there's support for gzip decompression in //src/net/filter/gzip_source_stream.h.

I could pick this up later this week, or if you want to take a crack at it sooner than that the relevant code is in //chromeos/printing/ppd_provider.cc.  If you don't, feel free to assign this to me.

Owner: justincarlson@chromium.org
Status: Assigned (was: Untriaged)
Thanks!

Comment 13 by skau@chromium.org, Nov 2 2017

Is this done?  I remember seeing a CL for it.
https://chromium-review.googlesource.com/c/chromium/src/+/736850, which is the real fix, has gotten held up behind other things.  I should be able to get back to it next week.

As a workaround, we're serving the Star PPDs unzipped for the moment.
Status: Fixed (was: Assigned)
Project Member

Comment 17 by bugdroid1@chromium.org, Nov 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a737de10c1b397664f0bd01a68764b9f1114d69

commit 2a737de10c1b397664f0bd01a68764b9f1114d69
Author: Hans Wennborg <hans@chromium.org>
Date: Thu Nov 16 01:39:38 2017

Fix components build of chromeos_unittests

TBR=justincarlson

Bug:  770861 
Change-Id: I54d3ccf53f507c64106071b0a86ef5a5d326ea23
Reviewed-on: https://chromium-review.googlesource.com/773618
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516945}
[modify] https://crrev.com/2a737de10c1b397664f0bd01a68764b9f1114d69/chromeos/printing/ppd_line_reader.h

Comment 18 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 19 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment