New issue
Advanced search Search tips

Issue 770855 link

Starred by 1 user
Status: Assigned
Owner:
mrefaat@chromium.org
Cc:
eugene...@chromium.org
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Fix CookieStoreIOS unit tests

Project Member Reported by mrefaat@chromium.org, Oct 2 2017 
CookieStoreIOS unit tests is not working correctly, it seems that there is no clear cookies between cases and the expected results was wrong.

Also refactor the unit tests, add new tests and remove tests that are no longer useful
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c1fa8ed5bd5df62bf757f7e830cc557ff7dcd52

commit 6c1fa8ed5bd5df62bf757f7e830cc557ff7dcd52
Author: mrefaat <mrefaat@chromium.org>
Date: Tue Oct 03 18:17:10 2017

Fix cookie_store_ios unittests

Added clearCookies between all cases, with that some test cases failed
So i updated these unit tests with the right expectation.
Also changed the name of constant urls to be more clear.

This is considered a quick fix, i will followup with another CL after
relanding https://chromium-review.googlesource.com/c/chromium/src/+/675804

Bug: 770855
Change-Id: Id537aa461e225bd62b73c54eaf6e22ec224f8871
Reviewed-on: https://chromium-review.googlesource.com/695937
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506107}
[modify] https://crrev.com/6c1fa8ed5bd5df62bf757f7e830cc557ff7dcd52/ios/net/cookies/cookie_store_ios_unittest.mm

Comment 2 by pkl@chromium.org, Jan 7 

Did CL in comment 1 fix the unit tests?
►

Sign in to add a comment