New issue
Advanced search Search tips

Issue 770854 link

Starred by 1 user
Status: Fixed
Owner:
mmenke@chromium.org
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Proj-Servicification



Sign in to add a comment

BrowserProcess code should be able to share URLLoaderFactories

Project Member Reported by mmenke@chromium.org, Oct 2 2017 
Currently, central browser process objects only vend NetworkContexts, not URLLoaderFactories, so every consumer needs to create its own URLLoaderFactory before it can issue requests. We should have the central classes cache a URLLoaderFactory for use only by browser process consumers instead.

We're probably fine not doing this for other interfaces, like the cookie store, though could be wrong about that.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7e9968c35391184b38f04b082ee52de5298f2a0

commit a7e9968c35391184b38f04b082ee52de5298f2a0
Author: Matt Menke <mmenke@chromium.org>
Date: Tue Oct 03 17:57:05 2017

Make classes that own NetworkContextPtr also cache URLLoaderFactories.

Consumers in the browser process can now get a URLLoaderFactory* from
the StoragePartition or SystemNetworkContextManager to issue requests,
instead of having to create their own from a NetworkContext.

Bug:  770854 
Change-Id: I3d33e36626f250386d0648853b2b38e10fe607b4
Reviewed-on: https://chromium-review.googlesource.com/696062
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506096}
[modify] https://crrev.com/a7e9968c35391184b38f04b082ee52de5298f2a0/chrome/browser/net/network_context_configuration_browsertest.cc
[modify] https://crrev.com/a7e9968c35391184b38f04b082ee52de5298f2a0/chrome/browser/net/profile_network_context_service_browsertest.cc
[modify] https://crrev.com/a7e9968c35391184b38f04b082ee52de5298f2a0/chrome/browser/net/system_network_context_manager.cc
[modify] https://crrev.com/a7e9968c35391184b38f04b082ee52de5298f2a0/chrome/browser/net/system_network_context_manager.h
[modify] https://crrev.com/a7e9968c35391184b38f04b082ee52de5298f2a0/content/browser/storage_partition_impl.cc
[modify] https://crrev.com/a7e9968c35391184b38f04b082ee52de5298f2a0/content/browser/storage_partition_impl.h
[modify] https://crrev.com/a7e9968c35391184b38f04b082ee52de5298f2a0/content/public/browser/storage_partition.h
[modify] https://crrev.com/a7e9968c35391184b38f04b082ee52de5298f2a0/content/public/test/test_storage_partition.cc
[modify] https://crrev.com/a7e9968c35391184b38f04b082ee52de5298f2a0/content/public/test/test_storage_partition.h

Comment 2 by mmenke@chromium.org, Oct 3 2017

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6506f071492b4bd2a035c248d5e669474fb205f7

commit 6506f071492b4bd2a035c248d5e669474fb205f7
Author: John Abd-El-Malek <jam@chromium.org>
Date: Tue Oct 31 15:09:49 2017

Use 0 to represent process_id of browser process when creating a URLLoaderFactory.

This is per the NetworkContext::CreateURLLoaderFactory contract.

BUG= 770854 

Change-Id: I4ae9fb610d1860948c84fa9126e98d260afbdfbd
Reviewed-on: https://chromium-review.googlesource.com/745161
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512832}
[modify] https://crrev.com/6506f071492b4bd2a035c248d5e669474fb205f7/chrome/browser/net/system_network_context_manager.cc
[modify] https://crrev.com/6506f071492b4bd2a035c248d5e669474fb205f7/content/browser/storage_partition_impl.cc

Comment 4 by laforge@google.com, Nov 7 2017

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.
►

Sign in to add a comment