New issue
Advanced search Search tips

Issue 770853 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR

Blocked on:
issue 694033



Sign in to add a comment

run vr_common_unittests on linux

Project Member Reported by vollick@chromium.org, Oct 2 2017

Issue description

It would eventually be good to run this (perhaps on a dedicated bot) to ensure that this doesn't break (it's pretty critical for devs).
 
Cc: ddorwin@chromium.org
FYI, Issue 774177 covers the addition of a new trybot to build and run the unittests on Linux, and potentially, be run as part of the CQ if it turns out to be stable enough.
Blockedon: 694033
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22a43311691cdfbc518dc30c0c12a110fd96e35b

commit 22a43311691cdfbc518dc30c0c12a110fd96e35b
Author: bsheedy <bsheedy@chromium.org>
Date: Wed Jan 17 19:22:27 2018

Set enable_vr to true on x86/64 Linux

Enables VR on x86/x64 Linux builds. It was decided that instead of
having a special Linux VR bot that enables ozone and VR on the CQ,
it was preferrable to enable VR on Linux by default and use the Ozone
CQ bot.

There should be no performance or functionality impact from this, and
the binary size impact is reasonable

Bug:  770853 
Change-Id: I3a2add90deb10e7e8f1d9fbee6cf887f01a8bdb9
Reviewed-on: https://chromium-review.googlesource.com/865955
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529847}
[modify] https://crrev.com/22a43311691cdfbc518dc30c0c12a110fd96e35b/device/vr/features/features.gni

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b24eaae298b9d63adf23431717d8b2a1ba00701

commit 1b24eaae298b9d63adf23431717d8b2a1ba00701
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Wed Jan 17 20:13:15 2018

Revert "Set enable_vr to true on x86/64 Linux"

This reverts commit 22a43311691cdfbc518dc30c0c12a110fd96e35b.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 529847 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzIyYTQzMzExNjkxY2RmYmM1MThkYzMwYzBjMTJhMTEwZmQ5NmUzNWIM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/4395

Original change's description:
> Set enable_vr to true on x86/64 Linux
> 
> Enables VR on x86/x64 Linux builds. It was decided that instead of
> having a special Linux VR bot that enables ozone and VR on the CQ,
> it was preferrable to enable VR on Linux by default and use the Ozone
> CQ bot.
> 
> There should be no performance or functionality impact from this, and
> the binary size impact is reasonable
> 
> Bug:  770853 
> Change-Id: I3a2add90deb10e7e8f1d9fbee6cf887f01a8bdb9
> Reviewed-on: https://chromium-review.googlesource.com/865955
> Reviewed-by: Christopher Grant <cjgrant@chromium.org>
> Reviewed-by: Bill Orr <billorr@chromium.org>
> Reviewed-by: Ian Vollick <vollick@chromium.org>
> Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#529847}

Change-Id: I77d40874bd2db75cb9c8470e555f836353fa2a89
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  770853 
Reviewed-on: https://chromium-review.googlesource.com/871390
Cr-Commit-Position: refs/heads/master@{#529855}
[modify] https://crrev.com/1b24eaae298b9d63adf23431717d8b2a1ba00701/device/vr/features/features.gni

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b360bdad6669bd7b7bbe345e23c5aea1602ec21a

commit b360bdad6669bd7b7bbe345e23c5aea1602ec21a
Author: bsheedy <bsheedy@chromium.org>
Date: Thu Jan 18 17:33:13 2018

Reland "Set enable_vr to true on x86/64 Linux"

The revert was caused by some unfortunate timing where a separate
change broke the VR testapp.

This is a reland of 22a43311691cdfbc518dc30c0c12a110fd96e35b
Original change's description:
> Set enable_vr to true on x86/64 Linux
>
> Enables VR on x86/x64 Linux builds. It was decided that instead of
> having a special Linux VR bot that enables ozone and VR on the CQ,
> it was preferrable to enable VR on Linux by default and use the Ozone
> CQ bot.
>
> There should be no performance or functionality impact from this, and
> the binary size impact is reasonable
>
> Bug:  770853 
> Change-Id: I3a2add90deb10e7e8f1d9fbee6cf887f01a8bdb9
> Reviewed-on: https://chromium-review.googlesource.com/865955
> Reviewed-by: Christopher Grant <cjgrant@chromium.org>
> Reviewed-by: Bill Orr <billorr@chromium.org>
> Reviewed-by: Ian Vollick <vollick@chromium.org>
> Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#529847}

Bug:  770853 
Change-Id: I0bba7790b3ec4ead04f0edf3113835c9c551aab7
Reviewed-on: https://chromium-review.googlesource.com/871610
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530183}
[modify] https://crrev.com/b360bdad6669bd7b7bbe345e23c5aea1602ec21a/BUILD.gn
[modify] https://crrev.com/b360bdad6669bd7b7bbe345e23c5aea1602ec21a/device/vr/features/features.gni

Project Member

Comment 7 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71bfa0d1b3735bd050195ef6a74726f378f5c1a9

commit 71bfa0d1b3735bd050195ef6a74726f378f5c1a9
Author: bsheedy <bsheedy@chromium.org>
Date: Fri Jan 19 21:29:10 2018

Add VR tests to Linux bots

Adds vr_common_unittests and vr_pixeltests to chromium.linux bots now
that VR is enabled by default on Linux builds.

Bug:  770853 
Change-Id: I4588f661713d60335569366e1ad05fb79645a41a
Reviewed-on: https://chromium-review.googlesource.com/875312
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530617}
[modify] https://crrev.com/71bfa0d1b3735bd050195ef6a74726f378f5c1a9/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/71bfa0d1b3735bd050195ef6a74726f378f5c1a9/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/71bfa0d1b3735bd050195ef6a74726f378f5c1a9/testing/buildbot/test_suites.pyl

Hey Brian, can we declare this fixed now?  We aren't building the testapp yet AFAIK, due to Ozone, but unit tests are covered.
Status: Fixed (was: Assigned)
Labels: M-67 Test-Complete

Sign in to add a comment