There are a lot of old style pre-ES6 class definitions in PP. It would be nice to slowly upgrade those to ES6, especially the ones that are unrelated to print_preview.Component (and therefore likely to be kept in a potential migration to MD), for exmaple see [1]. [1] https://cs.chromium.org/search/?q=@constructor+file:%5Esrc/chrome/browser/resources/print_preview/data/+package:%5Echromium$&type=cs.
FYI, converting some classes at https://chromium-review.googlesource.com/c/chromium/src/+/695848.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa0fe46a8d598336f9f009fb9f6341aa957402a3 commit fa0fe46a8d598336f9f009fb9f6341aa957402a3 Author: rbpotter <rbpotter@chromium.org> Date: Wed Oct 04 19:35:45 2017 Print Preview cleanup: Convert ticket item classes to ES6 syntax Bug: 770851 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Idc4fc5ac44534f51305f6573ba1a1f00c55d5672 Reviewed-on: https://chromium-review.googlesource.com/699638 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#506481} [modify] https://crrev.com/fa0fe46a8d598336f9f009fb9f6341aa957402a3/chrome/browser/resources/print_preview/data/ticket_items/collate.js [modify] https://crrev.com/fa0fe46a8d598336f9f009fb9f6341aa957402a3/chrome/browser/resources/print_preview/data/ticket_items/color.js [modify] https://crrev.com/fa0fe46a8d598336f9f009fb9f6341aa957402a3/chrome/browser/resources/print_preview/data/ticket_items/copies.js [modify] https://crrev.com/fa0fe46a8d598336f9f009fb9f6341aa957402a3/chrome/browser/resources/print_preview/data/ticket_items/css_background.js [modify] https://crrev.com/fa0fe46a8d598336f9f009fb9f6341aa957402a3/chrome/browser/resources/print_preview/data/ticket_items/custom_margins.js [modify] https://crrev.com/fa0fe46a8d598336f9f009fb9f6341aa957402a3/chrome/browser/resources/print_preview/data/ticket_items/dpi.js [modify] https://crrev.com/fa0fe46a8d598336f9f009fb9f6341aa957402a3/chrome/browser/resources/print_preview/data/ticket_items/duplex.js [modify] https://crrev.com/fa0fe46a8d598336f9f009fb9f6341aa957402a3/chrome/browser/resources/print_preview/data/ticket_items/fit_to_page.js [modify] https://crrev.com/fa0fe46a8d598336f9f009fb9f6341aa957402a3/chrome/browser/resources/print_preview/data/ticket_items/header_footer.js [modify] https://crrev.com/fa0fe46a8d598336f9f009fb9f6341aa957402a3/chrome/browser/resources/print_preview/data/ticket_items/landscape.js [modify] https://crrev.com/fa0fe46a8d598336f9f009fb9f6341aa957402a3/chrome/browser/resources/print_preview/data/ticket_items/margins_type.js [modify] https://crrev.com/fa0fe46a8d598336f9f009fb9f6341aa957402a3/chrome/browser/resources/print_preview/data/ticket_items/media_size.js [modify] https://crrev.com/fa0fe46a8d598336f9f009fb9f6341aa957402a3/chrome/browser/resources/print_preview/data/ticket_items/page_range.js [modify] https://crrev.com/fa0fe46a8d598336f9f009fb9f6341aa957402a3/chrome/browser/resources/print_preview/data/ticket_items/rasterize.js [modify] https://crrev.com/fa0fe46a8d598336f9f009fb9f6341aa957402a3/chrome/browser/resources/print_preview/data/ticket_items/scaling.js [modify] https://crrev.com/fa0fe46a8d598336f9f009fb9f6341aa957402a3/chrome/browser/resources/print_preview/data/ticket_items/selection_only.js [modify] https://crrev.com/fa0fe46a8d598336f9f009fb9f6341aa957402a3/chrome/browser/resources/print_preview/data/ticket_items/ticket_item.js [modify] https://crrev.com/fa0fe46a8d598336f9f009fb9f6341aa957402a3/chrome/browser/resources/print_preview/data/ticket_items/vendor_items.js [modify] https://crrev.com/fa0fe46a8d598336f9f009fb9f6341aa957402a3/chrome/browser/resources/print_preview/settings/settings_section_select.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6a27b1cee862b8f0b720ffc515d36367ad38849a commit 6a27b1cee862b8f0b720ffc515d36367ad38849a Author: dpapad <dpapad@chromium.org> Date: Mon Oct 09 19:00:44 2017 Print Preview cleanup: Convert various classes to ES6 syntax, part1. Bug: 770851 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2b724b3922c90feee8c0c93850964e4b155dab77 Reviewed-on: https://chromium-review.googlesource.com/695848 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#507434} [modify] https://crrev.com/6a27b1cee862b8f0b720ffc515d36367ad38849a/chrome/browser/resources/print_preview/data/capabilities_holder.js [modify] https://crrev.com/6a27b1cee862b8f0b720ffc515d36367ad38849a/chrome/browser/resources/print_preview/data/coordinate2d.js [modify] https://crrev.com/6a27b1cee862b8f0b720ffc515d36367ad38849a/chrome/browser/resources/print_preview/data/destination_match.js [modify] https://crrev.com/6a27b1cee862b8f0b720ffc515d36367ad38849a/chrome/browser/resources/print_preview/data/invitation.js [modify] https://crrev.com/6a27b1cee862b8f0b720ffc515d36367ad38849a/chrome/browser/resources/print_preview/data/margins.js [modify] https://crrev.com/6a27b1cee862b8f0b720ffc515d36367ad38849a/chrome/browser/resources/print_preview/data/page_number_set.js [modify] https://crrev.com/6a27b1cee862b8f0b720ffc515d36367ad38849a/chrome/browser/resources/print_preview/data/printable_area.js [modify] https://crrev.com/6a27b1cee862b8f0b720ffc515d36367ad38849a/chrome/browser/resources/print_preview/data/size.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/01ef13f2ce7a3e98a0857b2c80aeb988938cf1c9 commit 01ef13f2ce7a3e98a0857b2c80aeb988938cf1c9 Author: rbpotter <rbpotter@chromium.org> Date: Fri Oct 13 00:12:13 2017 Print Preview: Convert more classes to es6 Bug: 770851 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If57d9d95e703de47f3c868589c66b664f5af425f Reviewed-on: https://chromium-review.googlesource.com/710876 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#508559} [modify] https://crrev.com/01ef13f2ce7a3e98a0857b2c80aeb988938cf1c9/chrome/browser/resources/print_preview/data/app_state.js [modify] https://crrev.com/01ef13f2ce7a3e98a0857b2c80aeb988938cf1c9/chrome/browser/resources/print_preview/data/destination.js [modify] https://crrev.com/01ef13f2ce7a3e98a0857b2c80aeb988938cf1c9/chrome/browser/resources/print_preview/data/destination_store.js [modify] https://crrev.com/01ef13f2ce7a3e98a0857b2c80aeb988938cf1c9/chrome/browser/resources/print_preview/data/print_ticket_store.js [modify] https://crrev.com/01ef13f2ce7a3e98a0857b2c80aeb988938cf1c9/chrome/test/data/webui/print_preview/print_preview_tests.js
Are there any classes left to be converted, without taking into account print_preview.Component subclasses?
Yes. See more conversions in progress here https://chromium-review.googlesource.com/c/chromium/src/+/717562 Also cloud_print_interface.js and preview_generator.js in print_preview/
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/358c3da7cb72d22dbcdb8df68225127989bb3439 commit 358c3da7cb72d22dbcdb8df68225127989bb3439 Author: rbpotter <rbpotter@chromium.org> Date: Tue Oct 17 02:33:05 2017 Print preview: Convert rest of data/ to es6 Bug: 770851 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iead1096721a70f1890b03106ab296b08070f6094 Reviewed-on: https://chromium-review.googlesource.com/717562 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#509225} [modify] https://crrev.com/358c3da7cb72d22dbcdb8df68225127989bb3439/chrome/browser/resources/print_preview/cloud_print_interface.js [modify] https://crrev.com/358c3da7cb72d22dbcdb8df68225127989bb3439/chrome/browser/resources/print_preview/data/cloud_parsers.js [modify] https://crrev.com/358c3da7cb72d22dbcdb8df68225127989bb3439/chrome/browser/resources/print_preview/data/document_info.js [modify] https://crrev.com/358c3da7cb72d22dbcdb8df68225127989bb3439/chrome/browser/resources/print_preview/data/invitation_store.js [modify] https://crrev.com/358c3da7cb72d22dbcdb8df68225127989bb3439/chrome/browser/resources/print_preview/data/measurement_system.js [modify] https://crrev.com/358c3da7cb72d22dbcdb8df68225127989bb3439/chrome/browser/resources/print_preview/data/user_info.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fccc4695177e66af0e60ece63428f921a1bb3644 commit fccc4695177e66af0e60ece63428f921a1bb3644 Author: rbpotter <rbpotter@chromium.org> Date: Tue Oct 17 18:47:34 2017 Print Preview: convert CloudPrintInterface & PreviewGenerator to es6 Bug: 770851 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ieb74b2babaed060314746da71dbe508f763febea Reviewed-on: https://chromium-review.googlesource.com/722279 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#509455} [modify] https://crrev.com/fccc4695177e66af0e60ece63428f921a1bb3644/chrome/browser/resources/print_preview/cloud_print_interface.js [modify] https://crrev.com/fccc4695177e66af0e60ece63428f921a1bb3644/chrome/browser/resources/print_preview/preview_generator.js
This is done for non print_preview.Component classes, so marking as Fixed.
Comment 1 by dpa...@chromium.org
, Oct 2 2017