New issue
Advanced search Search tips

Issue 770834 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

26.6%-1168.9% regression in system_health.common_mobile at 505470:505506

Project Member Reported by majidvp@chromium.org, Oct 2 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=770834

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=5b8f5b7f9b0145dd835351b8217fc76aa4a6ad8abb45ec3e7de1c8da7dfe210c


Bot(s) for this bug's original alert(s):

android-nexus6
android-nexus7v2
Cc: mek@chromium.org
Owner: mek@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author mek@chromium.org ===

Hi mek@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Marijn Kruisselbrink
  Commit : 17c5e2fb29bf938660314048ff85346670ab6abe
  Date   : Sat Sep 30 23:47:47 2017
  Subject: Onion Soupify MessagePort

Bisect Details
  Configuration: android_nexus6_perf_bisect
  Benchmark    : system_health.common_mobile
  Metric       : cpu_time_percentage_avg/long_running_tools/long_running_tools_gmail-foreground
  Change       : 1170.86% | 0.0786941413119 -> 1.00009449442

Revision             Result                       N
chromium@505469      0.0786941 +- 0.00305851      6      good
chromium@505477      0.0784801 +- 0.00128879      6      good
chromium@505479      0.0797289 +- 0.00379716      6      good
chromium@505480      0.999772 +- 0.00337436       6      bad       <--
chromium@505481      0.999742 +- 0.00238849       6      bad
chromium@505485      1.00043 +- 0.00260374        6      bad
chromium@505500      1.00009 +- 0.00387566        6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=long.running.tools.gmail.foreground system_health.common_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8966816682546874064


For feedback, file a bug with component Speed>Bisection
Labels: -Pri-2 Pri-1
Revert didn't come clean. mek@, please look at this regression.

Before trace: https://console.developers.google.com/m/cloudstorage/b/chrome-telemetry-output/o/long_running_tools_gmail_background_2017-09-29_20-26-10_77762.html

After your CL:
https://console.developers.google.com/m/cloudstorage/b/chrome-telemetry-output/o/long_running_tools_gmail_background_2017-10-01_10-42-59_9827.html


Some how a lots more events are added to the trace, and I have trouble opening the after CL trace :-(
Cc: kinuko@chromium.org dcheng@chromium.org
+CL reviewers as well
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db3d89459575f0c658c562baa2d3d55648e6767c

commit db3d89459575f0c658c562baa2d3d55648e6767c
Author: Marijn Kruisselbrink <mek@chromium.org>
Date: Tue Oct 03 16:32:02 2017

Revert "Fix behavior around closed message ports."

This reverts commit 419b66b54c98e04141e5e966d905dbb371314770.

Reason for revert: Depends on MessagePort onion-soupification, which
needs to be reverted for performance issues.

Original change's description:
> Fix behavior around closed message ports.
> 
> Connect a closed message port to a dangling message pipe to make sure
> messages posted to the port end up getting lost, even after the message
> port is transferred to a different process.
> 
> Bug:  673526 
> Change-Id: I95467bf5c3e1af316c8781bcca6dfdda29936fe8
> Reviewed-on: https://chromium-review.googlesource.com/690981
> Reviewed-by: Jeremy Roman <jbroman@chromium.org>
> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#505760}

TBR=jbroman@chromium.org,mek@chromium.org

Change-Id: Ia2cead94d083c2f27b8be8c451de0ce1a06c2866
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  673526 ,  770834 
Reviewed-on: https://chromium-review.googlesource.com/698284
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506067}
[modify] https://crrev.com/db3d89459575f0c658c562baa2d3d55648e6767c/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/db3d89459575f0c658c562baa2d3d55648e6767c/third_party/WebKit/Source/core/dom/MessagePort.cpp

Comment 7 by mek@chromium.org, Oct 3 2017

I've reverted the CL that depended on the problematic one, so hopefully that one should revert cleanly now. No idea yet what would cause this regression though. And as you say opening the after trace seems to cause chrome to get very unhappy...

Comment 8 by mek@chromium.org, Oct 3 2017

Hmm, after ~10 minutes of waiting trying to open the after trace the tab crashes (presumably because it ran out of memory)...

Comment 9 by mek@chromium.org, Oct 3 2017

Trying to run the (desktop version of) that long_running:tools:gmail-foreground benchmark locally fails with "OverflowError: size does not fit in an int" when trying to gzip the serialized trace data... Obviously something really wrong here, just not sure what.
#9: that just means the trace file is way too big. :-(

We have script to help deal with that:
1) https://cs.chromium.org/chromium/src/third_party/catapult/tracing/bin/html2trace?q=html2trace&dr=C&l=14 which will unpack the HTML trace file to multiple raw json file. Usually the one with biggest size is the Chrome trace 
2) Once you have the JSON form of the trace, https://cs.chromium.org/chromium/src/third_party/catapult/tracing/bin/slim_trace can be used to shrink the trace by discarding certain events.

Comment 11 by mek@chromium.org, Oct 3 2017

Thanks. What seems to be the main difference is that the bad traces have tons upon tons of InputLatency related events. But that probably is just a symptom of whatever else is wrong. At least it's fairly trivial to reproduce this locally. (and fwiw the revert seems to have almost made it through the CQ)

Comment 12 by mek@chromium.org, Oct 3 2017

Okay, I'm pretty sure I figured out the bug (and its fix https://chromium-review.googlesource.com/c/chromium/src/+/699159).
Should I land the fix directly, or still revert first and then reland with the fix included? (sorry, the previous revert attempt failed with merge conflicts after all trybots passed)
I recommend land the revert first, then land the revert + fix. That way we know the full impact of your CL after fix.
Cc: -nednguyen@chromium.org nedngu...@google.com

Comment 15 by mek@chromium.org, Oct 3 2017

Works for me. Hopefully there won't be more merge conflicts with the revert.
Project Member

Comment 16 by bugdroid1@chromium.org, Oct 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0

commit f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0
Author: Marijn Kruisselbrink <mek@chromium.org>
Date: Tue Oct 03 23:19:56 2017

Revert "Onion Soupify MessagePort"

This reverts commit 17c5e2fb29bf938660314048ff85346670ab6abe.

Reason for revert: Regressing CPU metric significantly. BUG:770834

Original change's description:
> Onion Soupify MessagePort
> 
> This involves moving content::MessagePort to blink::MessagePortChannel
> (in WebKit/common), and getting rid of WebMessagePortChannel.
> 
> Bug:  769835 
> Change-Id: I91a22c84b11c67afe720c19066fa84cb9fb4fc7b
> Reviewed-on: https://chromium-review.googlesource.com/596782
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: Jeremy Roman <jbroman@chromium.org>
> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#505480}

TBR=dcheng@chromium.org,kinuko@chromium.org,jbroman@chromium.org,dpranke@chromium.org,mek@chromium.org,haraken@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  769835 ,  770834 
Change-Id: Iee31e7c934878c7d0ebfbd35c3b7b3de6524eb43
Reviewed-on: https://chromium-review.googlesource.com/697564
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#506226}
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/content/DEPS
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/content/browser/android/app_web_message_port.cc
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/content/browser/android/app_web_message_port.h
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/content/browser/message_port_provider.cc
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/content/browser/message_port_provider_browsertest.cc
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/content/browser/service_worker/service_worker_dispatcher_host.cc
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/content/browser/service_worker/service_worker_dispatcher_host.h
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/content/browser/service_worker/service_worker_provider_host.h
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/content/browser/service_worker/service_worker_version.cc
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/content/browser/service_worker/service_worker_version.h
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/content/browser/shared_worker/shared_worker_connector_impl.cc
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/content/browser/shared_worker/shared_worker_host.cc
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/content/browser/shared_worker/shared_worker_host.h
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/content/browser/shared_worker/shared_worker_service_impl.cc
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/content/browser/shared_worker/shared_worker_service_impl.h
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/content/browser/shared_worker/shared_worker_service_impl_unittest.cc
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/content/child/BUILD.gn
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/content/child/service_worker/service_worker_dispatcher.cc
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/content/child/service_worker/service_worker_dispatcher_unittest.cc
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/content/child/service_worker/web_service_worker_impl.cc
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/content/child/service_worker/web_service_worker_impl.h
[add] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/content/child/webmessageportchannel_impl.cc
[add] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/content/child/webmessageportchannel_impl.h
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/content/common/BUILD.gn
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/content/common/DEPS
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/content/common/content_param_traits.cc
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/content/common/content_param_traits.h
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/content/common/frame_messages.h
[rename] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/content/common/message_port.cc
[add] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/content/common/message_port.h
[rename] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/content/common/message_port.mojom
[rename] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/content/common/message_port_message.cc
[rename] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/content/common/message_port_message.h
[add] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/content/common/message_port_message_struct_traits.cc
[add] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/content/common/message_port_message_struct_traits.h
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/content/common/native_types.typemap
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/content/common/service_worker/service_worker_messages.h
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/content/common/view_messages.h
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/content/ppapi_plugin/ppapi_blink_platform_impl.cc
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/content/ppapi_plugin/ppapi_blink_platform_impl.h
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/content/renderer/render_frame_proxy.cc
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/content/renderer/render_view_impl.cc
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/content/renderer/renderer_blink_platform_impl.h
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/content/renderer/service_worker/service_worker_context_client.h
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/content/renderer/shared_worker/embedded_shared_worker_stub.cc
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/content/renderer/shared_worker/embedded_shared_worker_stub.h
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/content/renderer/shared_worker/shared_worker_client_impl.cc
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/content/renderer/shared_worker/shared_worker_repository.cc
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/content/renderer/shared_worker/shared_worker_repository.h
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/third_party/WebKit/PRESUBMIT.py
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/third_party/WebKit/Source/bindings/core/v8/serialization/SerializedScriptValueFuzzer.cpp
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializerTest.cpp
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/third_party/WebKit/Source/core/dom/MessageChannel.cpp
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/third_party/WebKit/Source/core/dom/MessagePort.cpp
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/third_party/WebKit/Source/core/dom/MessagePort.h
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/third_party/WebKit/Source/core/events/MessageEvent.cpp
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/third_party/WebKit/Source/core/events/MessageEvent.h
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/third_party/WebKit/Source/core/exported/SharedWorkerRepositoryClientImpl.cpp
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/third_party/WebKit/Source/core/exported/SharedWorkerRepositoryClientImpl.h
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/third_party/WebKit/Source/core/exported/WebDOMMessageEvent.cpp
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/third_party/WebKit/Source/core/exported/WebSharedWorkerImpl.cpp
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/third_party/WebKit/Source/core/exported/WebSharedWorkerImpl.h
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/third_party/WebKit/Source/core/frame/DOMWindow.cpp
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/third_party/WebKit/Source/core/workers/DedicatedWorker.cpp
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/third_party/WebKit/Source/core/workers/DedicatedWorkerGlobalScope.cpp
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/third_party/WebKit/Source/core/workers/DedicatedWorkerMessagingProxy.cpp
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/third_party/WebKit/Source/core/workers/DedicatedWorkerMessagingProxy.h
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/third_party/WebKit/Source/core/workers/DedicatedWorkerObjectProxy.cpp
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/third_party/WebKit/Source/core/workers/DedicatedWorkerObjectProxy.h
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/third_party/WebKit/Source/core/workers/SharedWorker.cpp
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/third_party/WebKit/Source/core/workers/SharedWorkerRepositoryClient.h
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.cpp
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.cpp
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.h
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.cpp
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeProxy.cpp
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeProxy.h
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/third_party/WebKit/Source/modules/serviceworkers/WebEmbeddedWorkerImplTest.cpp
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/third_party/WebKit/Source/platform/CrossThreadCopier.h
[add] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/third_party/WebKit/Source/platform/exported/WebMessagePortChannelClient.cpp
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/third_party/WebKit/common/BUILD.gn
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/third_party/WebKit/common/DEPS
[delete] https://crrev.com/818f2935aba99b00716f8ab2804c211d99c39f31/third_party/WebKit/common/message_port/OWNERS
[delete] https://crrev.com/818f2935aba99b00716f8ab2804c211d99c39f31/third_party/WebKit/common/message_port/message_port_channel.h
[delete] https://crrev.com/818f2935aba99b00716f8ab2804c211d99c39f31/third_party/WebKit/common/message_port/message_port_message_struct_traits.cc
[delete] https://crrev.com/818f2935aba99b00716f8ab2804c211d99c39f31/third_party/WebKit/common/message_port/message_port_message_struct_traits.h
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/third_party/WebKit/public/platform/Platform.h
[add] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/third_party/WebKit/public/platform/WebMessagePortChannel.h
[add] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/third_party/WebKit/public/platform/WebMessagePortChannelClient.h
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/third_party/WebKit/public/platform/WebVector.h
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorker.h
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerProviderClient.h
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/third_party/WebKit/public/web/WebDOMMessageEvent.h
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/third_party/WebKit/public/web/WebSharedWorker.h
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/third_party/WebKit/public/web/WebSharedWorkerClient.h
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/third_party/WebKit/public/web/WebSharedWorkerRepositoryClient.h
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h
[modify] https://crrev.com/f03b5a7edf0552e4b38d2d07de5eec7ab227f9f0/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextProxy.h

Project Member

Comment 17 by bugdroid1@chromium.org, Oct 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6dc8a881789007e9305415c9875a90a3fd023962

commit 6dc8a881789007e9305415c9875a90a3fd023962
Author: Marijn Kruisselbrink <mek@chromium.org>
Date: Wed Oct 04 02:33:23 2017

Reland "Onion Soupify MessagePort"

This is a reland of 17c5e2fb29bf938660314048ff85346670ab6abe with a
fix for the performance regression in that CL.

Original change's description:
> Onion Soupify MessagePort
>
> This involves moving content::MessagePort to blink::MessagePortChannel
> (in WebKit/common), and getting rid of WebMessagePortChannel.
>
> Bug:  769835 
> Change-Id: I91a22c84b11c67afe720c19066fa84cb9fb4fc7b
> Reviewed-on: https://chromium-review.googlesource.com/596782
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: Jeremy Roman <jbroman@chromium.org>
> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#505480}

TBR=dcheng@chromium.org,kinuko@chromium.org,jbroman@chromium.org,dpranke@chromium.org

Bug:  769835 ,  770834 
Change-Id: I76118a13bffb515058ac4bbed61270493de1ef34
Reviewed-on: https://chromium-review.googlesource.com/699515
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506280}
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/content/DEPS
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/content/browser/android/app_web_message_port.cc
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/content/browser/android/app_web_message_port.h
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/content/browser/message_port_provider.cc
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/content/browser/message_port_provider_browsertest.cc
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/content/browser/service_worker/service_worker_dispatcher_host.cc
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/content/browser/service_worker/service_worker_dispatcher_host.h
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/content/browser/service_worker/service_worker_provider_host.h
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/content/browser/service_worker/service_worker_version.cc
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/content/browser/service_worker/service_worker_version.h
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/content/browser/shared_worker/shared_worker_connector_impl.cc
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/content/browser/shared_worker/shared_worker_host.cc
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/content/browser/shared_worker/shared_worker_host.h
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/content/browser/shared_worker/shared_worker_service_impl.cc
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/content/browser/shared_worker/shared_worker_service_impl.h
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/content/browser/shared_worker/shared_worker_service_impl_unittest.cc
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/content/child/BUILD.gn
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/content/child/service_worker/service_worker_dispatcher.cc
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/content/child/service_worker/service_worker_dispatcher_unittest.cc
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/content/child/service_worker/web_service_worker_impl.cc
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/content/child/service_worker/web_service_worker_impl.h
[delete] https://crrev.com/7eabc099a4dcbf647d1bffcf009df0fff6b5b33a/content/child/webmessageportchannel_impl.cc
[delete] https://crrev.com/7eabc099a4dcbf647d1bffcf009df0fff6b5b33a/content/child/webmessageportchannel_impl.h
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/content/common/BUILD.gn
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/content/common/DEPS
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/content/common/content_param_traits.cc
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/content/common/content_param_traits.h
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/content/common/frame_messages.h
[delete] https://crrev.com/7eabc099a4dcbf647d1bffcf009df0fff6b5b33a/content/common/message_port.h
[delete] https://crrev.com/7eabc099a4dcbf647d1bffcf009df0fff6b5b33a/content/common/message_port_message_struct_traits.cc
[delete] https://crrev.com/7eabc099a4dcbf647d1bffcf009df0fff6b5b33a/content/common/message_port_message_struct_traits.h
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/content/common/native_types.typemap
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/content/common/service_worker/service_worker_messages.h
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/content/common/view_messages.h
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/content/ppapi_plugin/ppapi_blink_platform_impl.cc
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/content/ppapi_plugin/ppapi_blink_platform_impl.h
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/content/renderer/render_frame_proxy.cc
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/content/renderer/render_view_impl.cc
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/content/renderer/renderer_blink_platform_impl.h
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/content/renderer/service_worker/service_worker_context_client.h
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/content/renderer/shared_worker/embedded_shared_worker_stub.cc
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/content/renderer/shared_worker/embedded_shared_worker_stub.h
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/content/renderer/shared_worker/shared_worker_client_impl.cc
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/content/renderer/shared_worker/shared_worker_repository.cc
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/content/renderer/shared_worker/shared_worker_repository.h
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/third_party/WebKit/PRESUBMIT.py
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/third_party/WebKit/Source/bindings/core/v8/serialization/SerializedScriptValueFuzzer.cpp
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializerTest.cpp
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/third_party/WebKit/Source/core/dom/MessageChannel.cpp
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/third_party/WebKit/Source/core/dom/MessagePort.cpp
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/third_party/WebKit/Source/core/dom/MessagePort.h
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/third_party/WebKit/Source/core/events/MessageEvent.cpp
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/third_party/WebKit/Source/core/events/MessageEvent.h
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/third_party/WebKit/Source/core/exported/SharedWorkerRepositoryClientImpl.cpp
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/third_party/WebKit/Source/core/exported/SharedWorkerRepositoryClientImpl.h
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/third_party/WebKit/Source/core/exported/WebDOMMessageEvent.cpp
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/third_party/WebKit/Source/core/exported/WebSharedWorkerImpl.cpp
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/third_party/WebKit/Source/core/exported/WebSharedWorkerImpl.h
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/third_party/WebKit/Source/core/frame/DOMWindow.cpp
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/third_party/WebKit/Source/core/workers/DedicatedWorker.cpp
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/third_party/WebKit/Source/core/workers/DedicatedWorkerGlobalScope.cpp
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/third_party/WebKit/Source/core/workers/DedicatedWorkerMessagingProxy.cpp
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/third_party/WebKit/Source/core/workers/DedicatedWorkerMessagingProxy.h
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/third_party/WebKit/Source/core/workers/DedicatedWorkerObjectProxy.cpp
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/third_party/WebKit/Source/core/workers/DedicatedWorkerObjectProxy.h
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/third_party/WebKit/Source/core/workers/SharedWorker.cpp
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/third_party/WebKit/Source/core/workers/SharedWorkerRepositoryClient.h
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.cpp
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.cpp
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.h
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.cpp
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeProxy.cpp
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeProxy.h
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/third_party/WebKit/Source/modules/serviceworkers/WebEmbeddedWorkerImplTest.cpp
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/third_party/WebKit/Source/platform/CrossThreadCopier.h
[delete] https://crrev.com/7eabc099a4dcbf647d1bffcf009df0fff6b5b33a/third_party/WebKit/Source/platform/exported/WebMessagePortChannelClient.cpp
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/third_party/WebKit/common/BUILD.gn
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/third_party/WebKit/common/DEPS
[add] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/third_party/WebKit/common/message_port/OWNERS
[rename] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/third_party/WebKit/common/message_port/message_port.mojom
[rename] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/third_party/WebKit/common/message_port/message_port_channel.cc
[add] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/third_party/WebKit/common/message_port/message_port_channel.h
[rename] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/third_party/WebKit/common/message_port/message_port_message.cc
[rename] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/third_party/WebKit/common/message_port/message_port_message.h
[add] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/third_party/WebKit/common/message_port/message_port_message_struct_traits.cc
[add] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/third_party/WebKit/common/message_port/message_port_message_struct_traits.h
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/third_party/WebKit/public/platform/Platform.h
[delete] https://crrev.com/7eabc099a4dcbf647d1bffcf009df0fff6b5b33a/third_party/WebKit/public/platform/WebMessagePortChannel.h
[delete] https://crrev.com/7eabc099a4dcbf647d1bffcf009df0fff6b5b33a/third_party/WebKit/public/platform/WebMessagePortChannelClient.h
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/third_party/WebKit/public/platform/WebVector.h
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorker.h
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerProviderClient.h
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/third_party/WebKit/public/web/WebDOMMessageEvent.h
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/third_party/WebKit/public/web/WebSharedWorker.h
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/third_party/WebKit/public/web/WebSharedWorkerClient.h
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/third_party/WebKit/public/web/WebSharedWorkerRepositoryClient.h
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h
[modify] https://crrev.com/6dc8a881789007e9305415c9875a90a3fd023962/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextProxy.h

Comment 18 by grt@chromium.org, Oct 4 2017

Issue 771353 has been merged into this issue.
Issue 771247 has been merged into this issue.

Comment 20 by mek@chromium.org, Oct 4 2017

Status: Fixed (was: Assigned)

Comment 21 by mek@chromium.org, Oct 11 2017

Issue 773251 has been merged into this issue.

Sign in to add a comment