Issue metadata
Sign in to add a comment
|
3-dot menu and its hover bound misalignment on Win and CrOS |
||||||||||||||||||||
Issue descriptionChrome Version : Canary - 63.0.3229(CrOS), 63.0.3230 (Win) What steps will reproduce the problem? 1. Maximize a browser window 2. Hover over the Chrome menu (3-dot next to Omnibox) What is the expected result? 3 dot icons aligned Hover bound aligned What happens instead of that? 3 dot icons not aligned (CrOS and Win) Hover bound not aligned (CrOS) Note: On OSX, the alignment is correct.
,
Oct 2 2017
Would like to figure out if this impacts earlier versions too
,
Oct 3 2017
Tested the issue on Win-10 using reported canary version #63.0.3230.0 and equivalent chrome version #63.0.3230.0. Observed that in the reported canary version, the issue is seen and 3 dot icons are not aligned. Whereas in the equivalent chrome version #63.0.3230.0, 3 dot icons are aligned as expected. Attached a screen cast for reference. hwi@ - Could you please check the issue on OS-Win using equivalent chrome version #63.0.3230.0 and please let us know the behavior. Thanks...!!
,
Oct 3 2017
+ some Views eng folks to take a look. Let's get this fixed in 63.
,
Oct 3 2017
For me the hover bound misaligns on Win10, it moves 2px to the right. The top two windows are maximized with/without hover. The bottom are windowed with/without hover (as can be seen w/ blue border and X moving).
,
Oct 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f7c83a9f75cafa100d71789b6ff1cd8af5efb3e6 commit f7c83a9f75cafa100d71789b6ff1cd8af5efb3e6 Author: Peter Boström <pbos@chromium.org> Date: Wed Oct 04 01:04:23 2017 Fix ink-drop alignment for animated AppMenuButton. The animated-button state overrides large parts of MenuButton, including layouting. When animating AppMenuButton the ink drop still traces image(), which is invisible. During layouting it positions new_icon_, which replaces image(), but also positions image() even though it's invisible, as the ink drop follows it. Ideally MenuButtons would work with animated icons. Layouting image() used GetLocalBounds() instead of GetContentsBounds() to place the ink drop, but GetLocalBounds() doesn't take insets into account, which are non-zero when the screen is maximized. This caused the ink drop to be displaced by 2dp when maximized. The fix just updates image() to follow new_icon_ so that the ink drop does as well. BUG= chromium:770807 Change-Id: Ifb3d9662aec1434708021904269969b832bbeb19 Reviewed-on: https://chromium-review.googlesource.com/699558 Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#506260} [modify] https://crrev.com/f7c83a9f75cafa100d71789b6ff1cd8af5efb3e6/chrome/browser/ui/views/toolbar/app_menu_button.cc
,
Oct 5 2017
Verified the fix on Win-10 using latest canary version #63.0.3233.0 as per the comment #0. Attaching screen shot for reference. Observed that 3 dot icons are aligned. Hence, the fix is working as expected. Adding the verified labels. Thanks...!!
,
Oct 5 2017
,
Oct 5 2017
This bug requires manual review: We don't branch M63 until 2017-10-12. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 5 2017
Thanks krajshree@! Oops, 63 hasn't branched yet so this is just good as is for now. spqchan@ if this is intended to launch on M62 can you apply the merge-request label for 62 and I'll take care of the merge (if approved). Thanks!
,
Oct 5 2017
Could you also verify this is fixed for Chrome OS? Thanks!
,
Oct 9 2017
Marking as fixed, this is not meeting the bar for 62. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by hwi@chromium.org
, Oct 2 2017