OnceCallback is The Future. See https://chromium.googlesource.com/chromium/src/+/master/docs/callback.md .
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec46f031ed0aafc978136cb8a227374adf82ce6b commit ec46f031ed0aafc978136cb8a227374adf82ce6b Author: Avi Drissman <avi@chromium.org> Date: Tue Oct 03 05:46:19 2017 Don't duplicate the dialog callback. This cleans up the relationship between the JavaScriptDialogTabHelper and the dialog implementation code. BUG= 770788 TEST=no change Change-Id: Ie1dbd91950717adf43a4e5f43041bfc1219baa8f Reviewed-on: https://chromium-review.googlesource.com/695961 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by: Sidney San MartÃn <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#505959} [modify] https://crrev.com/ec46f031ed0aafc978136cb8a227374adf82ce6b/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc [modify] https://crrev.com/ec46f031ed0aafc978136cb8a227374adf82ce6b/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/74256eb3b23d2d209c007fbac3a0756bc5ae073e commit 74256eb3b23d2d209c007fbac3a0756bc5ae073e Author: Avi Drissman <avi@chromium.org> Date: Tue Oct 03 16:03:53 2017 Switch webview permissions to OnceCallback. BUG= 770788 TEST=no change Change-Id: Iaaa8cc2dde639296588baad368e2e912610006a7 Reviewed-on: https://chromium-review.googlesource.com/696522 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#506055} [modify] https://crrev.com/74256eb3b23d2d209c007fbac3a0756bc5ae073e/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc [modify] https://crrev.com/74256eb3b23d2d209c007fbac3a0756bc5ae073e/extensions/browser/guest_view/web_view/web_view_permission_helper.cc [modify] https://crrev.com/74256eb3b23d2d209c007fbac3a0756bc5ae073e/extensions/browser/guest_view/web_view/web_view_permission_helper.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e04d39989fc56c1c959c34ccfe022c60605401af commit e04d39989fc56c1c959c34ccfe022c60605401af Author: Avi Drissman <avi@chromium.org> Date: Thu Oct 05 15:11:36 2017 Make DialogClosedCallback be a OnceCallback. BUG= 770788 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I5b0f2b2d6668bddfb92b6a452487edf69f817b1f Reviewed-on: https://chromium-review.googlesource.com/696684 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#506734} [modify] https://crrev.com/e04d39989fc56c1c959c34ccfe022c60605401af/android_webview/browser/aw_contents_client_bridge.cc [modify] https://crrev.com/e04d39989fc56c1c959c34ccfe022c60605401af/android_webview/browser/aw_contents_client_bridge.h [modify] https://crrev.com/e04d39989fc56c1c959c34ccfe022c60605401af/android_webview/browser/aw_javascript_dialog_manager.cc [modify] https://crrev.com/e04d39989fc56c1c959c34ccfe022c60605401af/android_webview/browser/aw_javascript_dialog_manager.h [modify] https://crrev.com/e04d39989fc56c1c959c34ccfe022c60605401af/chrome/browser/ui/javascript_dialogs/javascript_dialog.cc [modify] https://crrev.com/e04d39989fc56c1c959c34ccfe022c60605401af/chrome/browser/ui/javascript_dialogs/javascript_dialog.h [modify] https://crrev.com/e04d39989fc56c1c959c34ccfe022c60605401af/chrome/browser/ui/javascript_dialogs/javascript_dialog_browsertest.cc [modify] https://crrev.com/e04d39989fc56c1c959c34ccfe022c60605401af/chrome/browser/ui/javascript_dialogs/javascript_dialog_cocoa.h [modify] https://crrev.com/e04d39989fc56c1c959c34ccfe022c60605401af/chrome/browser/ui/javascript_dialogs/javascript_dialog_cocoa.mm [modify] https://crrev.com/e04d39989fc56c1c959c34ccfe022c60605401af/chrome/browser/ui/javascript_dialogs/javascript_dialog_mac.cc [modify] https://crrev.com/e04d39989fc56c1c959c34ccfe022c60605401af/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc [modify] https://crrev.com/e04d39989fc56c1c959c34ccfe022c60605401af/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h [modify] https://crrev.com/e04d39989fc56c1c959c34ccfe022c60605401af/chrome/browser/ui/javascript_dialogs/javascript_dialog_views.cc [modify] https://crrev.com/e04d39989fc56c1c959c34ccfe022c60605401af/chrome/browser/ui/javascript_dialogs/javascript_dialog_views.h [modify] https://crrev.com/e04d39989fc56c1c959c34ccfe022c60605401af/components/app_modal/javascript_app_modal_dialog.cc [modify] https://crrev.com/e04d39989fc56c1c959c34ccfe022c60605401af/components/app_modal/javascript_app_modal_dialog.h [modify] https://crrev.com/e04d39989fc56c1c959c34ccfe022c60605401af/components/app_modal/javascript_dialog_manager.cc [modify] https://crrev.com/e04d39989fc56c1c959c34ccfe022c60605401af/components/app_modal/javascript_dialog_manager.h [modify] https://crrev.com/e04d39989fc56c1c959c34ccfe022c60605401af/content/browser/devtools/protocol/devtools_protocol_browsertest.cc [modify] https://crrev.com/e04d39989fc56c1c959c34ccfe022c60605401af/content/browser/devtools/protocol/page_handler.cc [modify] https://crrev.com/e04d39989fc56c1c959c34ccfe022c60605401af/content/browser/devtools/protocol/page_handler.h [modify] https://crrev.com/e04d39989fc56c1c959c34ccfe022c60605401af/content/browser/frame_host/render_frame_host_impl_browsertest.cc [modify] https://crrev.com/e04d39989fc56c1c959c34ccfe022c60605401af/content/browser/web_contents/web_contents_impl.cc [modify] https://crrev.com/e04d39989fc56c1c959c34ccfe022c60605401af/content/browser/web_contents/web_contents_impl_browsertest.cc [modify] https://crrev.com/e04d39989fc56c1c959c34ccfe022c60605401af/content/browser/web_contents/web_contents_impl_unittest.cc [modify] https://crrev.com/e04d39989fc56c1c959c34ccfe022c60605401af/content/public/browser/javascript_dialog_manager.h [modify] https://crrev.com/e04d39989fc56c1c959c34ccfe022c60605401af/content/shell/browser/layout_test/layout_test_javascript_dialog_manager.cc [modify] https://crrev.com/e04d39989fc56c1c959c34ccfe022c60605401af/content/shell/browser/layout_test/layout_test_javascript_dialog_manager.h [modify] https://crrev.com/e04d39989fc56c1c959c34ccfe022c60605401af/content/shell/browser/shell_javascript_dialog.h [modify] https://crrev.com/e04d39989fc56c1c959c34ccfe022c60605401af/content/shell/browser/shell_javascript_dialog_mac.mm [modify] https://crrev.com/e04d39989fc56c1c959c34ccfe022c60605401af/content/shell/browser/shell_javascript_dialog_manager.cc [modify] https://crrev.com/e04d39989fc56c1c959c34ccfe022c60605401af/content/shell/browser/shell_javascript_dialog_manager.h [modify] https://crrev.com/e04d39989fc56c1c959c34ccfe022c60605401af/content/shell/browser/shell_javascript_dialog_win.cc [modify] https://crrev.com/e04d39989fc56c1c959c34ccfe022c60605401af/extensions/browser/guest_view/web_view/javascript_dialog_helper.cc [modify] https://crrev.com/e04d39989fc56c1c959c34ccfe022c60605401af/extensions/browser/guest_view/web_view/javascript_dialog_helper.h
Comment 1 by bugdroid1@chromium.org
, Oct 3 2017