New issue
Advanced search Search tips

Issue 770781 link

Starred by 1 user
Status: Fixed
Owner:
rogerm@chromium.org
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

[autofill] Support angularjs select with "string:" prefix.

Project Member Reported by rogerm@chromium.org, Oct 2 2017 
Chrome Version: 63.0.3230.0
OS: OSX

What steps will reproduce the problem?
(1) Have valid autofill address and credit card data
(2) browse to freepeople.com
(3) put an item in the cart and proceed to checkout
(4) attempt to autofill the credit-card for payment

What is the expected result?

All credit card related fields should be filled.

What happens instead?

The expiry month is not filled.

Diagnosis:

The field values are have a type prefix of "string:" prepended. Autofill knows to discard "number:" but not string.

See: https://github.com/angular/angular.js/blob/master/CHANGELOG.md#140-beta0-photonic-umbrakinesis-2015-01-13
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09de3f51d47d8ae94f7f30bde24aaa184d235c33

commit 09de3f51d47d8ae94f7f30bde24aaa184d235c33
Author: Roger McFarlane <rogerm@chromium.org>
Date: Mon Oct 02 20:44:48 2017

[autofill] Support angularjs select with "string:" prefix.

AngularJS can prefix the value in select elements with a type
prefix. Autofill already supports teh "number:" prefix. This
CL adds support for "string:".

Bug:  770781 
Change-Id: I5c2b272ca20a3f3a68e3445166c0df36ad5aa058
Reviewed-on: https://chromium-review.googlesource.com/695941
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505774}
[modify] https://crrev.com/09de3f51d47d8ae94f7f30bde24aaa184d235c33/components/autofill/core/browser/autofill_field.cc
[modify] https://crrev.com/09de3f51d47d8ae94f7f30bde24aaa184d235c33/components/autofill/core/browser/autofill_field_unittest.cc

Comment 2 by ma...@chromium.org, Oct 5 2017 

Fixed?

Comment 3 by rogerm@chromium.org, Oct 6 2017

Status: Fixed (was: Started)
►

Sign in to add a comment