New issue
Advanced search Search tips

Issue 770779 link

Starred by 1 user
Status: Fixed
Owner:
vakh@chromium.org
Closed: Nov 2017
Cc:
vakh@chromium.org
proberge@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug


Show other hotlists

Hotlists containing this issue:
EnamelAndFriendsFixIt


Sign in to add a comment

Incident Reporting: fully implement IsCsdWhitelistKillSwitchOn in V4 or remove it

Project Member Reported by proberge@chromium.org, Oct 2 2017 
The incident reporting code currently checks a kill switch before uploading an incident report. While the kill switch was implemented in LocalSafeBrowsingDatabaseManager, it has not yet been implemented in V4LocalDatabaseManager.

We should fully implement the IsCsdWhitelistKillSwitchOn call in V4, allowing us to quickly incident reporting if something goes wrong.

If we can't easily implement IsCsdWhitelistKillSwitchOn in V4, we should clean up its call from IncidentReportingService since V4 is fully launched.

Comment 1 by nparker@chromium.org, Oct 2 2017

Labels: -Pri-3 Pri-2
Owner: vakh@chromium.org
Good catch PA.  So, it's not hard to implement, but it's also something we haven't used or tested in many years. We should discuss with awoz@ and team if this is a lever they want to keep, or if a different mechanism would be better (or if any killswitch is needed).

Comment 2 by vakh@chromium.org, Oct 6 2017

Labels: SafeBrowsing-Triaged
Status: Assigned (was: Untriaged)

Comment 3 by vakh@chromium.org, Oct 16 2017 

We decided to remove it. I'll remove the function IsCsdWhitelistKillSwitchOn from the DatabaseManager.

Comment 4 by vakh@chromium.org, Oct 17 2017 

Discussion here: http://shortn/_JTBJ0CQrQJ

Comment 5 by est...@chromium.org, Nov 10 2017

Labels: Hotlist-EnamelAndFriendsFixIt
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7456ced6f61c4ef9e3dad3ea62364287894006e

commit d7456ced6f61c4ef9e3dad3ea62364287894006e
Author: Varun Khaneja <vakh@chromium.org>
Date: Wed Nov 15 18:53:42 2017

Remove the killswitch API from v3 and v4 SB DBs.

Bug:  770779 
Change-Id: I2deb8e00fc67d3707938a24a19c161dd3987820c
Reviewed-on: https://chromium-review.googlesource.com/770132
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Jialiu Lin (Low reply Nov 15-16) <jialiul@chromium.org>
Reviewed-by: proberge <proberge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516765}
[modify] https://crrev.com/d7456ced6f61c4ef9e3dad3ea62364287894006e/chrome/browser/safe_browsing/client_side_detection_host.cc
[modify] https://crrev.com/d7456ced6f61c4ef9e3dad3ea62364287894006e/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc
[modify] https://crrev.com/d7456ced6f61c4ef9e3dad3ea62364287894006e/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc
[modify] https://crrev.com/d7456ced6f61c4ef9e3dad3ea62364287894006e/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.h
[modify] https://crrev.com/d7456ced6f61c4ef9e3dad3ea62364287894006e/chrome/browser/safe_browsing/local_database_manager.cc
[modify] https://crrev.com/d7456ced6f61c4ef9e3dad3ea62364287894006e/chrome/browser/safe_browsing/local_database_manager.h
[modify] https://crrev.com/d7456ced6f61c4ef9e3dad3ea62364287894006e/chrome/browser/safe_browsing/safe_browsing_database.cc
[modify] https://crrev.com/d7456ced6f61c4ef9e3dad3ea62364287894006e/chrome/browser/safe_browsing/safe_browsing_database.h
[modify] https://crrev.com/d7456ced6f61c4ef9e3dad3ea62364287894006e/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
[modify] https://crrev.com/d7456ced6f61c4ef9e3dad3ea62364287894006e/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc
[modify] https://crrev.com/d7456ced6f61c4ef9e3dad3ea62364287894006e/components/safe_browsing/android/remote_database_manager.cc
[modify] https://crrev.com/d7456ced6f61c4ef9e3dad3ea62364287894006e/components/safe_browsing/android/remote_database_manager.h
[modify] https://crrev.com/d7456ced6f61c4ef9e3dad3ea62364287894006e/components/safe_browsing/db/database_manager.h
[modify] https://crrev.com/d7456ced6f61c4ef9e3dad3ea62364287894006e/components/safe_browsing/db/test_database_manager.cc
[modify] https://crrev.com/d7456ced6f61c4ef9e3dad3ea62364287894006e/components/safe_browsing/db/test_database_manager.h
[modify] https://crrev.com/d7456ced6f61c4ef9e3dad3ea62364287894006e/components/safe_browsing/db/v4_local_database_manager.cc
[modify] https://crrev.com/d7456ced6f61c4ef9e3dad3ea62364287894006e/components/safe_browsing/db/v4_local_database_manager.h

Comment 7 by vakh@chromium.org, Nov 15 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment