New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 770777 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Can't get paint timing events using performance.getEntriesByName

Reported by m...@thda.dk, Oct 2 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.100 Safari/537.36

Steps to reproduce the problem:
1. Execute this in the dev console on any page:
performance.getEntriesByName("first-paint")

What is the expected behavior?
I expected to get an array containing the "first-paint" performance entry, for which support was added in
https://www.chromestatus.com/feature/5688621814251520

What went wrong?
It returns an empty array - the only way to get the paint entries, is to use performance.getEntriesByType("paint") or performance.getEntries() and then filter by name manually.

Did this work before? No 

Does this work in other browsers? N/A

Chrome version: 61.0.3163.100  Channel: stable
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version:
 
Labels: Needs-Triage-M61
Cc: ranjitkan@chromium.org
Components: Platform>DevTools
Labels: M-63 OS-Linux OS-Mac
Status: Untriaged (was: Unconfirmed)
Rechecked this issue on Windows 10, Ubuntu 14.04 and Mac 10.12.6 using chrome version 61.0.3163.100 and canary version 63.0.3230.0. Able to reproduce it. Issue is a non regression as seen from M50 builds 50.0.2624.0 and is also observed on firefox browser as well.

Untriaged it so that issue gets addressed.

Thanks.!
Owner: maxlg@chromium.org
Status: Assigned (was: Untriaged)
Max, this feels similar to some work you've been doing - can you take a look? 
Cc: igrigo...@chromium.org
Hmm I thought we didn't need to support getEntriesByName with Performance Timeline 2, but I do see it in spec. 
Ilya - can you confirm this is necessary?

(Also there isn't an efficient, easy way to do lookups by name at the moment)


Components: -Platform>DevTools
It is. If we support getEntries / getEntriesByType, we need to support getEntriesByName — I'm not aware of any cases where we make an exception for byName, nor is there any reason to.. I think.

Comment 7 by maxlg@chromium.org, Oct 24 2017

I will get to this soon. Sorry for the waiting.
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb9a570f32aece6f8be504e9fac441369ad4a9ba

commit cb9a570f32aece6f8be504e9fac441369ad4a9ba
Author: Liquan (Max) Gu <maxlg@chromium.org>
Date: Mon Nov 06 18:14:08 2017

[PerformanceTimeline] Support paint entries for performance.getEntriesByName

performance.GetEntriesByName should support retrieving entries of 'first-paint' and
'first-contentful-paint' by their name. This CL is to enable such
behavior which returns an entryList containing the entry in both cases, as follows:

performance.getEntriesByName("first-paint")
performance.getEntriesByName("first-contentful-paint")

Bug:  770777 
Change-Id: I9be4e8b7ce21e680ca9509619d331a6a8fac6369
Reviewed-on: https://chromium-review.googlesource.com/735843
Reviewed-by: Shubhie Panicker <panicker@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Liquan Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514177}
[modify] https://crrev.com/cb9a570f32aece6f8be504e9fac441369ad4a9ba/third_party/WebKit/LayoutTests/external/wpt/paint-timing/first-contentful-paint.html
[modify] https://crrev.com/cb9a570f32aece6f8be504e9fac441369ad4a9ba/third_party/WebKit/Source/core/timing/PerformanceBase.cpp

Comment 9 by maxlg@google.com, Dec 14 2017

Status: Fixed (was: Assigned)

Sign in to add a comment