New issue
Advanced search Search tips

Issue 770776 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

command line "--disable-translate" option is ignored

Reported by zbigniew...@gmail.com, Oct 2 2017

Issue description

Chrome Version (from the about:version page): 61.0.3163.79
Is this the most recent version: yes
OS + version: 
Distributor ID:	Ubuntu
Description:	Ubuntu 16.04.3 LTS
Release:	16.04
Codename:	xenial

CPU architecture (32-bit / 64-bit): 64-bit
Window manager: 
URLs (if relevant): https://world.taobao.com/
Behavior in Linux Firefox:
Behavior in Windows Chrome (if you have access to it): no access

What steps will reproduce the problem?
(1) just run this command:
chromium-browser --user-data-dir=aqq  --disable-translate --no-first-run --kiosk https://world.taobao.com/

(2)
(3)

What is the expected result?
no translation window should pop-up since '--disable-translate' flag is added to the command line

What happens instead?
translation window pops-up

Please provide any additional information below. Attach a screenshot
and backtrace if possible.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.


 
Zrzut ekranu z 2017-10-02 19-50-26.png
19.4 KB View Download
Components: UI>Browser>Language>Translate UI>Shell>Kiosk
I'm not seeing a "disable-translate" flag in the source code.  It could have been removed.
Thank you for pointing this out.
It appears that I've using option that was removed in 2014:
https://codereview.chromium.org/143003020/patch/600001/610026

So the question is how to get rid of this translation pop-up in kiosk mode?

I am looking for "command line" solution since disabling this manually in chrome's settings is not an option for me.
Labels: Needs-Triage-M61

Comment 5 by napper@chromium.org, Oct 11 2017

Owner: yyushkina@chromium.org
Status: Assigned (was: Unconfirmed)
Assigning to Yana for product decision.
Owner: ----
Status: Available (was: Assigned)
I think the right product decision is to add the command line back in. 
Labels: Hotlist-GoodFirstBug
Owner: anthonyvd@chromium.org
Status: Assigned (was: Available)
Cc: anthonyvd@chromium.org
Owner: nicolaso@chromium.org
Project Member

Comment 9 by sheriffbot@chromium.org, Jun 18 2018

Labels: Hotlist-Recharge-BouncingOwner
Owner: ----
Status: Untriaged (was: Assigned)
The assigned owner "nicolaso@chromium.org" is not able to receive e-mails, please re-triage.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: nicolaso@chromium.org
Trying again, nicolaso@ is receiving the emails about not being able to receive email so...
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e5ff3d5d90764105ac0eef919f66b3406b64ffc

commit 9e5ff3d5d90764105ac0eef919f66b3406b64ffc
Author: Nicolas Ouellet-payeur <nicolaso@chromium.org>
Date: Wed Jun 20 16:07:16 2018

Add feature flag to enable/disable Translate.

This allows the user to enable/disable the Translate popup, either in
chrome://flags, or by using the `--disable-features=TranslateUI`
command-line flag.

Bug:  770776 
Change-Id: I66af0ce5de568bafb45e0e501cb4f481ac6d6fb3
Reviewed-on: https://chromium-review.googlesource.com/1105311
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Michael Martis <martis@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568860}
[modify] https://crrev.com/9e5ff3d5d90764105ac0eef919f66b3406b64ffc/chrome/browser/about_flags.cc
[modify] https://crrev.com/9e5ff3d5d90764105ac0eef919f66b3406b64ffc/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/9e5ff3d5d90764105ac0eef919f66b3406b64ffc/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/9e5ff3d5d90764105ac0eef919f66b3406b64ffc/components/translate/core/browser/translate_manager.cc
[modify] https://crrev.com/9e5ff3d5d90764105ac0eef919f66b3406b64ffc/components/translate/core/browser/translate_prefs.cc
[modify] https://crrev.com/9e5ff3d5d90764105ac0eef919f66b3406b64ffc/components/translate/core/browser/translate_prefs.h
[modify] https://crrev.com/9e5ff3d5d90764105ac0eef919f66b3406b64ffc/tools/metrics/histograms/enums.xml

Status: Fixed (was: Untriaged)
#11 should address this use case, thanks Nicolas!

Sign in to add a comment