New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 770775 link

Starred by 1 user
Status: Fixed
Owner:
█ mge...@chromium.org
Last visit > 30 days ago
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Don't cache DNS errors for 0 seconds

Project Member Reported by mge...@chromium.org, Oct 2 2017 
In a world where stale results are sometimes considered usable, we shouldn't overwrite successful results with errors if the error is likely caused by poor connectivity or other transient failure.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3bc6302c6fe2005c321e69775b45a9a103f702d

commit e3bc6302c6fe2005c321e69775b45a9a103f702d
Author: Miriam Gershenson <mgersh@chromium.org>
Date: Mon Oct 09 19:57:05 2017

Don't cache DNS errors with 0 TTL

Before we had a stale host resolver, saving these entries in the cache
made no difference. Now, caching a transient error can erase a result
that we might still want to use. To fix this issue, only cache an error
if it has a positive TTL.

Bug:  770775 
Change-Id: I86f782e04365a64f8e6ff5892db9744b4fbd1ca3
Reviewed-on: https://chromium-review.googlesource.com/698664
Reviewed-by: Julia Tuttle <juliatuttle@chromium.org>
Commit-Queue: Miriam Gershenson <mgersh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507457}
[modify] https://crrev.com/e3bc6302c6fe2005c321e69775b45a9a103f702d/net/dns/host_resolver_impl.cc
[modify] https://crrev.com/e3bc6302c6fe2005c321e69775b45a9a103f702d/net/dns/host_resolver_impl_unittest.cc

Comment 2 by mge...@chromium.org, Oct 9 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment