New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 770773 link

Starred by 1 user
Status: Fixed
Owner:
█ mge...@chromium.org
Last visit > 30 days ago
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

StaleHostResolver returns stale errors instead of waiting for good result

Project Member Reported by mge...@chromium.org, Oct 2 2017 
As far as I can think of, there's no advantage to returning ERR_NAME_NOT_RESOLVED before the resolve attempt itself has timed out or returned an error.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f87cf88e7f5600293f52d6afd9e319280a3a890d

commit f87cf88e7f5600293f52d6afd9e319280a3a890d
Author: Miriam Gershenson <mgersh@chromium.org>
Date: Mon Oct 09 19:11:03 2017

Don't return errors from stale host cache entries

If the cached entry is an error, it's not useful, so it's better to wait
for a result that might be a success than return the error quickly.

BUG= 770773 

Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I4040f95c4c1d58f657de6fd3b8157e4ae1cdab02
Reviewed-on: https://chromium-review.googlesource.com/697924
Reviewed-by: Julia Tuttle <juliatuttle@chromium.org>
Commit-Queue: Miriam Gershenson <mgersh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507440}
[modify] https://crrev.com/f87cf88e7f5600293f52d6afd9e319280a3a890d/components/cronet/stale_host_resolver.cc
[modify] https://crrev.com/f87cf88e7f5600293f52d6afd9e319280a3a890d/components/cronet/stale_host_resolver_unittest.cc

Comment 2 by mge...@chromium.org, Oct 9 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment