New issue
Advanced search Search tips

Issue 770766 link

Starred by 7 users

Issue metadata

Status: Closed
Owner:
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Allow running containers with multi-user

Project Member Reported by dgreid@chromium.org, Oct 2 2017

Issue description

Running containers or VMS is currently limited to /home/chronos/user/Downloads. This breaks when multiple accounts are active.

Fix this by passing the hashed user id from chrome to crosh so it can choose the correct Dowloads directory to access

 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57bf3f344950b4737417a3b879afd5d31462e205

commit 57bf3f344950b4737417a3b879afd5d31462e205
Author: Dylan Reid <dgreid@chromium.org>
Date: Tue Feb 06 16:07:07 2018

chromeos: Pass crosh the user hash

The user hash of the active user is needed so crosh can determine which
logged in user initiated a command. Crosh will use this data to pass the
correct paths to commands that run containers on Chrome OS.

Bug:  770766 

R=chirantan@chromium.org, tbarzic@chromium.org, vapier@chromium.org

Signed-off-by: Dylan Reid <dgreid@chromium.org>
Change-Id: I0e9ef3685dc3f01f15cfb428594b2f9752586676
Reviewed-on: https://chromium-review.googlesource.com/896105
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534691}
[modify] https://crrev.com/57bf3f344950b4737417a3b879afd5d31462e205/chrome/browser/extensions/api/terminal/terminal_private_api.cc
[modify] https://crrev.com/57bf3f344950b4737417a3b879afd5d31462e205/chrome/browser/extensions/api/terminal/terminal_private_api.h
[modify] https://crrev.com/57bf3f344950b4737417a3b879afd5d31462e205/chromeos/process_proxy/process_proxy.cc
[modify] https://crrev.com/57bf3f344950b4737417a3b879afd5d31462e205/chromeos/process_proxy/process_proxy.h
[modify] https://crrev.com/57bf3f344950b4737417a3b879afd5d31462e205/chromeos/process_proxy/process_proxy_registry.cc
[modify] https://crrev.com/57bf3f344950b4737417a3b879afd5d31462e205/chromeos/process_proxy/process_proxy_registry.h
[modify] https://crrev.com/57bf3f344950b4737417a3b879afd5d31462e205/chromeos/process_proxy/process_proxy_unittest.cc

Components: OS>Systems>Containers
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/f7a66e62bbe8039fb59fb4c82bdfe33654e4c03c

commit f7a66e62bbe8039fb59fb4c82bdfe33654e4c03c
Author: Dylan Reid <dgreid@chromium.org>
Date: Fri Feb 23 22:16:09 2018

crosh: Remove todo from vmc

The user id has is now used, no more need for a TODO.

TEST=no
BUG= 770766 

Change-Id: I7a4a13b78d1dcca9af76727efbb5d8c602a5cd2f
Signed-off-by: Dylan Reid <dgreid@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/933737
Reviewed-by: Stephen Barber <smbarber@chromium.org>

[modify] https://crrev.com/f7a66e62bbe8039fb59fb4c82bdfe33654e4c03c/crosh/crosh

Project Member

Comment 4 by bugdroid1@chromium.org, Feb 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/195b5526d9c1c30b5a1ab993fbda530d1aa23d8d

commit 195b5526d9c1c30b5a1ab993fbda530d1aa23d8d
Author: Dylan Reid <dgreid@chromium.org>
Date: Sat Feb 24 05:07:20 2018

crosh: Use correct user's Downloads directory

Chrome now passes the hash of the account using crosh. Using that for
the container's home directory means secondary users won't pull from the
primary user's Downloads folder when running a container with multi
profile.

TEST=crosh from multi-login accesses the correct downloads folder.
BUG= 770766 

Change-Id: Icb44df64ea38d64763890960352da9a4625d628c
Signed-off-by: Dylan Reid <dgreid@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/933738
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/195b5526d9c1c30b5a1ab993fbda530d1aa23d8d/crosh/crosh

Comment 5 by dgreid@chromium.org, Feb 27 2018

Status: Fixed (was: Available)
Status: Closed (was: Fixed)
Chrome Version: 72.0.3624.44
Chrome OS Version: 11316.60.0

Run vmc list from crosh for multiple user works correctly
Chrome version: 72.0.3626.0
Chrome OS: 11316.36.0, dev, eve

I did the following:
 1) Log in as primary user, turn on linux. After linux installation complete, lauch crosh, enter vmc list. It shows the size of diskspace allocated for the vm

 2) Log out the primary user. Log in as 2nd user. Turn on Linux. After linux installation completed, copy some files to the Linux files system

 3) Launch crosh, enter vmc list. It gives different number of disk allocation

Close

Sign in to add a comment