New issue
Advanced search Search tips

Issue 770758 link

Starred by 1 user
Status: Assigned
Owner:
chrisha@chromium.org
Cc:
jochen@chromium.org
a...@chromium.org
altimin@chromium.org
wfh@chromium.org
creis@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 99379



Sign in to add a comment

web_cache::WebCacheManager is not aware of OOPIFs

Project Member Reported by lukasza@chromium.org, Oct 2 2017 
web_cache::WebCacheManager::ObserveActivity has the following comment:

  // The cache manager assigns more cache resources to active renderer.  When a
  // renderer is active, it should inform the cache manager to receive more
  // cache resources.
  //
  // When a renderer moves from being inactive to being active, the cache
  // manager may decide to adjust its resource allocation, but it will delay
  // the recalculation, allowing ObserveActivity to return quickly.

Right now web_cache::WebCacheManager::ObserveActivity is called in response to CoreTabHelper::WasShown (a WebContentsObserver override).  The problem is that ObserveActivity is *only* called for main frame's renderer process (ignoring renderers handling OOPIFs).

Comment 1 by lukasza@chromium.org, Oct 2 2017

Cc: a...@chromium.org
Owner: thakis@chromium.org
<assigning for triage to a randomly selected owner from components/web_cache/OWNERS>

Not sure who owns this code now.  FWIW, I wasn't able to blame the problematic use of web_contents->GetRenderProcessHost very far - I got lost at r113808 which introduced chrome/browser/ui/tab_contents/core_tab_helper.cc at which point it already contained:

    void CoreTabHelper::DidBecomeSelected() {
      WebCacheManager::GetInstance()->ObserveActivity(
          tab_contents()->GetRenderProcessHost()->GetID());
    }

Comment 2 by lukasza@chromium.org, Oct 2 2017

Components: Internals>Network>Cache
<trying to assign components that fit>

Comment 3 by thakis@chromium.org, Oct 2 2017

Owner: ----
i had no idea i was in components/web_cache/OWNERS

Comment 4 by creis@chromium.org, Nov 18 2017

Blocking: 99379

Comment 5 by nasko@chromium.org, Dec 5 2017

Owner: jochen@chromium.org
jochen@, who would be a good owner for this?

Comment 6 by jochen@chromium.org, Dec 6 2017

Cc: jochen@chromium.org
Owner: ojan@chromium.org
Ojan, is this something the global resource coordinator team could take on?

Comment 7 by ojan@chromium.org, Jan 6 2018

Cc: altimin@chromium.org
Owner: chrisha@chromium.org
passing buck to chrisha, since his team is taking ownership of the resource_coordinator code.

Comment 8 by benhenry@chromium.org, Aug 1

Status: Assigned (was: Untriaged)
►

Sign in to add a comment