New issue
Advanced search Search tips

Issue 770756 link

Starred by 1 user
Status: Fixed
Owner:
beccahughes@chromium.org
Closed: Oct 2017
Cc:
estevenson@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug-Regression



Sign in to add a comment

24 KB regression in resource_sizes (MonochromePublic.apk) at 505625:505625

Project Member Reported by estevenson@chromium.org, Oct 2 2017 
Caused by “Media Controls: Adjust HTML layout and add background.”

Commit: 29ffeaf8e23c35e0ae2f1a265a394e20f3c7ceb1

Link to size graph: https://chromeperf.appspot.com/report?sid=a097e74b1aa288511afb4cb616efe0f95ba4d347ad61d5e835072f23450938ba&num_points=10&rev=505625

Debugging size regressions is documented at: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/apk_size_regressions.md#Debugging-Apk-Size-Increase

Based on the graph: 24 KB increase in native resources.
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Oct 2 2017 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=770756

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=daf084bd294efa3e0fc90dcab7f9030600162dedb1bdc807d5d90a6eaa5b0c9f


Bot(s) for this bug's original alert(s):

Android Builder

Comment 2 by estevenson@chromium.org, Oct 2 2017

Description: Show this description

Comment 3 by estevenson@chromium.org, Oct 2 2017

Cc: -estevenson@google.com estevenson@chromium.org
Labels: OS-Android
Owner: beccahughes@chromium.org
Status: Assigned (was: Untriaged)
Summary: 24 KB regression in resource_sizes (MonochromePublic.apk) at 505625:505625 (was: 0% regression in resource_sizes (MonochromePublic.apk) at 505625:505625)
beccahughes@ - it looks like you're already working on this in https://chromium-review.googlesource.com/c/chromium/src/+/692020. If so, it would be great if you could link to this issue in that CL. Thanks!
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/837637cba6b2e05f479c1a2c21d5d9bded37969a

commit 837637cba6b2e05f479c1a2c21d5d9bded37969a
Author: Becca Hughes <beccahughes@chromium.org>
Date: Wed Oct 04 13:00:17 2017

Media Controls: Remove duplicate resources

Now that MediaControlPainter has been removed we don't need
to directly package the images with Chrome (as they are included
in the CSS file). This removes the images from being packaged
with Chrome.

BUG= 770756 

Change-Id: Ib9dc22c57efe0cef2bb13cd745eaecce7d955c78
Reviewed-on: https://chromium-review.googlesource.com/698084
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506370}
[modify] https://crrev.com/837637cba6b2e05f479c1a2c21d5d9bded37969a/third_party/WebKit/Source/modules/media_controls/resources/media_controls_resources.grd

Comment 5 by estevenson@chromium.org, Oct 4 2017 

Thanks for looking at this. The CL in c#4 didn't affect size, but I noticed another alert (https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg09nNsQoM) that showed a 76 KB decrease related to these CLs, so feel free to close this as "Fixed" unless you think there's something else to be done here.

Comment 6 by beccahughes@chromium.org, Oct 4 2017

Status: Fixed (was: Assigned)

Comment 7 by estevenson@chromium.org, Oct 4 2017 

Saw another alert for 40 KB (https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg88CDtgkM) related to the same CLs for making sure the resource is marked as used. Still net savings/even anyways (+ 24 KB - 76 KB + 40 KB).
►

Sign in to add a comment