New issue
Advanced search Search tips

Issue 770755 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Chromium Gerrit mangles non-ASCII commit messages on merge

Project Member Reported by chadversary@chromium.org, Oct 2 2017

Issue description

Description
===========
I uploaded a CL[1] to Gerrit with below commit subject. Gerrit correctly preserved the subject during review.

    FROMLIST: intel: Add simple logging façade for Android

However, when the CQ merged[2] the CL, it mangled the subject by stripping non-ASCII characters.

    FROMLIST: intel: Add simple logging faade for Android


Why it's important
==================
When applying upstream commits to Chrome OS, we need to preserve the original commit's subject line. Otherwise, developers examining the git log will have too much difficulty mapping downstream commits to original upstream commits.



[1]: https://chromium-review.googlesource.com/c/chromiumos/third_party/mesa/+/648712
[2]: https://chromium.googlesource.com/chromiumos/third_party/mesa/+/d80921a64c35c08edae010a0b3cd13e21fc53af6
 

Sign in to add a comment