New issue
Advanced search Search tips

Issue 770750 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

ChopsDash: Add internal links for googlers

Project Member Reported by jojwang@google.com, Oct 2 2017

Issue description

Add incident links a/i/****** to incidents on the dashboard when a logged-in user is a googler.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/72b78aed694d87382510c4d726ea64a3bebdff72

commit 72b78aed694d87382510c4d726ea64a3bebdff72
Author: Joanna Wang <jojwang@google.com>
Date: Mon Oct 09 20:56:33 2017

Add googlers access.

Staging url:
https://11981-204d236-tainted-jojwang-dot-chopsdash.appspot.com/

Bug:770750

Change-Id: Idecd824c730b0ab40bb28742c8d7379bd9438d9c
Reviewed-on: https://chromium-review.googlesource.com/699433
Reviewed-by: Sean McCullough <seanmccullough@chromium.org>

[add] https://crrev.com/72b78aed694d87382510c4d726ea64a3bebdff72/go/src/infra/appengine/dashboard/frontend/elements/current-incident-icon.html
[modify] https://crrev.com/72b78aed694d87382510c4d726ea64a3bebdff72/go/src/infra/appengine/dashboard/frontend/elements/status-table.html
[add] https://crrev.com/72b78aed694d87382510c4d726ea64a3bebdff72/go/src/infra/appengine/dashboard/frontend/test/current-incident-icon_test.html
[modify] https://crrev.com/72b78aed694d87382510c4d726ea64a3bebdff72/go/src/infra/appengine/dashboard/frontend/elements/service-row.html
[modify] https://crrev.com/72b78aed694d87382510c4d726ea64a3bebdff72/go/src/infra/appengine/dashboard/frontend/templates/pages/home.html
[modify] https://crrev.com/72b78aed694d87382510c4d726ea64a3bebdff72/go/src/infra/appengine/dashboard/frontend/elements/incident-icon.html
[modify] https://crrev.com/72b78aed694d87382510c4d726ea64a3bebdff72/go/src/infra/appengine/dashboard/frontend/elements/chopsdash-app.html
[modify] https://crrev.com/72b78aed694d87382510c4d726ea64a3bebdff72/go/src/infra/appengine/dashboard/frontend/test/index.html
[modify] https://crrev.com/72b78aed694d87382510c4d726ea64a3bebdff72/go/src/infra/appengine/dashboard/frontend/dashboard_test.go

Comment 2 by jojwang@google.com, Oct 9 2017

Status: Fixed (was: Started)

Sign in to add a comment