Issue metadata
Sign in to add a comment
|
Encrypted media browser tests involving a crash timeout on Windows bots |
||||||||||||||||||||||
Issue descriptionIn particular, they only timeout when using mojo CDM: Mojo/ECKEncryptedMediaTest.CDMCrashDuringDecode/0 Mojo/ECKEncryptedMediaTest.MultipleCdmTypes I can repro the timeout locally. When the crash happens, a popup dialog containing the stacktrace is shown. If I close the dialog by clicking the button, the test passes. Otherwise, the test will timeout. This might explain why the test is failing on the bot. However, the pepper version of the same test passes on the bot, but timeouts for the same reason on my local build. I don't know why that is the case. It might be related to sandboxing. For now, I'll just disable the test for mojo+Win, and will revisit this when I have time.
,
Oct 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dc456f7ae450ef34dc659590288f8b132d2bdd2b commit dc456f7ae450ef34dc659590288f8b132d2bdd2b Author: Xiaohan Wang <xhwang@chromium.org> Date: Thu Oct 12 21:15:38 2017 media: Enable crash-related encrypted media browser tests on Windows Previously when using mojo CDM, the CDM runs in an unsandboxed CDM (utility) process. When crash happens, a popup dialog containing the stacktrace is shown. If I close the dialog by clicking the button, the test passes. Otherwise, the test will timeout, which is what happens on test bots. Now the CDM process is sandboxed. When the CDM crashes, no dialog is shown, and the test always passes. BUG= 770748 TEST=Enables disabled browsers tests. Change-Id: Ib084b14ee4fce745405a215ca827ade1e2050cf4 Reviewed-on: https://chromium-review.googlesource.com/717141 Reviewed-by: John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#508470} [modify] https://crrev.com/dc456f7ae450ef34dc659590288f8b132d2bdd2b/chrome/browser/media/encrypted_media_browsertest.cc
,
Oct 12 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by xhw...@chromium.org
, Oct 2 2017