New issue
Advanced search Search tips

Issue 770746 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Make clearer names for "blink_tool.py" commands.

Project Member Reported by qyears...@chromium.org, Oct 2 2017

Issue description

The name webkit-patch has nothing to do with what it actually is, which is a multi-command tool with various commands:

   analyze-baselines         Analyzes the baselines for the given tests and prints results that are identical.
   crash-log                 Print the newest crash log for the given process
   layout-test-server        Starts a local HTTP server which can run layout tests (given a list of layout tests to be run)
   optimize-baselines        Reshuffles the baselines for the given tests to use as little space on disk as possible.
   pretty-diff               Shows the pretty diff in the default browser
   print-baselines           Prints the baseline locations for given test(s) on the given port(s)
   print-expectations        Print the expected result for the given test(s) on the given port(s)
   print-flaky-tests         Print out flaky tests based on results from the flakiness dashboard
   rebaseline                Rebaseline tests with results from the continuous builders.
   rebaseline-cl             Fetches new baselines for a CL from test runs on try bots.
   rebaseline-expectations   Rebaselines the tests indicated in TestExpectations.
   rebaseline-server         Starts a local HTTP server which displays layout test failures (given a test

I propose that this should basically be split into 2 or 3 commands, e.g.:

   query (baselines, expectations, flaky-tests...)
   rebaseline (cl/from-try-jobs, expectations, from-waterfall)
   pretty-diff (this one is really applicable to all of Chromium and should be put somewhere else...)

This is slightly related to the Blink mv (bug 622551) but not dependent, and could be done anytime. It will involve first making the separate scripts, then updating all usages, then deleting "webkit-patch".
 

Comment 1 by tkent@chromium.org, Apr 21 2018

Summary: Make clearer names for "blink_tool.py" commands. (was: Make clearer names for "webkit-patch" commands.)

Sign in to add a comment