Just to be clear, are the strings approved?
From the comments on slides, it looks like the strings still need feedback. Thanks!

Good point. +srahim could you review these? Context is in the slide link in the description.

spqchan@ - looking the latest implementation in the real context, there're multiple states such as a messaging from extension. Would it be possible to get list of strings from the code both on the 3-dot accessibility label and on the menu item for different states? Thanks!

Adding "Update is available" for the 3-dot menu error state LGTM.

I agree w/c#5, can we get the other possible states and add ACCNAME messages, as appropriate, so that we have parity between the visual UI of the icon & the a11y UI? 

Non-blocking: do the a11y verbalizations on Chrome desktop UI typically include the tooltip? It makes for a rather lengthy verbalization, though I suppose the user can skip it if they don't want to listen to it.

    

From what I checked, no warning description for the upgrade states exists.
However, in the code, the warning level names are as followed:
- None (No update)
- Low (Green)
- Elevated (Yellow)
- High/Severe/Critical (Red)

+ellyjones@ for #7
Can you answer srahim's non-blocking question? Thanks!

#7: no - they generally should have their own strings, chosen to be verbalized well. tooltips often aren't appropriate for those. that said, a lot of places in the UI do reuse tooltip strings, so :shrug:

I started implementing this here: https://chromium-review.googlesource.com/c/chromium/src/+/869113

sky@ brought up a point about putting "Update available" in the tooltip. Should we put that there as well?

I think this would be useful as a way to inform all users of what the colors mean.

spqchan: Yeah, I think that's a good idea :)

Awesome, will do that then. Thanks!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c974f4683cca0541062bee0f65202ee58324aaa9

commit c974f4683cca0541062bee0f65202ee58324aaa9
Author: Sarah Chan <spqchan@chromium.org>
Date: Sat Jan 20 01:34:22 2018

[Views] Add Accessibility Text to App Menu Button

The App Menu Button AX text currently don't report if an
update is available. This CL fixes the issue by adding
"Update is available" to the AX text.

Bug:  770745 
Change-Id: I9e0768d21667c2b986ad7a5bc17c75f37b0bcb4d
Reviewed-on: https://chromium-review.googlesource.com/869113
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530720}
[modify] https://crrev.com/c974f4683cca0541062bee0f65202ee58324aaa9/chrome/app/chromium_strings.grd
[modify] https://crrev.com/c974f4683cca0541062bee0f65202ee58324aaa9/chrome/app/google_chrome_strings.grd
[modify] https://crrev.com/c974f4683cca0541062bee0f65202ee58324aaa9/chrome/browser/ui/views/toolbar/app_menu_button.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f02c862b51d6b169d5a501a050d587cc77a63dd1

commit f02c862b51d6b169d5a501a050d587cc77a63dd1
Author: spqchan <spqchan@chromium.org>
Date: Mon Feb 05 19:02:16 2018

[Mac] Add Browser's Update Status to the App Menu's Tooltip

Bug:  770745 
Change-Id: Id2f52fca8537250011ed5ef7c6c3276087e50268
Reviewed-on: https://chromium-review.googlesource.com/899679
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534440}
[modify] https://crrev.com/f02c862b51d6b169d5a501a050d587cc77a63dd1/chrome/browser/ui/cocoa/toolbar/app_toolbar_button.mm