Support Async ReadPixels in the Passthrough Command Decoder |
||
Issue descriptionHandle the gles2::cmds::ReadPixels::async in the passthrough command decoder instead of always doing a synchronous ReadPixels. Make sure it's tested with tests that are equivalent to GLES2ReadPixelsAsyncTest.
,
Oct 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/adaabc3658f4d58e83fc2705ad0a089e5fcf6437 commit adaabc3658f4d58e83fc2705ad0a089e5fcf6437 Author: Geoff Lang <geofflang@chromium.org> Date: Mon Oct 02 22:55:17 2017 Support PBO and map buffer extensions in the NULL backend. BUG= 770696 Change-Id: Ic7bcc2b5c76817888647022505a2442ce4016b1e Reviewed-on: https://chromium-review.googlesource.com/696125 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> [modify] https://crrev.com/adaabc3658f4d58e83fc2705ad0a089e5fcf6437/src/libANGLE/renderer/null/ContextNULL.cpp
,
Oct 3 2017
The following revision refers to this bug: https://skia.googlesource.com/skia/+/0804b57e12a64cb20c3389b5d36d0af6ed2332c2 commit 0804b57e12a64cb20c3389b5d36d0af6ed2332c2 Author: angle-deps-roller@chromium.org <angle-deps-roller@chromium.org> Date: Tue Oct 03 04:49:08 2017 Roll skia/third_party/externals/angle2/ 8c5b69cba..adaabc365 (6 commits) https://chromium.googlesource.com/angle/angle.git/+log/8c5b69cbaa10..adaabc3658f4 $ git log 8c5b69cba..adaabc365 --date=short --no-merges --format='%ad %ae %s' 2017-10-02 geofflang Support PBO and map buffer extensions in the NULL backend. 2017-10-02 geofflang Support GL_NV_fence in the NULL backend. 2017-09-26 geofflang Make GL_EXT_blend_minmax enableable. 2017-09-26 geofflang Make GL_OES_fbo_render_mipmap enableable. 2017-09-26 geofflang Make PBO and map buffer extensions enableable. 2017-09-29 jiawei.shao ES31: Implement glSampleMaski on D3D11 Created with: roll-dep skia/third_party/externals/angle2 BUG= 770696 , 770696 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Perf-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Perf-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Test-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Test-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE TBR=scroggo@google.com Change-Id: Ic6686493c8e0bf8a84e9b3326da0c46c92df49f5 Reviewed-on: https://skia-review.googlesource.com/54220 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> [modify] https://crrev.com/0804b57e12a64cb20c3389b5d36d0af6ed2332c2/DEPS
,
Oct 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/411cc36f29ffc664d40e842506b5a9f8a32c86f3 commit 411cc36f29ffc664d40e842506b5a9f8a32c86f3 Author: skia-deps-roller@chromium.org <skia-deps-roller@chromium.org> Date: Tue Oct 03 11:07:49 2017 Roll src/third_party/skia/ b437351d8..0804b57e1 (1 commit) https://skia.googlesource.com/skia.git/+log/b437351d880f..0804b57e12a6 $ git log b437351d8..0804b57e1 --date=short --no-merges --format='%ad %ae %s' 2017-10-03 angle-deps-roller Roll skia/third_party/externals/angle2/ 8c5b69cba..adaabc365 (6 commits) Created with: roll-dep src/third_party/skia BUG= 770696 , 770696 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: Ibd01ece8cf9b96b53163ed22452449cd35546c50 Reviewed-on: https://chromium-review.googlesource.com/696925 Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#506005} [modify] https://crrev.com/411cc36f29ffc664d40e842506b5a9f8a32c86f3/DEPS
,
Oct 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e22e068e2eaa0323ee1cb6f7c801345e8ba1415 commit 3e22e068e2eaa0323ee1cb6f7c801345e8ba1415 Author: Geoff Lang <geofflang@chromium.org> Date: Tue Oct 03 17:58:39 2017 Roll ANGLE db34227..a60d356 https://chromium.googlesource.com/angle/angle.git/+log/db34227..a60d356 BUG= 770696 TBR=cwallez@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I0c7ef983448698cea16e605bc1cb7cb9a2ad7799 Reviewed-on: https://chromium-review.googlesource.com/697625 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#506098} [modify] https://crrev.com/3e22e068e2eaa0323ee1cb6f7c801345e8ba1415/DEPS
,
Oct 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5899dbdc3d96db6d34db0ee9f25dd854f6ca92d2 commit 5899dbdc3d96db6d34db0ee9f25dd854f6ca92d2 Author: Geoff Lang <geofflang@chromium.org> Date: Thu Oct 05 14:23:43 2017 Implement async ReadPixels for the passthrough command decoder. BUG= 770696 TEST=GLReadbackTest.ReadPixelsWithPBOAndQuery TEST=GLES*DecoderPassthroughTest.ReadPixelsAsync* Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I5194075c8efe7c6b65830ce89719a1b3e048d7bb Reviewed-on: https://chromium-review.googlesource.com/696022 Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#506721} [modify] https://crrev.com/5899dbdc3d96db6d34db0ee9f25dd854f6ca92d2/gpu/command_buffer/service/feature_info.cc [modify] https://crrev.com/5899dbdc3d96db6d34db0ee9f25dd854f6ca92d2/gpu/command_buffer/service/feature_info.h [modify] https://crrev.com/5899dbdc3d96db6d34db0ee9f25dd854f6ca92d2/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc [modify] https://crrev.com/5899dbdc3d96db6d34db0ee9f25dd854f6ca92d2/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.h [modify] https://crrev.com/5899dbdc3d96db6d34db0ee9f25dd854f6ca92d2/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doer_prototypes.h [modify] https://crrev.com/5899dbdc3d96db6d34db0ee9f25dd854f6ca92d2/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc [modify] https://crrev.com/5899dbdc3d96db6d34db0ee9f25dd854f6ca92d2/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_handlers.cc [modify] https://crrev.com/5899dbdc3d96db6d34db0ee9f25dd854f6ca92d2/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_unittest_framebuffers.cc [modify] https://crrev.com/5899dbdc3d96db6d34db0ee9f25dd854f6ca92d2/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc [modify] https://crrev.com/5899dbdc3d96db6d34db0ee9f25dd854f6ca92d2/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h
,
Oct 5 2017
,
Oct 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8445c7a11e8193b04b8699f545dd822a9cff7333 commit 8445c7a11e8193b04b8699f545dd822a9cff7333 Author: Geoff Lang <geofflang@chromium.org> Date: Fri Oct 20 00:57:10 2017 Process pending read pixels and queries after MakeCurrent calls. This matches the validating command decoder's implementation and ends up processing completed queries earlier. BUG= 770696 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I573b80f08f920303c5b8d73c6d625dbd85fb3ddb Reviewed-on: https://chromium-review.googlesource.com/728866 Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#510279} [modify] https://crrev.com/8445c7a11e8193b04b8699f545dd822a9cff7333/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Oct 2 2017