New issue
Advanced search Search tips

Issue 770691 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression


Show other hotlists

Hotlists containing this issue:
Modern-Media-Controls


Sign in to add a comment

media/controls/lazy-loaded-style.html failing.

Project Member Reported by mkwst@chromium.org, Oct 2 2017

Issue description

Status: WontFix (was: Assigned)
CL was reverted.

Comment 2 by mkwst@chromium.org, Oct 2 2017

Ah, thanks! Sorry, the bot I was looking at was out of date. :)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3469580f613273293b37704f6ed4ba2cb2ab3648

commit 3469580f613273293b37704f6ed4ba2cb2ab3648
Author: Henrik Kjellander <kjellander@chromium.org>
Date: Wed Oct 04 07:27:44 2017

Update expectations for persistence-move-breakpoints-on-reload.html and lazy-loaded-style.html

These test have been failing on WebKit Win7 (dbg) recently.

TBR=lushnikov@chromium.org,beccahughes@chromium.org

Bug:  770691 ,  771518 
Change-Id: I8b625ae396da9066eaec235c86378fc4509e33e8
Notry: True
Reviewed-on: https://chromium-review.googlesource.com/699995
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Commit-Queue: Henrik Kjellander <kjellander@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506327}
[modify] https://crrev.com/3469580f613273293b37704f6ed4ba2cb2ab3648/third_party/WebKit/LayoutTests/TestExpectations

Labels: -Sheriff-Chromium
Components: Blink>Media>Controls
Summary: media/controls/lazy-loaded-style.html failing. (was: media/controls/lazy-loaded-style.html failing on Windows.)
It looks like this is failing on more platforms Mac10.11 and Linux. I'm going to update the expectations to include those.
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d69eef5d58164234fc155c05a7631f68af4ed2c3

commit d69eef5d58164234fc155c05a7631f68af4ed2c3
Author: Becca Hughes <beccahughes@chromium.org>
Date: Fri Oct 06 13:06:36 2017

Update tests expectations for lazy-loaded-style.html

This is failing on Mac10.11 and Linux too so updating the expectations.

BUG= 770691 

TBR=wjmaclean@chromium.org

Change-Id: Id9b5ca7f74ed381cb4feacc79cdf4a8560d31795
Reviewed-on: https://chromium-review.googlesource.com/704577
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507040}
[modify] https://crrev.com/d69eef5d58164234fc155c05a7631f68af4ed2c3/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 9 by bugdroid1@chromium.org, Apr 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2d08030badb3217450b251ba23633316aa4e9c7

commit f2d08030badb3217450b251ba23633316aa4e9c7
Author: Avi Drissman <avi@chromium.org>
Date: Sat Apr 14 20:34:59 2018

Disable virtual/new-remote-playback-pipeline/media/controls/lazy-loaded-style.html.

It fails on the Mac.

BUG= 775534 ,  770691 
NOTRY=true
TBR=steimel@chromium.org

Change-Id: I7d5c7650bb6ea0e2d443972d617e4eac0d82caac
Reviewed-on: https://chromium-review.googlesource.com/1013248
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550904}
[modify] https://crrev.com/f2d08030badb3217450b251ba23633316aa4e9c7/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 10 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2d08030badb3217450b251ba23633316aa4e9c7

commit f2d08030badb3217450b251ba23633316aa4e9c7
Author: Avi Drissman <avi@chromium.org>
Date: Sat Apr 14 20:34:59 2018

Disable virtual/new-remote-playback-pipeline/media/controls/lazy-loaded-style.html.

It fails on the Mac.

BUG= 775534 ,  770691 
NOTRY=true
TBR=steimel@chromium.org

Change-Id: I7d5c7650bb6ea0e2d443972d617e4eac0d82caac
Reviewed-on: https://chromium-review.googlesource.com/1013248
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550904}
[modify] https://crrev.com/f2d08030badb3217450b251ba23633316aa4e9c7/third_party/WebKit/LayoutTests/TestExpectations

Owner: mlamouri@chromium.org
Status: Started (was: Assigned)
I was looking into this in the context of something else and I have a fix.
Project Member

Comment 12 by bugdroid1@chromium.org, May 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9b69fd2c401686641f54a85535e247b8b347777

commit f9b69fd2c401686641f54a85535e247b8b347777
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Tue May 01 16:22:39 2018

Media Controls: fix lazy-loaded-style.html flaky test.

The test was expecting a screenshot comparison on a playing video which
ended up too dependant on timing. The test is now comparing to an HTML
page and on a paused video.

Bug:  770691 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I4660de5c480a51780468183215a9bcae68bfbc2f
Reviewed-on: https://chromium-review.googlesource.com/1037125
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555064}
[modify] https://crrev.com/f9b69fd2c401686641f54a85535e247b8b347777/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/fcc2bf3d910207fe591a81e17463461be4287304/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/media/controls/lazy-loaded-style-expected.txt
[add] https://crrev.com/f9b69fd2c401686641f54a85535e247b8b347777/third_party/WebKit/LayoutTests/media/controls/lazy-loaded-style-expected.html
[modify] https://crrev.com/f9b69fd2c401686641f54a85535e247b8b347777/third_party/WebKit/LayoutTests/media/controls/lazy-loaded-style.html
[delete] https://crrev.com/fcc2bf3d910207fe591a81e17463461be4287304/third_party/WebKit/LayoutTests/platform/linux/media/controls/lazy-loaded-style-expected.png
[delete] https://crrev.com/fcc2bf3d910207fe591a81e17463461be4287304/third_party/WebKit/LayoutTests/platform/linux/media/controls/lazy-loaded-style-expected.txt
[delete] https://crrev.com/fcc2bf3d910207fe591a81e17463461be4287304/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/lazy-loaded-style-expected.png
[delete] https://crrev.com/fcc2bf3d910207fe591a81e17463461be4287304/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/lazy-loaded-style-expected.txt
[delete] https://crrev.com/fcc2bf3d910207fe591a81e17463461be4287304/third_party/WebKit/LayoutTests/platform/mac-mac10.10/media/controls/lazy-loaded-style-expected.png
[delete] https://crrev.com/fcc2bf3d910207fe591a81e17463461be4287304/third_party/WebKit/LayoutTests/platform/mac-mac10.10/media/controls/lazy-loaded-style-expected.txt
[delete] https://crrev.com/fcc2bf3d910207fe591a81e17463461be4287304/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/new-remote-playback-pipeline/media/controls/lazy-loaded-style-expected.png
[delete] https://crrev.com/fcc2bf3d910207fe591a81e17463461be4287304/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/new-remote-playback-pipeline/media/controls/lazy-loaded-style-expected.txt
[delete] https://crrev.com/fcc2bf3d910207fe591a81e17463461be4287304/third_party/WebKit/LayoutTests/platform/mac-mac10.11/media/controls/lazy-loaded-style-expected.png
[delete] https://crrev.com/fcc2bf3d910207fe591a81e17463461be4287304/third_party/WebKit/LayoutTests/platform/mac-mac10.11/media/controls/lazy-loaded-style-expected.txt
[delete] https://crrev.com/fcc2bf3d910207fe591a81e17463461be4287304/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/new-remote-playback-pipeline/media/controls/lazy-loaded-style-expected.png
[delete] https://crrev.com/fcc2bf3d910207fe591a81e17463461be4287304/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/new-remote-playback-pipeline/media/controls/lazy-loaded-style-expected.txt
[delete] https://crrev.com/fcc2bf3d910207fe591a81e17463461be4287304/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/controls/lazy-loaded-style-expected.png
[delete] https://crrev.com/fcc2bf3d910207fe591a81e17463461be4287304/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/new-remote-playback-pipeline/media/controls/lazy-loaded-style-expected.png
[delete] https://crrev.com/fcc2bf3d910207fe591a81e17463461be4287304/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/new-remote-playback-pipeline/media/controls/lazy-loaded-style-expected.png
[delete] https://crrev.com/fcc2bf3d910207fe591a81e17463461be4287304/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/new-remote-playback-pipeline/media/controls/lazy-loaded-style-expected.txt
[delete] https://crrev.com/fcc2bf3d910207fe591a81e17463461be4287304/third_party/WebKit/LayoutTests/platform/mac/media/controls/lazy-loaded-style-expected.png
[delete] https://crrev.com/fcc2bf3d910207fe591a81e17463461be4287304/third_party/WebKit/LayoutTests/platform/mac/media/controls/lazy-loaded-style-expected.txt
[delete] https://crrev.com/fcc2bf3d910207fe591a81e17463461be4287304/third_party/WebKit/LayoutTests/platform/win/media/controls/lazy-loaded-style-expected.png
[delete] https://crrev.com/fcc2bf3d910207fe591a81e17463461be4287304/third_party/WebKit/LayoutTests/platform/win/media/controls/lazy-loaded-style-expected.txt
[delete] https://crrev.com/fcc2bf3d910207fe591a81e17463461be4287304/third_party/WebKit/LayoutTests/platform/win7/media/controls/lazy-loaded-style-expected.png
[delete] https://crrev.com/fcc2bf3d910207fe591a81e17463461be4287304/third_party/WebKit/LayoutTests/platform/win7/media/controls/lazy-loaded-style-expected.txt
[delete] https://crrev.com/fcc2bf3d910207fe591a81e17463461be4287304/third_party/WebKit/LayoutTests/platform/win7/virtual/new-remote-playback-pipeline/media/controls/lazy-loaded-style-expected.png
[delete] https://crrev.com/fcc2bf3d910207fe591a81e17463461be4287304/third_party/WebKit/LayoutTests/platform/win7/virtual/new-remote-playback-pipeline/media/controls/lazy-loaded-style-expected.txt

Status: Fixed (was: Started)

Sign in to add a comment