New issue
Advanced search Search tips

Issue 770685 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 770700



Sign in to add a comment

Remove references to no longer supported --output-format=json

Project Member Reported by perezju@chromium.org, Oct 2 2017

Issue description

From: https://github.com/catapult-project/catapult/issues/3810

The --output-format=json is no longer supported, but a few references in the code remain to it.

I think it matches all of them:
https://cs.chromium.org/search/?q=%5C-%5C-output%5C-format%5B+%3D%5Djson%5B%5E-%5D&type=cs

This bug is to track cleaning them up.
 
Blockedon: 770700
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee12a2ae6e85ff412ad59abf91706e8856a9aef8

commit ee12a2ae6e85ff412ad59abf91706e8856a9aef8
Author: Juan A. Navarro Perez <perezju@chromium.org>
Date: Mon Oct 02 16:20:18 2017

[memory-infra] docs: Remove reference to --output-format json

The format is no longer supported by Telmetry, and the default
(--output-format html) already produces both results.html and traces.

Bug:  770685 
Change-Id: Iafe2a91a928d74fd3ad248957b010793464d5d98
Reviewed-on: https://chromium-review.googlesource.com/692943
Reviewed-by: Ben Hayden <benjhayden@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505636}
[modify] https://crrev.com/ee12a2ae6e85ff412ad59abf91706e8856a9aef8/docs/memory-infra/memory_benchmarks.md

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/117560741b21ecaefedf407c216ea24e65e6bc83

commit 117560741b21ecaefedf407c216ea24e65e6bc83
Author: Juan A. Navarro Perez <perezju@chromium.org>
Date: Tue Oct 03 12:22:02 2017

Remove references to --output-format=json

The format is no longer supported by Telemetry, but it is still
mentioned in some docstrings and test data.

Bug:  chromium:770685 
Change-Id: I7365ecb46e92e1e7882553f4c927b1778ab81a3a
Reviewed-on: https://chromium-review.googlesource.com/695110
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>

[modify] https://crrev.com/117560741b21ecaefedf407c216ea24e65e6bc83/dashboard/dashboard/services/swarming_service_test.py
[modify] https://crrev.com/117560741b21ecaefedf407c216ea24e65e6bc83/telemetry/telemetry/page/shared_page_state.py

Status: Fixed (was: Assigned)
This is done. Last few remaining cleanup efforts at issue 770700.

Sign in to add a comment