Send emails with direct link to issue and build number for LUCI tryjobs |
|||||||
Issue descriptionWhen I run some trybots on one of my cls, and the trybot finishes, I get a mail with some useful links, e.g., try success for buildbucket on android_rel @ rb0a020783890e526263ef9ecbbeb4048653559d0 http://build.chromium.org/p/tryserver.webrtc/ You are awesome! Try succeeded! Build: 28359 on android_rel slave: slave1216-c4 base revision: b0a020783890e526263ef9ecbbeb4048653559d0 or, including the actual html links: try success for buildbucket on android_rel @ rb0a020783890e526263ef9ecbbe= b4048653559d0<p> <a href=3D"http://build.chromium.org/p/tryserver.webrtc/">http://build.ch= romium.org/p/tryserver.webrtc/</a><p> You are awesome! Try succeeded!<p>=20 Build: <a href=3D"http://build.chromium.org/p/tryserver.webrtc/builders/a= ndroid_rel/builds/28359">28359</a> on <a href=3D"http://build.chromium.org/p/tryserver.webrtc/builders/a= ndroid_rel">android_rel</a><br> slave: <a href=3D"http://build.chromium.org/p/tryserver.webrtc/buildslave= s/slave1216-c4">slave1216-c4</a><br> It would be nice to also have a link directly to the cl. Now, one has to first click on the build 28359 link and follow another link from there. With rietvald, there used to be such a direct link with the email. And it would be even better if the email also quoted the title of the issue. When I get these emails, my first question is always "which of my current cls is this result about?" and the easier that information is to find from the email, the better.
,
Oct 23 2017
I have little clue about how this works... Patrik, do you know where these emails are produced?
,
Oct 23 2017
They are produced here: https://cs.chromium.org/chromium/build/masters/master.tryserver.webrtc/master.cfg?l=251 c['status'].append(TryMailNotifier( fromaddr=ActiveMaster.from_address, reply_to=ActiveMaster.reply_to, subject='try %(result)s for %(reason)s @ r%(revision)s', mode='all', relayhost=config.Master.smtp, lookup=master_utils.UsersAreEmails())) It appears to be the same thing everyone else is using: https://cs.chromium.org/chromium/build/masters/master.tryserver.chromium.linux/master.cfg?type=cs&q=trymailnotifier&sq=package:chromium&l=578 Nisse, you have any mails from chromium try jobs to paste in for comparison?
,
Oct 23 2017
This is from a trybot notification sent back on May 8. Note the "issue" line, try success for buildbucket on win_x64_rel @ rd2690ddfff9202ee3caad5ba3a6ac125160cfcd5 http://build.chromium.org/p/tryserver.webrtc/ You are awesome! Try succeeded! Build: 25311 on win_x64_rel slave: vm234-m4 issue: 2828223002 raw patchset: 400001 or raw html: Content-Type: text/html; charset="iso-8859-1" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> <html xmlns=3D"http://www.w3.org/1999/xhtml"> <head> <title>try success for buildbucket @ rd2690ddfff9202ee3caad5ba3a6ac125160= cfcd5</title> </head> <body style=3D"font-family: Verdana, Cursor; font-size: 10px;"> try success for buildbucket on win_x64_rel @ rd2690ddfff9202ee3caad5ba3a6= ac125160cfcd5<p> <a href=3D"http://build.chromium.org/p/tryserver.webrtc/">http://build.ch= romium.org/p/tryserver.webrtc/</a><p> You are awesome! Try succeeded!<p>=20 Build: <a href=3D"http://build.chromium.org/p/tryserver.webrtc/builders/w= in_x64_rel/builds/25311">25311</a> on <a href=3D"http://build.chromium.org/p/tryserver.webrtc/builders/w= in_x64_rel">win_x64_rel</a><br> slave: <a href=3D"http://build.chromium.org/p/tryserver.webrtc/buildslave= s/vm234-m4">vm234-m4</a><br> issue: <a href=3D"https://codereview.webrtc.org/2828223002#ps400001">28= 28223002</a><br>raw patchset: <a href=3D"https://codereview.webrtc.org/down= load/issue2828223002_400001.diff">400001</a>
,
Oct 23 2017
Ok, it looks like the build properties 'issue', 'rietveld' and 'patchset' needs to be in the build properties for an issue link to get generated. They're not for either WebRTC or Chromium try waterfalls, so Chromium try jobs probably don't send out issue links either. It's probably simple to make it look at gerrit_patch, gerrit_url etc. instead.
,
Nov 3 2017
Welp, that's exciting, I thought we'd gotten rid of all of buildbot's built-in mail notifiers long ago. Sending over to the foundation team since they own buildbot.
,
Nov 4 2017
That's interesting. How dependent on these emails are you? They may go away completely soon since we're moving off of buildbot but we can get an issue on file to implement something similar for the new system.
,
Nov 6 2017
I often work on several cls in parallel, and then it's nice to get notified about try progress. The emails aren't that useful in their current form, though. They would be a lot more useful with direct link to the cl (like they used to have), and even better also a quote of the cl title.
,
Nov 6 2017
Ok, let's repurpose this bug as a feature request for nice emails in LUCI tryjobs as per #7 :)
,
Nov 7 2017
mknyszek@, do you have a similar need in Fuchsia? context: mknyszek@ already has luci-notify service that sends emails when a build of a builder fails, succeeds or results in a status different from the previous one. The app already sends emails. I believe it is must be easy to add support for tryjobs. It already has buildbucket pubsub plumbing in place.
,
Jun 16 2018
luci-notify got email templates feature https://chromium.googlesource.com/infra/luci/luci-go/+/master/luci_notify/doc/email_templates.md that enables putting the link. luci-notify doesn't support sending emails to CL authors yet, though.
,
Jun 17 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by aga...@chromium.org
, Oct 20 2017