SpellcheckCustomDictionaryTest.SyncBeforeLoadDoesNotDuplicateWords flaky on Windows |
||
Issue descriptionSee https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=unit_tests&tests=SpellcheckCustomDictionaryTest.SyncBeforeLoadDoesNotDuplicateWords On tryserver.chromium.win win7_chromium_rel_ng, out of the last 20 attempts, it only ever succeeded on the second try. Possibly related to ce42ef44c3eed5f149698aac79c9619d2decbace ( bug 689520 ) which removed BrowserThread::FILE usage from spellchecker files, which was reverted multiple times before.
,
Oct 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/19b4ec25bccc819849f3690f32005ac0d1b6448a commit 19b4ec25bccc819849f3690f32005ac0d1b6448a Author: Francois Doray <fdoray@chromium.org> Date: Wed Oct 04 18:35:43 2017 Fix SpellcheckCustomDictionaryTest.SyncBeforeLoadDoesNotDuplicateWords. Since the spellchecker code has been migrated from the FILE thread to TaskScheduler, tests need to use content::RunAllTasksUntilIdle() instead of base::RunLoop().RunUntilIdle() to wait for all spellchecker-related tasks to run. Bug: 770653 Change-Id: I8c4ac0e1183d8e11b8d60e334140e1fc1066d787 Reviewed-on: https://chromium-review.googlesource.com/695835 Reviewed-by: Rachel Blum <groby@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#506455} [modify] https://crrev.com/19b4ec25bccc819849f3690f32005ac0d1b6448a/chrome/browser/spellchecker/spellcheck_custom_dictionary_unittest.cc
,
Oct 4 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by fdoray@chromium.org
, Oct 2 2017Failure is: [ RUN ] SpellcheckCustomDictionaryTest.SyncBeforeLoadDoesNotDuplicateWords ../../chrome/browser/spellchecker/spellcheck_custom_dictionary_unittest.cc(523): error: Expected: kExpectedContentsPrefix Which is: "foo\nchecksum_v1 = " To be equal to: actual_contents_on_disk.substr(0, sizeof kExpectedContentsPrefix - 1) Which is: "" With diff: @@ -1,2 +1,1 @@ -foo -checksum_v1 = +"" Tentative fix at https://chromium-review.googlesource.com/c/chromium/src/+/695835