[radar] actool spurious notice message: AppIcon.appiconset/[][ipad][76x76][][][1x][][]: notice: (null) |
|||||||||
Issue descriptionWhen building Chrome ToT with XCode 9.1 I get the following errors: /* com.apple.actool.document.warnings */ gen/ios/chrome/app/resources/chromium_icons.xcassets:./AppIcon.appiconset: warning: A 1024x1024 app store icon is required for iOS apps /* com.apple.actool.document.notices */ gen/ios/chrome/app/resources/chromium_icons.xcassets:./AppIcon.appiconset/[][ipad][76x76][][][1x][][]: notice: (null)
,
Oct 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d5d3e332166dc2bfad12c4947d8e59499a93e565 commit d5d3e332166dc2bfad12c4947d8e59499a93e565 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Mon Oct 02 14:55:55 2017 Fix asset_catalog template to support file removal. If a file is removed from an asset catalog, it must be removed from the copy in $target_gen_dir so convert the target to use //build/config/ios/hardlink.py script to do the copy (it delete the target before doing the copy). Bug: 770634 Change-Id: Ib23df700cb1d553038306c546aa1fc04628bbf89 Reviewed-on: https://chromium-review.googlesource.com/695402 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Jean-François Geyelin <jif@chromium.org> Cr-Commit-Position: refs/heads/master@{#505611} [modify] https://crrev.com/d5d3e332166dc2bfad12c4947d8e59499a93e565/build/config/ios/asset_catalog.gni
,
Oct 2 2017
,
Oct 3 2017
The error about ipad 76x76 image looks like a bug of actool as the image is required if targeting iOS 7, 8 or 9. Radar radar://34767731 filed for that. Will add a workaround in compile_xcassets.py to ignore that particular error. For reference here is the error we get if we remove the image and try to compile with Xcode 9.0: gen/ios/chrome/app/resources/chromium_icons.xcassets:./AppIcon.appiconset: warning: A 76x76 app icon is required for iPad apps targeting iOS 7, 8, and 9
,
Oct 3 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/05ac64bfd12c71846d734491cf8c1dfc41480486 commit 05ac64bfd12c71846d734491cf8c1dfc41480486 Author: Sylvain Defresne <sdefresne@google.com> Date: Tue Oct 03 11:15:57 2017
,
Oct 3 2017
,
Oct 3 2017
,
Oct 3 2017
yuweih: this will likely affect remoting app. The fix is easy, just add a 1024x1024 image to the .appiconset used for remoting app, see https://chromium-review.googlesource.com/c/chromium/src/+/697365 for an example.
,
Oct 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/331d7ef11600b0fe3f571e8b77659a9eae363b17 commit 331d7ef11600b0fe3f571e8b77659a9eae363b17 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Tue Oct 03 13:25:59 2017 Add workaround for bug in actool in Xcode 9.1 β. Ignore spurious messages matching the spurious notice message emitted by Xcode 9.1 β version of actool. Bug: 770634 Change-Id: I186cae33297b197df379c3d12d4e10126778aa46 Reviewed-on: https://chromium-review.googlesource.com/697205 Reviewed-by: Jean-François Geyelin <jif@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#506017} [modify] https://crrev.com/331d7ef11600b0fe3f571e8b77659a9eae363b17/build/toolchain/mac/compile_xcassets.py [modify] https://crrev.com/331d7ef11600b0fe3f571e8b77659a9eae363b17/build/toolchain/mac/compile_xcassets_unittests.py
,
Oct 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/11bda7ed480fe429d1296967f32bd23fa0f0f750 commit 11bda7ed480fe429d1296967f32bd23fa0f0f750 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Tue Oct 03 13:57:36 2017 Add "marketing" asset required for Xcode 9.1 β. The "marketing" version of the icon (1024x1024) is required when building with Xcode 9.1 β, so add a version of the app icon at the correct size. Bug: 770634 Change-Id: Ia62345f2628035c8403beec313620a950429082d Reviewed-on: https://chromium-review.googlesource.com/697365 Reviewed-by: Jean-François Geyelin <jif@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#506021} [modify] https://crrev.com/11bda7ed480fe429d1296967f32bd23fa0f0f750/ios/chrome/app/resources/BUILD.gn [modify] https://crrev.com/11bda7ed480fe429d1296967f32bd23fa0f0f750/ios/chrome/app/resources/chromium/AppIcon.appiconset/Contents.json [add] https://crrev.com/11bda7ed480fe429d1296967f32bd23fa0f0f750/ios/chrome/app/resources/chromium/AppIcon.appiconset/Icon-1024.png
,
Oct 3 2017
Thanks to let us know in advance! I'll go ahead and fix it.
,
Oct 3 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/66dba5509e25e1e1daf021c373960bc533309314 commit 66dba5509e25e1e1daf021c373960bc533309314 Author: Yuwei Huang <yuweih@chromium.org> Date: Tue Oct 03 23:16:54 2017
,
Oct 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d69c0140d37e50a4c227aeb41bc7374da7ff5da8 commit d69c0140d37e50a4c227aeb41bc7374da7ff5da8 Author: Yuwei Huang <yuweih@chromium.org> Date: Wed Oct 04 01:08:06 2017 [CRD iOS] Add 1024x1024 Chromium icon Looks like Xcode 9.1 will have trouble compiling the app if it doesn't have the marketing icon. This CL adds the marketing icon for ios_remoting_app, i.e. the Chromium build. Bug: 770634 Change-Id: Ie8eb650f92d2361fdcbe245a257f99906f3cf155 Reviewed-on: https://chromium-review.googlesource.com/699239 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#506265} [modify] https://crrev.com/d69c0140d37e50a4c227aeb41bc7374da7ff5da8/remoting/ios/app/resources/BUILD.gn [modify] https://crrev.com/d69c0140d37e50a4c227aeb41bc7374da7ff5da8/remoting/ios/app/resources/chromium/AppIcon.appiconset/Contents.json [add] https://crrev.com/d69c0140d37e50a4c227aeb41bc7374da7ff5da8/remoting/ios/app/resources/chromium/AppIcon.appiconset/Icon-1024.png
,
Oct 4 2017
Changing issue title to remember why it is still open now that the issue assets have been updated and the spurious message ignored.
,
Oct 4 2017
Radar: radar://34767731
,
Oct 4 2017
,
Nov 2 2017
Quick update. This is still the case with Xcode 9.2 beta. The latest message on the radar is "A solution is under investigation. We will follow up with you again when it is available."
,
Nov 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/75bf824d0c9f8352702249fe2e99bb40284e272e commit 75bf824d0c9f8352702249fe2e99bb40284e272e Author: stkhapugin@chromium.org <stkhapugin@chromium.org> Date: Fri Nov 03 15:23:42 2017 Silence the compile_assets issue in Xcode 9.2 Since Xcode 9.2 has a slightly different error messages regarding assets on iPad and iOS < 10.0, add a broader regexp to silence them. Bug: 770634 Change-Id: I428775722b19ac87ca9602681eae49e78bc78dac Reviewed-on: https://chromium-review.googlesource.com/751522 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#513784} [modify] https://crrev.com/75bf824d0c9f8352702249fe2e99bb40284e272e/build/toolchain/mac/compile_xcassets.py
,
Nov 9
Comment on the radar on November 6: "This should be fixed on XCode 9.2 beta". The radar is closed. Does this still reproduce? |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by bugdroid1@chromium.org
, Oct 2 2017