New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 770631 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Buried. Ping if important.
Closed: Oct 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

cc_unittests failing on 2 builders

Project Member Reported by mkwst@chromium.org, Oct 2 2017

Issue description

cc_unittests failing on 2 builders

Builders failed on: 
- Linux ChromiumOS MSan Tests: 
  https://build.chromium.org/p/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests
- Linux MSan Tests: 


Started failing in https://build.chromium.org/p/chromium.memory/builders/Linux%20MSan%20Tests/builds/4662. I poked at the test a bit, but I couldn't make MSan happy. Might be something deeper down in the stack. :(


 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb

commit fe24d7f3ac1b5bcfb840a5ada01627df90a099eb
Author: Mike West <mkwst@chromium.org>
Date: Mon Oct 02 09:09:36 2017

Revert "Reland cc: Decode discardable images in PaintRecord backed shaders."

This reverts commit 8fafe68a2435c9992cda9906f7fc8bd7ec7d6daa.

Reason for revert:
- `cc_unittests` MSan failure, starting in https://build.chromium.org/p/chromium.memory/builders/Linux%20MSan%20Tests/builds/4662. 

Original change's description:
> Reland cc: Decode discardable images in PaintRecord backed shaders.
> 
> This relands commit 576bda00f9ee4d41f309069b88513b34049f58ee.
> 
> For PaintRecord backed shaders, the rasterization is done internally in
> skia, which means images present in these shaders are not pre-decoded
> by compositor's decode cache. This change ensures that we capture these
> images during discardable image analysis, and replace them with decoded
> images from the compositor's cache.
> 
> Replacing of these images requires transforming the PaintRecords in
> these shaders to SkPictures with decoded images before executing the op
> with the shader.
> 
> TBR=chrishtr@chromium.org, enne@chromium.org
> 
> Bug:  735741 , 728359
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I3b851a2824b89affb017284436e260ebd57649fc
> Reviewed-on: https://chromium-review.googlesource.com/690734
> Reviewed-by: Khushal <khushalsagar@chromium.org>
> Commit-Queue: Khushal <khushalsagar@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#505538}

TBR=chrishtr@chromium.org,enne@chromium.org,khushalsagar@chromium.org

Change-Id: I8a7fc965f9d15334c61102c5970057af94aa40fd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  735741 , 728359,  770631 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/692938
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505562}
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/cc/BUILD.gn
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/cc/paint/BUILD.gn
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/cc/paint/discardable_image_map.cc
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/cc/paint/discardable_image_map_unittest.cc
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/cc/paint/paint_op_buffer.cc
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/cc/paint/paint_op_buffer.h
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/cc/paint/paint_shader.cc
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/cc/paint/paint_shader.h
[delete] https://crrev.com/c43a18e85fe1c6f718273977c1b68c9d1fbcf51a/cc/paint/paint_shader_unittest.cc
[delete] https://crrev.com/c43a18e85fe1c6f718273977c1b68c9d1fbcf51a/cc/paint/scoped_image_flags.cc
[delete] https://crrev.com/c43a18e85fe1c6f718273977c1b68c9d1fbcf51a/cc/paint/scoped_image_flags.h
[delete] https://crrev.com/c43a18e85fe1c6f718273977c1b68c9d1fbcf51a/cc/paint/scoped_image_flags_unittest.cc
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/images/color-profile-background-image-space-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/linux/http/tests/misc/slow-loading-image-in-pattern-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/linux/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/linux/virtual/exotic-color-space/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/http/tests/misc/slow-loading-image-in-pattern-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/mac-mac10.10/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/exotic-color-space/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/mac-mac10.9/css3/masking/mask-repeat-space-padding-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/mac-mac10.9/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/exotic-color-space/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/mac/css3/masking/mask-repeat-space-padding-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/mac/fast/backgrounds/background-repeat-with-background-color-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/mac/http/tests/misc/slow-loading-image-in-pattern-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/mac/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/mac/images/cross-fade-background-size-expected.png
[delete] https://crrev.com/c43a18e85fe1c6f718273977c1b68c9d1fbcf51a/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/color-profile-background-image-space-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/cross-fade-background-size-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/cross-fade-background-size-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/mac/virtual/mojo-loading/http/tests/misc/slow-loading-image-in-pattern-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/win/css3/masking/mask-repeat-space-padding-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/win/fast/backgrounds/background-repeat-with-background-color-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/win/http/tests/misc/slow-loading-image-in-pattern-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/win/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/win/images/cross-fade-background-size-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/win/virtual/exotic-color-space/images/color-profile-background-image-space-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/win/virtual/exotic-color-space/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/win/virtual/exotic-color-space/images/cross-fade-background-size-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/cross-fade-background-size-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/win/virtual/mojo-loading/http/tests/misc/slow-loading-image-in-pattern-expected.png
[add] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/virtual/exotic-color-space/images/color-profile-background-image-space-expected.png

Comment 2 by mkwst@chromium.org, Oct 2 2017

Owner: mkwst@chromium.org
Status: Fixed (was: Available)
Bot recovered after revert.

Sign in to add a comment