TriggeredProfileResetter::profile_ is unused (but not in Windows) |
|||
Issue descriptionIf jumbo compiling chrome/browser the compilation fails because of a warning that TriggeredProfileResetter::activate_is_called is unused. The variable is only read in a DCHECK and for some reason jumbo builds care but not ordinary builds. I think it is because the compiler knows more than otherwise. Easy to fix with a couple of #if DCHECK_IS_ON()
,
Oct 3 2017
Actually the problem is the profile_ member which is unused in Linux/Mac but used in Windows. Might need some ifdefs here.
,
Oct 3 2017
,
Oct 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/df6c5c83bb9f21372ea56165ad56f2dd93dfb0a4 commit df6c5c83bb9f21372ea56165ad56f2dd93dfb0a4 Author: Daniel Bratell <bratell@opera.com> Date: Thu Oct 05 08:43:21 2017 Avoid "unused member" warnings by removing unused member. The profile_ member in TriggeredProfileResetter is not read by any code so let us remove it for platforms where it is not used. This warning appeared in jumbo build experiments (jumbo builds give the compiler more information which triggers warnings that were not there before). Bug: 770625 Change-Id: I4fd04d3147b01d0cf853b34c01ac7aa03fbd7d14 Reviewed-on: https://chromium-review.googlesource.com/695102 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#506679} [modify] https://crrev.com/df6c5c83bb9f21372ea56165ad56f2dd93dfb0a4/chrome/browser/profile_resetter/triggered_profile_resetter.cc [modify] https://crrev.com/df6c5c83bb9f21372ea56165ad56f2dd93dfb0a4/chrome/browser/profile_resetter/triggered_profile_resetter.h
,
Oct 5 2017
Fix has landed |
|||
►
Sign in to add a comment |
|||
Comment 1 by brat...@opera.com
, Oct 2 2017