Make them easy to merge.
Make them easy to make changes (especially from the onion-soup POV)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f41da2fcfb9409e0548ba83294f076173af1a4af commit f41da2fcfb9409e0548ba83294f076173af1a4af Author: Yutaka Hirano <yhirano@chromium.org> Date: Tue Oct 03 02:15:37 2017 Remove "parent_is_main_frame" property Remove the property from - content::ResourceRequest - content::ResourceRequestInfoImpl - content::RequestExtraData. It's not used. Bug: 770624 Change-Id: I30c557dc7bfbf31e62ecb3477020be78f80a8a9e Reviewed-on: https://chromium-review.googlesource.com/694406 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#505926} [modify] https://crrev.com/f41da2fcfb9409e0548ba83294f076173af1a4af/chrome/browser/data_usage/tab_id_annotator_unittest.cc [modify] https://crrev.com/f41da2fcfb9409e0548ba83294f076173af1a4af/chrome/browser/data_use_measurement/chrome_data_use_ascriber_unittest.cc [modify] https://crrev.com/f41da2fcfb9409e0548ba83294f076173af1a4af/chrome/browser/extensions/api/web_request/web_request_permissions_unittest.cc [modify] https://crrev.com/f41da2fcfb9409e0548ba83294f076173af1a4af/chrome/browser/extensions/extension_protocols_unittest.cc [modify] https://crrev.com/f41da2fcfb9409e0548ba83294f076173af1a4af/chrome/browser/net/chrome_network_delegate_unittest.cc [modify] https://crrev.com/f41da2fcfb9409e0548ba83294f076173af1a4af/chrome/browser/offline_pages/offline_page_request_job_unittest.cc [modify] https://crrev.com/f41da2fcfb9409e0548ba83294f076173af1a4af/chrome/browser/predictors/loading_test_util.cc [modify] https://crrev.com/f41da2fcfb9409e0548ba83294f076173af1a4af/chrome/browser/prerender/prerender_resource_throttle_unittest.cc [modify] https://crrev.com/f41da2fcfb9409e0548ba83294f076173af1a4af/chrome/browser/safe_browsing/incident_reporting/resource_request_detector_unittest.cc [modify] https://crrev.com/f41da2fcfb9409e0548ba83294f076173af1a4af/chrome/browser/signin/chrome_signin_helper_unittest.cc [modify] https://crrev.com/f41da2fcfb9409e0548ba83294f076173af1a4af/components/data_reduction_proxy/content/browser/content_lofi_decider_unittest.cc [modify] https://crrev.com/f41da2fcfb9409e0548ba83294f076173af1a4af/components/data_reduction_proxy/content/browser/content_lofi_ui_service_unittest.cc [modify] https://crrev.com/f41da2fcfb9409e0548ba83294f076173af1a4af/components/data_reduction_proxy/content/browser/content_resource_type_provider_unittest.cc [modify] https://crrev.com/f41da2fcfb9409e0548ba83294f076173af1a4af/content/browser/browsing_data/clear_site_data_throttle_unittest.cc [modify] https://crrev.com/f41da2fcfb9409e0548ba83294f076173af1a4af/content/browser/devtools/devtools_url_interceptor_request_job.cc [modify] https://crrev.com/f41da2fcfb9409e0548ba83294f076173af1a4af/content/browser/download/download_utils.cc [modify] https://crrev.com/f41da2fcfb9409e0548ba83294f076173af1a4af/content/browser/loader/async_resource_handler_unittest.cc [modify] https://crrev.com/f41da2fcfb9409e0548ba83294f076173af1a4af/content/browser/loader/detachable_resource_handler_unittest.cc [modify] https://crrev.com/f41da2fcfb9409e0548ba83294f076173af1a4af/content/browser/loader/intercepting_resource_handler_unittest.cc [modify] https://crrev.com/f41da2fcfb9409e0548ba83294f076173af1a4af/content/browser/loader/mime_sniffing_resource_handler_unittest.cc [modify] https://crrev.com/f41da2fcfb9409e0548ba83294f076173af1a4af/content/browser/loader/mojo_async_resource_handler_unittest.cc [modify] https://crrev.com/f41da2fcfb9409e0548ba83294f076173af1a4af/content/browser/loader/resource_dispatcher_host_impl.cc [modify] https://crrev.com/f41da2fcfb9409e0548ba83294f076173af1a4af/content/browser/loader/resource_dispatcher_host_unittest.cc [modify] https://crrev.com/f41da2fcfb9409e0548ba83294f076173af1a4af/content/browser/loader/resource_loader_unittest.cc [modify] https://crrev.com/f41da2fcfb9409e0548ba83294f076173af1a4af/content/browser/loader/resource_request_info_impl.cc [modify] https://crrev.com/f41da2fcfb9409e0548ba83294f076173af1a4af/content/browser/loader/resource_request_info_impl.h [modify] https://crrev.com/f41da2fcfb9409e0548ba83294f076173af1a4af/content/browser/security_exploit_browsertest.cc [modify] https://crrev.com/f41da2fcfb9409e0548ba83294f076173af1a4af/content/browser/service_worker/link_header_support_unittest.cc [modify] https://crrev.com/f41da2fcfb9409e0548ba83294f076173af1a4af/content/browser/service_worker/service_worker_fetch_dispatcher.cc [modify] https://crrev.com/f41da2fcfb9409e0548ba83294f076173af1a4af/content/browser/service_worker/service_worker_url_request_job_unittest.cc [modify] https://crrev.com/f41da2fcfb9409e0548ba83294f076173af1a4af/content/child/request_extra_data.cc [modify] https://crrev.com/f41da2fcfb9409e0548ba83294f076173af1a4af/content/child/request_extra_data.h [modify] https://crrev.com/f41da2fcfb9409e0548ba83294f076173af1a4af/content/common/resource_messages.h [modify] https://crrev.com/f41da2fcfb9409e0548ba83294f076173af1a4af/content/network/url_loader_unittest.cc [modify] https://crrev.com/f41da2fcfb9409e0548ba83294f076173af1a4af/content/public/browser/resource_request_info.h [modify] https://crrev.com/f41da2fcfb9409e0548ba83294f076173af1a4af/content/public/common/resource_request.h [modify] https://crrev.com/f41da2fcfb9409e0548ba83294f076173af1a4af/content/renderer/render_frame_impl.cc [modify] https://crrev.com/f41da2fcfb9409e0548ba83294f076173af1a4af/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc [modify] https://crrev.com/f41da2fcfb9409e0548ba83294f076173af1a4af/extensions/browser/api/declarative_webrequest/webrequest_condition_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/33df9d4f09e56fd37e48ab00c5e925b7ad2941c6 commit 33df9d4f09e56fd37e48ab00c5e925b7ad2941c6 Author: Yutaka Hirano <yhirano@chromium.org> Date: Tue Oct 03 03:41:33 2017 Remove "parent_frame_id" property Remove the property from - content::ResourceRequest - content::RequestExtraData. It is not used. Bug: 770624 Change-Id: Ibc5c6b2025a1c141b9a6ee07c7e3fcb3d2b9cfc2 Reviewed-on: https://chromium-review.googlesource.com/694703 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#505939} [modify] https://crrev.com/33df9d4f09e56fd37e48ab00c5e925b7ad2941c6/content/browser/download/download_utils.cc [modify] https://crrev.com/33df9d4f09e56fd37e48ab00c5e925b7ad2941c6/content/browser/security_exploit_browsertest.cc [modify] https://crrev.com/33df9d4f09e56fd37e48ab00c5e925b7ad2941c6/content/child/request_extra_data.cc [modify] https://crrev.com/33df9d4f09e56fd37e48ab00c5e925b7ad2941c6/content/child/request_extra_data.h [modify] https://crrev.com/33df9d4f09e56fd37e48ab00c5e925b7ad2941c6/content/common/resource_messages.h [modify] https://crrev.com/33df9d4f09e56fd37e48ab00c5e925b7ad2941c6/content/public/common/resource_request.h [modify] https://crrev.com/33df9d4f09e56fd37e48ab00c5e925b7ad2941c6/content/renderer/render_frame_impl.cc
(Also see https://bugs.chromium.org/p/chromium/issues/detail?id=860403#c3 for plausible steps)
Comment 1 by yhirano@chromium.org
, Oct 2 2017