We should add metrics for the following: * Asm.js -> Wasm [MB/sec] * Lazy compile function compile time [microseconds] * Lazy compile function compile rate [MB/sec] * Asm.js function size (hook up metric we have: V8.WasmFunctionSizeBytes.asm).
V8.WasmFunctionSizeBytes.asm seems to be already hooked up.
On a second look it seems it is. Sorry, when I looked at the dashboard before I didn't see data for some reason. Cool, one less thing.
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/70e76dae09645e643f0550baace8e93480ae2d7f commit 70e76dae09645e643f0550baace8e93480ae2d7f Author: Aseem Garg <aseemgarg@chromium.org> Date: Fri Oct 06 20:12:27 2017 [wasm] Add uma stat for asm.js module size BUG= chromium:770618 R=kschimpf@chromium.org,bradnelson@chromium.org,isherman@chromium.org Change-Id: I953c9e7b58de0ca9ac05a9f5f64f139fcf7dd1a7 Reviewed-on: https://chromium-review.googlesource.com/703890 Reviewed-by: Aseem Garg <aseemgarg@chromium.org> Reviewed-by: Brad Nelson <bradnelson@chromium.org> Commit-Queue: Brad Nelson <bradnelson@chromium.org> Cr-Commit-Position: refs/heads/master@{#48353} [modify] https://crrev.com/70e76dae09645e643f0550baace8e93480ae2d7f/src/asmjs/asm-js.cc [modify] https://crrev.com/70e76dae09645e643f0550baace8e93480ae2d7f/src/counters.h
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/2e62c5e916032cc59a144bb39e4936f37046ab57 commit 2e62c5e916032cc59a144bb39e4936f37046ab57 Author: Aseem Garg <aseemgarg@chromium.org> Date: Fri Oct 06 21:17:47 2017 [wasm] Add uma stat for asm.js to wasm throuput BUG= chromium:770618 R=kschimpf@chromium.org,bradnelson@chromium.org,isherman@chromium.org Change-Id: I33400fb277fff1e92a38753084c518f002685407 Reviewed-on: https://chromium-review.googlesource.com/704228 Commit-Queue: Aseem Garg <aseemgarg@chromium.org> Reviewed-by: Brad Nelson <bradnelson@chromium.org> Cr-Commit-Position: refs/heads/master@{#48354} [modify] https://crrev.com/2e62c5e916032cc59a144bb39e4936f37046ab57/src/asmjs/asm-js.cc [modify] https://crrev.com/2e62c5e916032cc59a144bb39e4936f37046ab57/src/counters.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e36a8e24bb82cbef66ae13d02533f41521d5326 commit 1e36a8e24bb82cbef66ae13d02533f41521d5326 Author: Aseem Garg <aseemgarg@chromium.org> Date: Fri Oct 06 22:55:03 2017 Add asm.js module size histogram BUG= chromium:770618 R=kschimpf@chromium.org,bradnelson@chromium.org,isherman@chromium.org Associated with V8 CL: https://chromium-review.googlesource.com/c/v8/v8/+/703890 Change-Id: I7a60816ab98807312fb4e26d901700d9cc5145f7 Reviewed-on: https://chromium-review.googlesource.com/704190 Commit-Queue: Aseem Garg <aseemgarg@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#507210} [modify] https://crrev.com/1e36a8e24bb82cbef66ae13d02533f41521d5326/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/042747e728a91a4381e13a04f5c6640fd3409a84 commit 042747e728a91a4381e13a04f5c6640fd3409a84 Author: Aseem Garg <aseemgarg@chromium.org> Date: Tue Oct 10 00:28:58 2017 Add asm.js to wasm translation throuput histogram BUG= chromium:770618 R=kschimpf@chromium.org,bradnelson@chromium.org,isherman@chromium.org Associated with V8 CL: https://chromium-review.googlesource.com/c/v8/v8/+/704228 Change-Id: Ice340f31277ac71f4ebf877aa2dbe0405d83ed2a Reviewed-on: https://chromium-review.googlesource.com/704007 Commit-Queue: Aseem Garg <aseemgarg@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#507552} [modify] https://crrev.com/042747e728a91a4381e13a04f5c6640fd3409a84/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f38d51553fb6384ff3af0a8a7343dcbde0b7669d commit f38d51553fb6384ff3af0a8a7343dcbde0b7669d Author: Aseem Garg <aseemgarg@chromium.org> Date: Tue Oct 10 02:23:20 2017 Add wasm function lazy compilation time histogram BUG= chromium:770618 R=kschimpf@chromium.org,bradnelson@chromium.org,isherman@chromium.org Change-Id: I011624b91c1f90f9c149773c045ceedb6545833a Reviewed-on: https://chromium-review.googlesource.com/704076 Commit-Queue: Aseem Garg <aseemgarg@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#507573} [modify] https://crrev.com/f38d51553fb6384ff3af0a8a7343dcbde0b7669d/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/9fdb8c8255ea1c9d9867d5266fe433b9155c49da commit 9fdb8c8255ea1c9d9867d5266fe433b9155c49da Author: Aseem Garg <aseemgarg@chromium.org> Date: Wed Oct 11 21:00:22 2017 [wasm] Add uma stat for wasm lazy throughput This CL adds an uma stat to track the throughput of lazy compilation for wasm functions in KB/s. BUG= chromium:770618 R=kschimpf@chromium.org,bradnelson@chromium.org,isherman@chromium.org Change-Id: Iad06cfb1f185f7e2ab6b0198282c03c3d8f29e2e Reviewed-on: https://chromium-review.googlesource.com/706276 Commit-Queue: Aseem Garg <aseemgarg@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Brad Nelson <bradnelson@chromium.org> Cr-Commit-Position: refs/heads/master@{#48475} [modify] https://crrev.com/9fdb8c8255ea1c9d9867d5266fe433b9155c49da/.gitignore [modify] https://crrev.com/9fdb8c8255ea1c9d9867d5266fe433b9155c49da/src/asmjs/asm-js.cc [modify] https://crrev.com/9fdb8c8255ea1c9d9867d5266fe433b9155c49da/src/counters.h [modify] https://crrev.com/9fdb8c8255ea1c9d9867d5266fe433b9155c49da/src/wasm/module-compiler.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b5a142305de9f8540a65fc3a42da94659bec0fa3 commit b5a142305de9f8540a65fc3a42da94659bec0fa3 Author: Aseem Garg <aseemgarg@chromium.org> Date: Tue Oct 17 01:12:57 2017 Add wasm lazy compilation throuput histogram This adds histogram to track the lazy compilation of wasm functions in KB/s BUG= chromium:770618 R=kschimpf@chromium.org,bradnelson@chromium.org,isherman@chromium.org Associated with V8 CL: https://chromium-review.googlesource.com/c/v8/v8/+/706276 Change-Id: I3ee5f1ae75fae9daa17c4d1fb698fd8713ad0683 Reviewed-on: https://chromium-review.googlesource.com/706562 Commit-Queue: Aseem Garg <aseemgarg@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#509202} [modify] https://crrev.com/b5a142305de9f8540a65fc3a42da94659bec0fa3/tools/metrics/histograms/histograms.xml
Comment 1 by bradnelson@chromium.org
, Oct 4 2017Owner: aseemgarg@chromium.org