New issue
Advanced search Search tips

Issue 770608 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

luci: 400 page is returned unexpectedly.

Project Member Reported by hidehiko@chromium.org, Oct 2 2017

Issue description

How to reproduce:

1) Visit https://luci-milo.appspot.com/buildbot/chromeos/betty-arc64-nyc-android-pfq/
2) Click #0.

Expected behavior:
- the status page is shown.

Actual bahavior:
- "Error: 400

BuildNumber must be > 0"
is shown.

BuildNumber = 0 should be allowed?
 

Comment 1 by no...@chromium.org, Oct 2 2017

Components: -Infra>Platform>Milo>LUCI Infra>Platform>Milo>Buildbot
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/0e76bafda0059b53c8d948cbad42a073162e5b74

commit 0e76bafda0059b53c8d948cbad42a073162e5b74
Author: Ryan Tseng <hinoka@google.com>
Date: Fri Oct 06 21:13:24 2017

[milo] Buildbot build #0 is a valid build number

Bug:  770608 
Change-Id: I37b856e65c390305fa3dae3d4d591074b51e87d7
Reviewed-on: https://chromium-review.googlesource.com/702017
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>

[modify] https://crrev.com/0e76bafda0059b53c8d948cbad42a073162e5b74/milo/buildsource/buildbot/build.go

Owner: hinoka@chromium.org
Status: Started (was: Untriaged)
(This seems started [and probably fixed, needs verification with fresh builder] so moving out of triage queue.)

Comment 4 by hinoka@chromium.org, Feb 28 2018

Status: Fixed (was: Started)

Comment 5 by efoo@chromium.org, Mar 1 2018

Labels: LUCI-Chromium-CQSets

Sign in to add a comment