New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 770605 link

Starred by 7 users
Status: Fixed
Owner:
patricia...@chromium.org
Closed: Oct 2017
Cc:
emilyschechter@chromium.org
nyerramilli@chromium.org
rbasuvula@chromium.org
patricia...@chromium.org
█ msrchandra@chromium.org
█ vamshi.k...@techmahindra.com
█ ranjitkan@chromium.org
benwells@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
Team-Security-UX



Sign in to add a comment

Regression: Cookies rows are shown multiple times and fill up the page info

Project Member Reported by tetsui@chromium.org, Oct 2 2017 
Chrome Version: 63.0.3230.0
OS: Chrome OS

What steps will reproduce the problem?
(1) Open https://www.theguardian.com/international
(2) Click on the top left "Secure" icon and show page info.

What is the expected result?
Cookies row should be shown at most once.

What happens instead?
Multiple cookies rows are shown and the layout is broken.
Screenshot 2017-10-02 at 2.08.15 PM.png
231 KB View Download

Comment 1 by patricia...@chromium.org, Oct 2 2017

Cc: -patricia...@chromium.org benwells@chromium.org
Owner: patricia...@chromium.org
Status: Started (was: Untriaged)
This is my fault, thank you for filing the bug! For reference, the breaking change was crrev.com/505322 (https://chromium-review.googlesource.com/c/chromium/src/+/686199). Fixing now.
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/59796218412c191ca4f69a7351fa0e006c6a70ec

commit 59796218412c191ca4f69a7351fa0e006c6a70ec
Author: Patti <patricialor@chromium.org>
Date: Tue Oct 03 02:43:21 2017

Desktop Page Info/Views: Only show cookies link once.

r505322 broke the Page Info bubble on Views by adding extra cookies links every
time the Site Data for that page was updated. Fix it by replacing the text
showing the number of cookies instead of always adding new links.

Bug:  770605 
Change-Id: I4ca6b716d4b0f3c13580d04a20a605e64f076eda
Reviewed-on: https://chromium-review.googlesource.com/696461
Reviewed-by: Lucas Garron <lgarron@chromium.org>
Commit-Queue: Patti <patricialor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505932}
[modify] https://crrev.com/59796218412c191ca4f69a7351fa0e006c6a70ec/chrome/browser/ui/views/page_info/page_info_bubble_view.cc
[modify] https://crrev.com/59796218412c191ca4f69a7351fa0e006c6a70ec/chrome/browser/ui/views/page_info/page_info_bubble_view.h
[modify] https://crrev.com/59796218412c191ca4f69a7351fa0e006c6a70ec/chrome/browser/ui/views/page_info/page_info_bubble_view_unittest.cc

Comment 3 by patricia...@chromium.org, Oct 3 2017

Status: Fixed (was: Started)

Comment 4 by patricia...@chromium.org, Oct 3 2017

Cc: msrchandra@chromium.org patricia...@chromium.org ranjitkan@chromium.org rbasuvula@chromium.org nyerramilli@chromium.org
 Issue 771059  has been merged into this issue.

Comment 5 by patricia...@chromium.org, Oct 3 2017

Cc: emilyschechter@chromium.org
 Issue 771412  has been merged into this issue.

Comment 6 by lgar...@chromium.org, Oct 9 2017 

Issue 771434 has been merged into this issue.

Comment 7 by vamshi.k...@techmahindra.com, Oct 16 2017

Cc: vamshi.k...@techmahindra.com
 Issue 774057  has been merged into this issue.

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 9 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)
►

Sign in to add a comment