ARC text input losts focus after moved to another display's screen |
|||||||||
Issue descriptionChrome Version: 63.0.3230.0 OS: R63-9981 What steps will reproduce the problem? (1) Plug an external display to the Chromebook running ARC. (2) Open the Settings app, type something in the search box. (3) Move the Settings app's window to the other display. (4) Continue typing something to the search area. What is the expected result? Expected: text is entered. What happens instead? Instead: nothing Probably a side-effect of https://codereview.chromium.org/2661863002 Since two displays have different root windows, to move between them OnWindowRemovingFromRootWindow is called in this case, but that does not imply the ARC window is unfocused.
,
Oct 5 2017
+domlaskowski FYI
,
Oct 5 2017
Conceptually this can be fixed by a one-line addition: https://chromium-review.googlesource.com/c/chromium/src/+/694721 but to be pedantically correct it actually needs some more work. I'm on it now.
,
Oct 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4d48b91d6cc62d050c327b6e7c9bca546731eb72 commit 4d48b91d6cc62d050c327b6e7c9bca546731eb72 Author: Kazuhiro Inaba <kinaba@chromium.org> Date: Fri Oct 06 14:36:42 2017 ARC: Fix text input focus when an ARC window is moved across displays. Not only before the window is closed, but also when the window is moved to another root window (belonging to another display), the event OnWindowRemovingFromRootWindow() is observed. In the latter case, the ARC window does not lose its focuse. BUG= 770598 TEST=ArcImeServiceTest TEST=Manual: move across displays and verify text inputs (770598) TEST=Manual: dismiss a notificaiton by tapping (685724) Change-Id: I8c0ce0d0ac9540ebe8aa9acf4f3038d06ec16f03 Reviewed-on: https://chromium-review.googlesource.com/694721 Commit-Queue: Kazuhiro Inaba <kinaba@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#507061} [modify] https://crrev.com/4d48b91d6cc62d050c327b6e7c9bca546731eb72/components/arc/ime/arc_ime_service.cc [modify] https://crrev.com/4d48b91d6cc62d050c327b6e7c9bca546731eb72/components/arc/ime/arc_ime_service.h [modify] https://crrev.com/4d48b91d6cc62d050c327b6e7c9bca546731eb72/components/arc/ime/arc_ime_service_unittest.cc
,
Oct 9 2017
,
Oct 9 2017
The CL of #4 should be applicable to M62 (and to M61) if needed, but since it was not noticed until this point after during M61/M62 beta period, so I'm assuming there's no urgent need. Feel free to reopen and request merging any anyone thinks it is needed.
,
Oct 9 2017
Could we merge this to M62? I did notice this bug, but was not sure how to reproduce.
,
Oct 9 2017
This bug requires manual review: We are only 7 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 10 2017
Approved for 62.
,
Oct 11 2017
OK, I'll do merging later today.
,
Oct 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a75e8c260bf32aafb4ead255cc486f47bb378ebe commit a75e8c260bf32aafb4ead255cc486f47bb378ebe Author: Kazuhiro Inaba <kinaba@chromium.org> Date: Wed Oct 11 02:26:20 2017 ARC: Fix text input focus when an ARC window is moved across displays. Not only before the window is closed, but also when the window is moved to another root window (belonging to another display), the event OnWindowRemovingFromRootWindow() is observed. In the latter case, the ARC window does not lose its focuse. BUG= 770598 TEST=ArcImeServiceTest TEST=Manual: move across displays and verify text inputs (770598) TEST=Manual: dismiss a notificaiton by tapping (685724) TBR=kinaba@chromium.org (cherry picked from commit 4d48b91d6cc62d050c327b6e7c9bca546731eb72) Change-Id: I8c0ce0d0ac9540ebe8aa9acf4f3038d06ec16f03 Reviewed-on: https://chromium-review.googlesource.com/694721 Commit-Queue: Kazuhiro Inaba <kinaba@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#507061} Reviewed-on: https://chromium-review.googlesource.com/711435 Reviewed-by: Kazuhiro Inaba <kinaba@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#654} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/a75e8c260bf32aafb4ead255cc486f47bb378ebe/components/arc/ime/arc_ime_service.cc [modify] https://crrev.com/a75e8c260bf32aafb4ead255cc486f47bb378ebe/components/arc/ime/arc_ime_service.h [modify] https://crrev.com/a75e8c260bf32aafb4ead255cc486f47bb378ebe/components/arc/ime/arc_ime_service_unittest.cc
,
Oct 11 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by kinaba@chromium.org
, Oct 2 2017