New issue
Advanced search Search tips

Issue 770487 link

Starred by 1 user
Status: Started
Owner:
dcheng@chromium.org
Cc:
creis@chromium.org
wfh@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Remove Blink code that uses WebHistoryItem::target_

Project Member Reported by dcheng@chromium.org, Sep 30 2017 
There are minimal dependencies on target_ at this point, and it looks like we can (almost) remove it.

The biggest issue is what to do with the unique name when building the HistoryEntry from PageState. Fortunately, it looks like all the HistoryNodes are owned by a unique_ptr, so we can probably just store it externally: this should allow layout test helpers to continue referring to it, while dropping the need to plumb it in and out of Blink.

Comment 1 by dcheng@chromium.org, Sep 30 2017 

(The motivation for dropping this entirely as much as possible in the renderer side is to make it possible to move unique name generation into the browser side)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef3118d7112ec9c006b859cdd0d133d4944d08bc

commit ef3118d7112ec9c006b859cdd0d133d4944d08bc
Author: Daniel Cheng <dcheng@chromium.org>
Date: Sun Oct 01 00:24:28 2017

Delete dead code in HistoryEntry / HistoryNode.

Bug: 770487
Change-Id: I70f4dba0c642261a60ea7243a16299151322b092
Reviewed-on: https://chromium-review.googlesource.com/693820
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505486}
[modify] https://crrev.com/ef3118d7112ec9c006b859cdd0d133d4944d08bc/content/renderer/history_entry.cc
[modify] https://crrev.com/ef3118d7112ec9c006b859cdd0d133d4944d08bc/content/renderer/history_entry.h
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d281e208511af212e8ec2f052f4a095f3cae62f3

commit d281e208511af212e8ec2f052f4a095f3cae62f3
Author: Daniel Cheng <dcheng@chromium.org>
Date: Tue Oct 03 02:00:12 2017

Move history dumps for layout tests to the browser process.

Bug: 477150, 770487
Change-Id: Ibc33860745735bee4818bc3de09323757b8235ec
Reviewed-on: https://chromium-review.googlesource.com/693557
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505922}
[modify] https://crrev.com/d281e208511af212e8ec2f052f4a095f3cae62f3/content/public/test/layouttest_support.h
[modify] https://crrev.com/d281e208511af212e8ec2f052f4a095f3cae62f3/content/shell/browser/layout_test/blink_test_controller.cc
[modify] https://crrev.com/d281e208511af212e8ec2f052f4a095f3cae62f3/content/shell/browser/layout_test/blink_test_controller.h
[modify] https://crrev.com/d281e208511af212e8ec2f052f4a095f3cae62f3/content/shell/common/shell_messages.h
[modify] https://crrev.com/d281e208511af212e8ec2f052f4a095f3cae62f3/content/shell/renderer/layout_test/blink_test_runner.cc
[modify] https://crrev.com/d281e208511af212e8ec2f052f4a095f3cae62f3/content/shell/renderer/layout_test/blink_test_runner.h
[modify] https://crrev.com/d281e208511af212e8ec2f052f4a095f3cae62f3/content/test/layouttest_support.cc
[modify] https://crrev.com/d281e208511af212e8ec2f052f4a095f3cae62f3/third_party/WebKit/LayoutTests/http/tests/media/autoplay/document-user-activation-navigation-click-expected.txt
[modify] https://crrev.com/d281e208511af212e8ec2f052f4a095f3cae62f3/third_party/WebKit/LayoutTests/http/tests/media/autoplay/document-user-activation-navigation-click.html
[modify] https://crrev.com/d281e208511af212e8ec2f052f4a095f3cae62f3/third_party/WebKit/LayoutTests/http/tests/media/autoplay/document-user-activation-navigation-keypress-expected.txt
[modify] https://crrev.com/d281e208511af212e8ec2f052f4a095f3cae62f3/third_party/WebKit/LayoutTests/http/tests/media/autoplay/document-user-activation-navigation-keypress.html
[modify] https://crrev.com/d281e208511af212e8ec2f052f4a095f3cae62f3/third_party/WebKit/LayoutTests/http/tests/media/autoplay/document-user-activation-navigation-nogesture-expected.txt
[modify] https://crrev.com/d281e208511af212e8ec2f052f4a095f3cae62f3/third_party/WebKit/LayoutTests/http/tests/media/autoplay/document-user-activation-navigation-nogesture.html
[modify] https://crrev.com/d281e208511af212e8ec2f052f4a095f3cae62f3/third_party/WebKit/LayoutTests/http/tests/media/autoplay/document-user-activation-navigation-tap-expected.txt
[modify] https://crrev.com/d281e208511af212e8ec2f052f4a095f3cae62f3/third_party/WebKit/LayoutTests/http/tests/media/autoplay/document-user-activation-navigation-tap.html
[modify] https://crrev.com/d281e208511af212e8ec2f052f4a095f3cae62f3/third_party/WebKit/LayoutTests/http/tests/media/autoplay/resources/test-autoplay.html
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db57d8325c7ba637033afd7d59f0aa9cc8749070

commit db57d8325c7ba637033afd7d59f0aa9cc8749070
Author: Lukasz Anforowicz <lukasza@chromium.org>
Date: Wed Oct 04 17:18:52 2017

No longer expect crashes for insecure-iframe-in-main-frame.html test.

After r505922, the
http/tests/security/mixedContent/insecure-iframe-in-main-frame.html test
will no longer crash, but we still have a test output difference with
--site-per-process because of https://crbug.com/771003 (because with
--site-per-process the newly opened https window is in a different
process than the main test frame).

Bug:  602493 , 770487
Change-Id: Ic19079c0edbb6c74cb2a2d408acada00340d8973
Notry: True
Reviewed-on: https://chromium-review.googlesource.com/699764
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506425}
[modify] https://crrev.com/db57d8325c7ba637033afd7d59f0aa9cc8749070/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1b954d9a6cf66a123ddf719860aa4e5b5cd2888

commit e1b954d9a6cf66a123ddf719860aa4e5b5cd2888
Author: Lukasz Anforowicz <lukasza@chromium.org>
Date: Mon Oct 30 21:28:06 2017

Move view-source handling to the //content layer.

This CL moves most of handling of view-source into the //content layer,
exposing it through a single public API:
  void RenderFrameHost::ViewSource()

This move helps to
- Avoid passing PageState to the //chrome layer (e.g. via
  content::CustomContextMenuContext).
- Create browser tests that can simulate triggerring a view-source
  from the code (e.g. without having to simulate mouse clicks).
- Ensure that the right navigation entries are used - preventing
  incorrect reusing of main frame's site instance for showing
  a subframe's view-source ( https://crbug.com/770946 )

This CL adds regression tests for  https://crbug.com/523  that ensure that
view-source for HTTP POST works fine in case of main frame and subframe.
Works fine = no new network requests are issued (verified by a response
nonce added to the /echoall default handler in the embedded http test
server).

Bug: 770487,  770946 ,  774691 ,  699493 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: Ic0afeed898b4f0900f3f8ad47a903f83f2c589d3
Reviewed-on: https://chromium-review.googlesource.com/695913
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512625}
[modify] https://crrev.com/e1b954d9a6cf66a123ddf719860aa4e5b5cd2888/chrome/browser/chrome_navigation_browsertest.cc
[modify] https://crrev.com/e1b954d9a6cf66a123ddf719860aa4e5b5cd2888/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc
[modify] https://crrev.com/e1b954d9a6cf66a123ddf719860aa4e5b5cd2888/chrome/browser/renderer_context_menu/render_view_context_menu.cc
[modify] https://crrev.com/e1b954d9a6cf66a123ddf719860aa4e5b5cd2888/chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc
[modify] https://crrev.com/e1b954d9a6cf66a123ddf719860aa4e5b5cd2888/chrome/browser/tab_contents/view_source_browsertest.cc
[modify] https://crrev.com/e1b954d9a6cf66a123ddf719860aa4e5b5cd2888/chrome/browser/ui/browser.cc
[modify] https://crrev.com/e1b954d9a6cf66a123ddf719860aa4e5b5cd2888/chrome/browser/ui/browser.h
[modify] https://crrev.com/e1b954d9a6cf66a123ddf719860aa4e5b5cd2888/chrome/browser/ui/browser_command_controller.cc
[modify] https://crrev.com/e1b954d9a6cf66a123ddf719860aa4e5b5cd2888/chrome/browser/ui/browser_commands.cc
[modify] https://crrev.com/e1b954d9a6cf66a123ddf719860aa4e5b5cd2888/chrome/browser/ui/browser_commands.h
[modify] https://crrev.com/e1b954d9a6cf66a123ddf719860aa4e5b5cd2888/chrome/browser/ui/views/page_info/page_info_bubble_view_browsertest.cc
[add] https://crrev.com/e1b954d9a6cf66a123ddf719860aa4e5b5cd2888/chrome/test/data/form_that_posts_to_echoall.html
[modify] https://crrev.com/e1b954d9a6cf66a123ddf719860aa4e5b5cd2888/content/browser/frame_host/render_frame_host_delegate.h
[modify] https://crrev.com/e1b954d9a6cf66a123ddf719860aa4e5b5cd2888/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/e1b954d9a6cf66a123ddf719860aa4e5b5cd2888/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/e1b954d9a6cf66a123ddf719860aa4e5b5cd2888/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/e1b954d9a6cf66a123ddf719860aa4e5b5cd2888/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/e1b954d9a6cf66a123ddf719860aa4e5b5cd2888/content/common/frame_messages.h
[modify] https://crrev.com/e1b954d9a6cf66a123ddf719860aa4e5b5cd2888/content/public/browser/render_frame_host.h
[modify] https://crrev.com/e1b954d9a6cf66a123ddf719860aa4e5b5cd2888/content/public/browser/web_contents.h
[modify] https://crrev.com/e1b954d9a6cf66a123ddf719860aa4e5b5cd2888/content/public/browser/web_contents_delegate.cc
[modify] https://crrev.com/e1b954d9a6cf66a123ddf719860aa4e5b5cd2888/content/public/browser/web_contents_delegate.h
[modify] https://crrev.com/e1b954d9a6cf66a123ddf719860aa4e5b5cd2888/content/public/common/context_menu_params.h
[modify] https://crrev.com/e1b954d9a6cf66a123ddf719860aa4e5b5cd2888/content/renderer/context_menu_params_builder.cc
[modify] https://crrev.com/e1b954d9a6cf66a123ddf719860aa4e5b5cd2888/net/test/embedded_test_server/default_handlers.cc
[modify] https://crrev.com/e1b954d9a6cf66a123ddf719860aa4e5b5cd2888/third_party/WebKit/Source/core/page/ContextMenuClient.cpp
[modify] https://crrev.com/e1b954d9a6cf66a123ddf719860aa4e5b5cd2888/third_party/WebKit/public/web/WebContextMenuData.h
►

Sign in to add a comment