pixel tests do not compile with use_ozone on linux |
|||
Issue descriptionI've noticed at least two issues 1. Lack of a message loop causes GLImageTestSupport::InitializeGL to fail. This can be fixed with the same approach used in other unittests https://cs.chromium.org/chromium/src/ui/gl/test/run_all_unittests.cc?rcl=fca18931b5ee2b1e272ba0e86ac98f4c10d12e05&l=81, however this conflicts with the message loop we set up for ui scene manager unittests. 2. Once the message loop issue is dealt with, the shaders don't compile (the compiler complains that gles 1.0 is not supported, only 1.1 and 1.2).
,
Oct 2 2017
My goal is that a linux developer need only have one set of gn args for working vr.
,
Oct 5 2017
,
Oct 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eb9da40608b0476883a90d87f1eb3e5a41001a9c commit eb9da40608b0476883a90d87f1eb3e5a41001a9c Author: Ian Vollick <vollick@chromium.org> Date: Thu Oct 05 16:09:51 2017 [vr] Permit vr_common_unittests to work with use_ozone If we set up a scoped task environment in run_all_unittests.cc, we both support ozone (which expects this) and obviate message loop creation by our tests. Bug: 770469 Change-Id: Ibdd803c0d209c721e2c27ed4e6a37210a96f1537 Reviewed-on: https://chromium-review.googlesource.com/702042 Reviewed-by: Christopher Grant <cjgrant@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#506745} [modify] https://crrev.com/eb9da40608b0476883a90d87f1eb3e5a41001a9c/chrome/browser/vr/service/vr_device_manager_unittest.cc [modify] https://crrev.com/eb9da40608b0476883a90d87f1eb3e5a41001a9c/chrome/browser/vr/test/run_all_unittests.cc [modify] https://crrev.com/eb9da40608b0476883a90d87f1eb3e5a41001a9c/chrome/browser/vr/test/ui_scene_manager_test.h [modify] https://crrev.com/eb9da40608b0476883a90d87f1eb3e5a41001a9c/chrome/browser/vr/ui_scene_manager_unittest.cc
,
Oct 5 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by cjgrant@chromium.org
, Oct 2 2017