New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 770455 link

Starred by 4 users

Issue metadata

Status: WontFix
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Bookmarks - Remove and Done button is wrong way round - poor user experience

Reported by ash.pear...@gmail.com, Sep 30 2017

Issue description

Chrome Version       : 61.0.3163.100
OS Version: 6.3
URLs (if applicable) : N/A
Other browsers tested:
  Add OK or FAIL after other browsers where you have tested this issue:
     Safari 5:
  Firefox 4.x:
     IE 7/8/9:

What steps will reproduce the problem?
1. Add a bookmark

What is the expected result?
The done button should be on the right, not in the middle

What happens instead of that?
The done button is in the middle, and UX normality means I click "remove"


Please provide any additional information below. Attach a screenshot if
possible.

UserAgentString: Mozilla/5.0 (Windows NT 6.3; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.100 Safari/537.36



 
wrong way round.JPG
19.7 KB View Download
Labels: Needs-Triage-M61
Cc: hdodda@chromium.org
Components: UI>Browser>Bookmarks
Labels: -Type-Bug -Pri-3 hasbisect-per-revision Needs-Milestone Pri-1 Type-Bug-Regression
Owner: tapted@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on windows 7 using chrome M63 #63.0.3230.0 and M61 #61.0.3163.100 .

This is a regression issue broken  in M61 and is reproduced only in windows.

Using the per-revision bisect providing the bisect results,
Good build: 61.0.3116.0(Revision: 475721).
Bad build: 61.0.3117.0 (Revision: 476123).

You are probably looking for a change made after 475832 (known good), but no later than 475833 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

 https://chromium.googlesource.com/chromium/src/+log/09bcca49766516c2b8a685420b7b075f39350500..f9f292034311121b7777645eb48522ddaa6a5272

From the CL above, assigning the issue to the concern owner 

@tapted- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Review-Url: https://codereview.chromium.org/2908963002

Thanks!
Status: WontFix (was: Assigned)
According to the Windows HIG at https://msdn.microsoft.com/en-us/library/windows/desktop/dn742499.aspx buttons Cancel/No buttons should always come after the "OK" button in a left-to-right reading order (see "Present the commit buttons in the following order". Chrome has done this for all dialogs except add bookmark for a long time. That CL just fixed the add bookmark bubble.

Note the Mac Human Interface Guidelines specify the opposite, so we swap it there.
Thank you for the update, but I don't agree with the decision. Whilst some other elements have the button on the left, there are many other menus and options that have it on the right of the pane, and this is causing an inconsistency and reducing the user experience.

I've attached two examples where the blue button is on the right. There are many others.
button on right 2.JPG
23.3 KB View Download
button on right.JPG
19.6 KB View Download
The single button example is fine. I've filed Issue 771817 to get the webui dialogs fixed -- those dialogs are clearly wrong on Windows - just compare to the OS Native "Save" dialog.

Comment 6 by tapted@chromium.org, Oct 10 2017

Cc: tapted@chromium.org
 Issue 772957  has been merged into this issue.
 Issue 797005  has been merged into this issue.

Sign in to add a comment