New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 770423 link

Starred by 1 user
Status: Fixed
Owner:
█ dschuyler@chromium.org
Last visit > 30 days ago
Closed: Oct 2017
Cc:
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Regression [MD settings] clear filter after removing cookies

Project Member Reported by dschuyler@chromium.org, Sep 30 2017 
In chrome://settings/siteData there is a search/filter at the top of the page.
1. filter by something that has some results
2. click Remove REMOVE ALL SHOWN 
3. confirm the dialog

Problem: the window is now blank because the filter is searching for something that no longer exists.

Solution: clear the filter. This is a regression since this used to work this way and was broken at some point.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/915998b018928ad4cb4472c8684188b08a27881a

commit 915998b018928ad4cb4472c8684188b08a27881a
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Wed Oct 04 19:52:57 2017

[MD settings] cookies, clear filter after removing items

This CL adds a listener to the settings subpage that will allow setting
the filter value. The filter may be cleared by setting the value to ''.

Bug:  770423 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If4ac8e4bb1f1b38224b52e970f549293ff9b5e9d
Reviewed-on: https://chromium-review.googlesource.com/693390
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506486}
[modify] https://crrev.com/915998b018928ad4cb4472c8684188b08a27881a/chrome/browser/resources/settings/settings_page/settings_subpage.js
[modify] https://crrev.com/915998b018928ad4cb4472c8684188b08a27881a/chrome/browser/resources/settings/site_settings/site_data.js
[modify] https://crrev.com/915998b018928ad4cb4472c8684188b08a27881a/chrome/test/data/webui/settings/settings_subpage_test.js

Comment 2 by dschuyler@chromium.org, Oct 4 2017

Status: Fixed (was: Started)
►

Sign in to add a comment