New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 770408 link

Starred by 2 users
Status: Available
Owner: ----
Cc:
█ phajdan.jr@chromium.org
tandrii@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue v8:8310
Blocking:
issue 715856



Sign in to add a comment

Remove rietveld support from depot_tools

Project Member Reported by aga...@chromium.org, Sep 29 2017 
Lots of rietveld code in depot_tools. Delete it all!
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/7659f4ff2dcbfda98b64d16bafc4bf47da1cd6ac

commit 7659f4ff2dcbfda98b64d16bafc4bf47da1cd6ac
Author: Aaron Gable <agable@chromium.org>
Date: Sat Sep 30 00:00:24 2017

Remove rietveld git cherry-pick-upload command

The command only supports rietveld; we use git drover for Gerrit.

R=tandrii@chromium.org

Bug: 770408
Change-Id: I63a32e6e355ab361a77fb1328c21934613602a27
Reviewed-on: https://chromium-review.googlesource.com/693339
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

[delete] https://crrev.com/3be96a83b875d29badb71a914b1342cb38935d99/git_cherry_pick_upload.py
[delete] https://crrev.com/3be96a83b875d29badb71a914b1342cb38935d99/git-cherry-pick-upload
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/e632e54438ad5d2b45ee9206c7fcf8babea0762c

commit e632e54438ad5d2b45ee9206c7fcf8babea0762c
Author: Aaron Gable <agable@chromium.org>
Date: Sat Sep 30 00:01:14 2017

Remove rietveld commit queue command line client

This code appears unused, and if it is used, it isn't useful anymore.

R=tandrii@chromium.org

Bug: 770408
Change-Id: I8b96a119be8ed20132e0b7439e466ad90f3757c2
Reviewed-on: https://chromium-review.googlesource.com/693337
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

[delete] https://crrev.com/7659f4ff2dcbfda98b64d16bafc4bf47da1cd6ac/commit_queue.bat
[delete] https://crrev.com/7659f4ff2dcbfda98b64d16bafc4bf47da1cd6ac/commit_queue.py
[modify] https://crrev.com/e632e54438ad5d2b45ee9206c7fcf8babea0762c/OWNERS
[delete] https://crrev.com/7659f4ff2dcbfda98b64d16bafc4bf47da1cd6ac/commit_queue
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/21afbdd098b1237ceee0b0e0c78d444f9fc3ac88

commit 21afbdd098b1237ceee0b0e0c78d444f9fc3ac88
Author: Aaron Gable <agable@chromium.org>
Date: Mon Oct 09 21:45:14 2017

Remove Rietveld support from run_presubmit recipe

R=iannucci@chromium.org

Bug: 770408
Change-Id: I4ce5017bbd23348d8138c58fe3405b927fa5a029
Reviewed-on: https://chromium-review.googlesource.com/707347
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

[modify] https://crrev.com/21afbdd098b1237ceee0b0e0c78d444f9fc3ac88/scripts/slave/recipes/run_presubmit.expected/presubmit-infra-failure.json
[modify] https://crrev.com/21afbdd098b1237ceee0b0e0c78d444f9fc3ac88/scripts/slave/recipes/run_presubmit.expected/chrome_golo.json
[modify] https://crrev.com/21afbdd098b1237ceee0b0e0c78d444f9fc3ac88/scripts/slave/recipes/run_presubmit.expected/gyp.json
[modify] https://crrev.com/21afbdd098b1237ceee0b0e0c78d444f9fc3ac88/scripts/slave/recipes/run_presubmit.expected/skia.json
[modify] https://crrev.com/21afbdd098b1237ceee0b0e0c78d444f9fc3ac88/scripts/slave/recipes/run_presubmit.expected/chromium_with_auth.json
[modify] https://crrev.com/21afbdd098b1237ceee0b0e0c78d444f9fc3ac88/scripts/slave/recipes/run_presubmit.expected/v8_with_cache.json
[modify] https://crrev.com/21afbdd098b1237ceee0b0e0c78d444f9fc3ac88/scripts/slave/recipes/run_presubmit.expected/webports.json
[modify] https://crrev.com/21afbdd098b1237ceee0b0e0c78d444f9fc3ac88/scripts/slave/recipes/run_presubmit.expected/catapult.json
[modify] https://crrev.com/21afbdd098b1237ceee0b0e0c78d444f9fc3ac88/scripts/slave/recipes/run_presubmit.expected/build.json
[modify] https://crrev.com/21afbdd098b1237ceee0b0e0c78d444f9fc3ac88/scripts/slave/recipes/run_presubmit.expected/internal_deps.json
[delete] https://crrev.com/a317d4b08b2da6f8c1fc147a6efd70b042417541/scripts/slave/recipes/run_presubmit.expected/depot_tools_and_gerrit.json
[modify] https://crrev.com/21afbdd098b1237ceee0b0e0c78d444f9fc3ac88/scripts/slave/recipes/run_presubmit.expected/presubmit-failure.json
[modify] https://crrev.com/21afbdd098b1237ceee0b0e0c78d444f9fc3ac88/scripts/slave/recipes/run_presubmit.expected/luci-py.json
[modify] https://crrev.com/21afbdd098b1237ceee0b0e0c78d444f9fc3ac88/scripts/slave/recipes/run_presubmit.expected/infra_with_runhooks.json
[modify] https://crrev.com/21afbdd098b1237ceee0b0e0c78d444f9fc3ac88/scripts/slave/recipes/run_presubmit.expected/recipes-py.json
[modify] https://crrev.com/21afbdd098b1237ceee0b0e0c78d444f9fc3ac88/scripts/slave/recipes/run_presubmit.expected/v8.json
[modify] https://crrev.com/21afbdd098b1237ceee0b0e0c78d444f9fc3ac88/scripts/slave/recipes/run_presubmit.expected/build_internal_scripts_slave.json
[modify] https://crrev.com/21afbdd098b1237ceee0b0e0c78d444f9fc3ac88/scripts/slave/recipes/run_presubmit.expected/depot_tools.json
[modify] https://crrev.com/21afbdd098b1237ceee0b0e0c78d444f9fc3ac88/scripts/slave/recipes/run_presubmit.expected/chromium.json
[modify] https://crrev.com/21afbdd098b1237ceee0b0e0c78d444f9fc3ac88/scripts/slave/recipes/run_presubmit.expected/webrtc.json
[modify] https://crrev.com/21afbdd098b1237ceee0b0e0c78d444f9fc3ac88/scripts/slave/recipes/run_presubmit.expected/chromium_dry_run.json
[modify] https://crrev.com/21afbdd098b1237ceee0b0e0c78d444f9fc3ac88/scripts/slave/recipes/run_presubmit.expected/repository_url.json
[delete] https://crrev.com/a317d4b08b2da6f8c1fc147a6efd70b042417541/scripts/slave/recipes/run_presubmit.expected/infra_with_runhooks_and_gerrit.json
[modify] https://crrev.com/21afbdd098b1237ceee0b0e0c78d444f9fc3ac88/scripts/slave/recipes/run_presubmit.expected/master_deps.json
[modify] https://crrev.com/21afbdd098b1237ceee0b0e0c78d444f9fc3ac88/scripts/slave/recipes/run_presubmit.py
[modify] https://crrev.com/21afbdd098b1237ceee0b0e0c78d444f9fc3ac88/scripts/slave/README.recipes.md
[modify] https://crrev.com/21afbdd098b1237ceee0b0e0c78d444f9fc3ac88/scripts/slave/recipes/run_presubmit.expected/build_internal.json
[modify] https://crrev.com/21afbdd098b1237ceee0b0e0c78d444f9fc3ac88/scripts/slave/recipes/run_presubmit.expected/slave_deps.json
[modify] https://crrev.com/21afbdd098b1237ceee0b0e0c78d444f9fc3ac88/scripts/slave/recipes/run_presubmit.expected/nacl.json
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/40ab3130b4245c1c6c7db445906c412f1c1147c6

commit 40ab3130b4245c1c6c7db445906c412f1c1147c6
Author: Aaron Gable <agable@chromium.org>
Date: Tue Oct 10 16:50:33 2017

Remove unused rietveld recipe module dependency

R=phajdan.jr@chromium.org

Bug: 770408
Change-Id: I2e7e21bc44f691753e1223656471d1df5c859539
Reviewed-on: https://chromium-review.googlesource.com/707614
Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

[modify] https://crrev.com/40ab3130b4245c1c6c7db445906c412f1c1147c6/scripts/slave/recipe_modules/filter/__init__.py
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 11 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/release/scripts/+/a132999f05fd7d9810a49ae18a2ea48e5d71c955

commit a132999f05fd7d9810a49ae18a2ea48e5d71c955
Author: Aaron Gable <agable@chromium.org>
Date: Wed Oct 11 00:50:48 2017
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/9bce91a2b4145c40e37cf6e1fb4abab13cbe615c

commit 9bce91a2b4145c40e37cf6e1fb4abab13cbe615c
Author: Aaron Gable <agable@chromium.org>
Date: Wed Oct 11 00:51:15 2017

Update recipe roller tests to assume Gerrit

The recipes in production are already behaving this way,
just updating the tests and expectations to match.

R=tandrii

Bug: 770408
Change-Id: I2b3f66abaef86a6c91afddd0c0e14097e6d6dc6b
Reviewed-on: https://chromium-review.googlesource.com/711025
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

[modify] https://crrev.com/9bce91a2b4145c40e37cf6e1fb4abab13cbe615c/recipes/recipes/recipe_roll_tryjob.expected/diff_train_fail.json
[modify] https://crrev.com/9bce91a2b4145c40e37cf6e1fb4abab13cbe615c/recipes/recipes/recipe_roll_tryjob.expected/diff_train_fail_ack_engine_checkout.json
[modify] https://crrev.com/9bce91a2b4145c40e37cf6e1fb4abab13cbe615c/recipes/recipes/recipe_roll_tryjob.expected/bypass.json
[modify] https://crrev.com/9bce91a2b4145c40e37cf6e1fb4abab13cbe615c/recipes/recipes/recipe_roll_tryjob.expected/diff_test_fail.json
[modify] https://crrev.com/9bce91a2b4145c40e37cf6e1fb4abab13cbe615c/recipes/recipes/recipe_roll_tryjob.expected/diff_test_fail_ack.json
[modify] https://crrev.com/9bce91a2b4145c40e37cf6e1fb4abab13cbe615c/recipes/recipes/recipe_roll_tryjob.py
[modify] https://crrev.com/9bce91a2b4145c40e37cf6e1fb4abab13cbe615c/recipes/recipes/recipe_roll_tryjob.expected/diff_train_fail_ack.json
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 11 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/9db0ff91c8477159d6d79764cc00e90d65d7e774

commit 9db0ff91c8477159d6d79764cc00e90d65d7e774
Author: Aaron Gable <agable@chromium.org>
Date: Wed Oct 11 16:57:16 2017
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 11 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/a197a890ac6468ebf22e119aa34434c38e87d127

commit a197a890ac6468ebf22e119aa34434c38e87d127
Author: Aaron Gable <agable@chromium.org>
Date: Wed Oct 11 17:35:26 2017
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 11 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/301dfe8451f37bfeade8408d82a68a501c2c9c18

commit 301dfe8451f37bfeade8408d82a68a501c2c9c18
Author: Aaron Gable <agable@chromium.org>
Date: Wed Oct 11 17:36:56 2017
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 11 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/d4bcc0374af43f2c04f17ac4e993ba51e92a9a02

commit d4bcc0374af43f2c04f17ac4e993ba51e92a9a02
Author: Aaron Gable <agable@chromium.org>
Date: Wed Oct 11 17:41:26 2017

Comment 11 by aga...@chromium.org, Nov 3 2017

Cc: phajdan.jr@chromium.org
 Issue 765208  has been merged into this issue.
Project Member

Comment 12 by bugdroid1@chromium.org, Dec 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/aac382b3b65d5a2805c6467e1d9b359625569f91

commit aac382b3b65d5a2805c6467e1d9b359625569f91
Author: Aaron Gable <agable@chromium.org>
Date: Tue Dec 19 19:36:06 2017

Remove rietveld-based tests from tryserver recipe module

This introduces a pragma: no cover, which is unfortunate.
But this is a prerequisite for removing rietveld support
entirely from the recipe engine without having to do
manual recipe rolls. The entire block of uncovered code
will be removed shortly.

Bug: 770408
Change-Id: I37319f3ae70413adcda655c443325bccffe695d8
Reviewed-on: https://chromium-review.googlesource.com/834455
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

[delete] https://crrev.com/9fce213bdbb8512c571c6e14b0302dbb5ecd653e/recipes/recipe_modules/tryserver/examples/full.expected/with_rietveld_patch_new.json
[modify] https://crrev.com/aac382b3b65d5a2805c6467e1d9b359625569f91/recipes/recipe_modules/tryserver/api.py
[modify] https://crrev.com/aac382b3b65d5a2805c6467e1d9b359625569f91/recipes/README.recipes.md
[delete] https://crrev.com/9fce213bdbb8512c571c6e14b0302dbb5ecd653e/recipes/recipe_modules/tryserver/examples/full.expected/with_rietveld_patch.json
[modify] https://crrev.com/aac382b3b65d5a2805c6467e1d9b359625569f91/recipes/recipe_modules/tryserver/examples/full.py
Project Member

Comment 13 by bugdroid1@chromium.org, Dec 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/cf023dbe133539a51bb877e12dd735c33eaaf946

commit cf023dbe133539a51bb877e12dd735c33eaaf946
Author: Aaron Gable <agable@chromium.org>
Date: Tue Dec 19 20:23:24 2017

Specify Gerrit as patch storage for bisection recipe tests

This is necessary to make Rietveld->Gerrit changes lower in
the recipe stack (e.g. depot_tools and recipe_engine) rollable
with only non-trivial rolls rather than manual rolls.

Bug: 770408
Change-Id: I98807c3bcb726e8ba9f346fcb87d3e0dedcfc91f
Reviewed-on: https://chromium-review.googlesource.com/834828
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_failed_test_android_nexus6_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_revisions_staging_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_failed_test_android_nexus7_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_revisions_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus5_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_fyi_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_one_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus6_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_webview_nexus6_aosp_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_metric_android_one_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_revisions_android_nexus6_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_android_webview_nexus6_aosp_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_one_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_one_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/desktop_bisect_staging.expected/deps_perf_tryjob.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/desktop_bisect_staging.expected/basic_perf_tryjob_with_metric_valueset.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_webview_nexus6_aosp_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_webview_nexus6_aosp_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_android_nexus5_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_webview_arm64_aosp_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/desktop_bisect.expected/deps_perf_tryjob.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_metric_android_nexus7_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_android_webview_arm64_aosp_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_revisions_android_webview_arm64_aosp_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/desktop_bisect.py
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_fyi_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/desktop_bisect_staging.expected/basic_perf_tryjob.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_android_one_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_failed_test_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_staging_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipe_modules/perf_try/build_state.py
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_android_nexus7_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_metric_android_webview_arm64_aosp_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_android_fyi_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus7_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob_with_metric_valueset.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_failed_test_android_fyi_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/desktop_bisect.expected/perf_tryjob_failed_test.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus7_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus7_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus6_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_webview_arm64_aosp_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_revisions_android_fyi_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_failed_test_android_nexus5_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus5_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_revisions_android_one_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect.py
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/desktop_bisect_staging.expected/perf_tryjob_no_config.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_metric_android_fyi_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/desktop_bisect_staging.expected/perf_tryjob_failed_test.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_metric_staging_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/desktop_bisect_staging.expected/basic_perf_tryjob_with_revisions.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_failed_test_android_webview_nexus6_aosp_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_webview_arm64_aosp_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_failed_test_android_one_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus5_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob_with_revisions.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/desktop_bisect_staging.expected/basic_perf_tryjob_with_bucket.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_staging_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/desktop_bisect_staging.py
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_android_nexus6_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_metric_android_nexus5_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus7_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipe_modules/perf_try_staging/build_state.py
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_staging_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_staging_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_webview_arm64_aosp_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob_with_bucket.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_revisions_android_nexus7_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_metric_android_webview_nexus6_aosp_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_fyi_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_revisions_android_nexus5_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_failed_test_staging_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_metric_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus6_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect_staging.py
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_webview_nexus6_aosp_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob_with_metric.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_revisions_android_webview_nexus6_aosp_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_one_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_staging_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus6_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus5_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_fyi_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/desktop_bisect.expected/perf_tryjob_no_config.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_metric_android_nexus6_perf_bisect.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/desktop_bisect_staging.expected/basic_perf_tryjob_with_metric.json
[modify] https://crrev.com/cf023dbe133539a51bb877e12dd735c33eaaf946/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_failed_test_android_webview_arm64_aosp_perf_bisect.json
Project Member

Comment 14 by bugdroid1@chromium.org, Dec 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/32ae40f983e0e63ca8ede53f0afc5751562d8c20

commit 32ae40f983e0e63ca8ede53f0afc5751562d8c20
Author: Aaron Gable <agable@chromium.org>
Date: Wed Dec 20 18:32:31 2017

Use Gerrit patch storage for all v8 recipe tests

This is necesary to make Rietveld->Gerrit changes lower in
the recipe stack (e.g. depot_tools and recipe_engine) rollable
with only non-trivial rolls rather than manual rolls.

Bug: 770408
Change-Id: I0c9617bca7b0f5621d19debaca612d2ba3dd4589
Reviewed-on: https://chromium-review.googlesource.com/834794
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_gyp_rel_ng.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_noi18n_rel_ng.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_fyi_rel_ng.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_rel_ng_triggered_positional_extra_flags.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_nodcheck_rel_ng_triggered.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_rel_ng_triggered_triggered_by_cq.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win64_dbg.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win_asan_rel_ng_triggered.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_asan_rel_ng_triggered.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_ubsan_rel_ng_triggered.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_client_dart_fyi_v8_linux_release.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___builder.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_asan_rel_ng.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac_gc_stress_dbg.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_noi18n_rel_ng_triggered.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_client_dart_fyi_v8_mac_release.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win_asan_rel_ng.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win_rel_ng.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_tsan_rel.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win_nosnap_shared_rel_ng.json
[delete] https://crrev.com/6d9b47a7fcd6d5f7463c83a8f1ac717859091a74/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_rel_ng_gerrit.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Android_Arm64___builder.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Android_Arm___builder.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipe_modules/v8/api.py
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac64_dbg.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___mips64el___sim___builder.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_gcc_compile_dbg.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___debug_builder.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_dbg_ng_triggered.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_rel_ng_triggered.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win_dbg.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm_rel_ng_triggered.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_rel_ng_with_build_id.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win64_rel_ng.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_gc_stress_dbg.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_sanitizer_coverage_rel.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_nosnap_dbg.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___nosnap_debug_builder.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32___builder.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___builder.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_verify_csa_rel_ng_triggered.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_rel_ng.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_verify_csa_rel_ng.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___custom_snapshot___debug_builder.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_rel_ng.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_mipsel_compile_rel.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_android_arm_compile_rel.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Mips___builder.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_rel_ng_triggered_slow_tests.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_rel_ng_triggered_triggered_by_ts.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win_rel_ng_triggered.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm_rel_ng.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_client_dart_fyi_v8_win_release.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win_compile_dbg.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_rel_ng_triggered_flakes.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_nodcheck_rel_ng.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win64_rel_ng_triggered.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_nosnap_rel.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32___debug_builder.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Arm___debug_builder.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm64_rel_ng_triggered.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win64_rel_ng_test_triggered_build_luci.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac_dbg.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac_rel_ng_triggered.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_gcc_compile_rel.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Arm___builder.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___debug_builder.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_gcc_rel.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_ubsan_rel_ng.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win64_rel_ng_test_filter_builder.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_gyp_rel_ng_triggered.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_mips64el_compile_rel.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_fuchsia_rel_ng.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm64_dbg.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_rel_ng_triggered_test_filter.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac64_rel.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_dbg_ng.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_verify_csa_rel_ng_triggered.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___nosnap_builder.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac_rel_ng.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_shared_compile_rel.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win64_msvc_compile_rel.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_rel_ng_triggered_failures.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___concurrent_marking___builder.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_verify_csa_rel_ng.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___mipsel___sim___builder.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipe_modules/v8/test_api.py
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac64_asan_rel.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_msan_rel.json
[delete] https://crrev.com/6d9b47a7fcd6d5f7463c83a8f1ac717859091a74/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_sanitizer_coverage_rel_gerrit.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm64_rel_ng.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm_dbg.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm64_gc_stress_dbg.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win_nosnap_shared_rel_ng_triggered.json
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.py
[modify] https://crrev.com/32ae40f983e0e63ca8ede53f0afc5751562d8c20/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_rel_ng_triggered.json
Project Member

Comment 15 by bugdroid1@chromium.org, Dec 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/recipes-py/+/77667b5ba38c4d205a743d04eb625ac068bdd78e

commit 77667b5ba38c4d205a743d04eb625ac068bdd78e
Author: Aaron Gable <agable@chromium.org>
Date: Wed Dec 20 19:47:47 2017

Always use Gerrit for tryserver recipe tests

This makes all the tests which use "api.properties.tryserver"
reflect reality. This in turn makes it easier to remove Rietveld-only
code from other recipe modules, since the tests will already be
updated to assume Gerrit is the patch source.

Bug: 770408
Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: depot_tools
Recipe-Nontrivial-Roll: infra
Change-Id: Iaa66163e4832e393b01ae9fd2725dfaa993fff92
Reviewed-on: https://chromium-review.googlesource.com/833490
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

[modify] https://crrev.com/77667b5ba38c4d205a743d04eb625ac068bdd78e/recipe_modules/properties/test_api.py
[modify] https://crrev.com/77667b5ba38c4d205a743d04eb625ac068bdd78e/recipe_modules/properties/examples/full.expected/buildbot_tryserver.json
Project Member

Comment 16 by bugdroid1@chromium.org, Dec 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4

commit b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4
Author: Aaron Gable <agable@chromium.org>
Date: Wed Dec 20 23:10:02 2017

Update libyuv and webrtc recipe tests for Gerrit

This is necessary to allow lower-level changes (e.g. to
depot_tools) to roll forward without manual intervention.

TBR=ehmaldonado@chromium.org

Bug: 770408
Change-Id: I5867189d413113386b6c86dbcb99f71a49465898
Reviewed-on: https://chromium-review.googlesource.com/837902
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_mac_rel.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_asan.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_win10.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_ios.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_compile_arm64_dbg.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/ios.py
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux_forced.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_tsan2.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux_tsan2.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_x64_rel.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux32_rel.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_experimental.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_asan.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_arm64_dbg.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_compile_arm64_rel.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_android_rel.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_baremetal.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_ubsan_vptr.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_dbg.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_clang_rel.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_mac.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_ios_arm64.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_experimental.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_arm64_rel.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_dbg.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_memcheck.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_msvc_rel.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_compile_rel.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_dbg.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.py
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_compile_rel.json
[delete] https://crrev.com/3c06b08b7e2f235b620c8aec531720743ff5cbed/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_dbg_gerrit.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux32_arm_rel.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_compile_x86_rel.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_ubsan.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_compile_dbg.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_win_rel.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_android.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_dbg.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux_asan.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_rel.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_x64_dbg.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_android_x64.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux_msan.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_compile_mips_dbg.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_compile_dbg.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_win_clang.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux32_arm_dbg.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_asan.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_rel.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_experimental.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_gcc_rel.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_msan.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_win_x64_clang_rel.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_android_arm64.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_dbg.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_dbg.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_ios_arm64_rel.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/libyuv/libyuv.py
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/ios.expected/trybot.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_compile_dbg.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux_ubsan.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_compile_rel.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_rel.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_rel.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_ios_rel.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux32_dbg.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_win.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux_ubsan_vptr.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux_rel.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_win_clang_rel.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_win_x64_rel.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_compile_x64_dbg.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_clang_dbg.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_compile_x86_dbg.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_android_mips.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_rel.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_win8.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_rel.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_baremetal.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux_gcc.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_arm64_rel.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_mac_asan.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux_memcheck.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_android_x86.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_clang_dbg.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_clang_rel.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_experimental.json
[modify] https://crrev.com/b88d4ca2b7421396c81c43cbdb3bf67ed85ba4a4/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_baremetal.json

Comment 18 by aga...@chromium.org, Jan 3 2018

Blocking: 715856

Comment 19 by aga...@chromium.org, Jan 3 2018

Components: -Infra>Codereview>Rietveld Infra>Codereview Infra>SDK
Removing Rietveld component since this is the last issue in it, so now the component can be deleted.
Project Member

Comment 20 by bugdroid1@chromium.org, Apr 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/f3eed0016e3400b43ef4d1f6d42e252250077910

commit f3eed0016e3400b43ef4d1f6d42e252250077910
Author: Aaron Gable <agable@chromium.org>
Date: Mon Apr 02 20:09:14 2018

Remove Rietveld support from presubmit

Since no one can upload or land changes from Rietveld anymore,
PRESUBMIT and its support files no longer need to be able to
support it.

R=tandrii@chromium.org

Bug: 770408
Change-Id: I749092b66fdca16d5cef77e8cefc905aa5375b50
Reviewed-on: https://chromium-review.googlesource.com/693380
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/f3eed0016e3400b43ef4d1f6d42e252250077910/presubmit_canned_checks.py
[modify] https://crrev.com/f3eed0016e3400b43ef4d1f6d42e252250077910/presubmit_support.py
[modify] https://crrev.com/f3eed0016e3400b43ef4d1f6d42e252250077910/git_cl.py
[modify] https://crrev.com/f3eed0016e3400b43ef4d1f6d42e252250077910/tests/presubmit_unittest.py
Project Member

Comment 21 by bugdroid1@chromium.org, Apr 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/aa6ddc6017794d9c25ad782e6c8a7c953e4023b4

commit aa6ddc6017794d9c25ad782e6c8a7c953e4023b4
Author: Aaron Gable <agable@chromium.org>
Date: Mon Apr 02 21:54:55 2018

Revert "Remove Rietveld support from presubmit"

This reverts commit f3eed0016e3400b43ef4d1f6d42e252250077910.

Reason for revert: Some PRESUBMIT checks still expect 
CheckRietveldTryJobExecution to exist.

Original change's description:
> Remove Rietveld support from presubmit
> 
> Since no one can upload or land changes from Rietveld anymore,
> PRESUBMIT and its support files no longer need to be able to
> support it.
> 
> R=​tandrii@chromium.org
> 
> Bug: 770408
> Change-Id: I749092b66fdca16d5cef77e8cefc905aa5375b50
> Reviewed-on: https://chromium-review.googlesource.com/693380
> Commit-Queue: Aaron Gable <agable@chromium.org>
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

TBR=agable@chromium.org,tandrii@chromium.org

Change-Id: I72e29bd8a9739406f29190adbeb7eb7718ed21cd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 770408
Reviewed-on: https://chromium-review.googlesource.com/991012
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>

[modify] https://crrev.com/aa6ddc6017794d9c25ad782e6c8a7c953e4023b4/presubmit_canned_checks.py
[modify] https://crrev.com/aa6ddc6017794d9c25ad782e6c8a7c953e4023b4/presubmit_support.py
[modify] https://crrev.com/aa6ddc6017794d9c25ad782e6c8a7c953e4023b4/git_cl.py
[modify] https://crrev.com/aa6ddc6017794d9c25ad782e6c8a7c953e4023b4/tests/presubmit_unittest.py
Project Member

Comment 22 by bugdroid1@chromium.org, Apr 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/ecee74ca4e7487f38dbabe0388ec54ddfd512b68

commit ecee74ca4e7487f38dbabe0388ec54ddfd512b68
Author: Aaron Gable <agable@chromium.org>
Date: Mon Apr 02 22:45:06 2018

presubmit: don't die when skipping unknown checks

If someone doesn't want to run a check, and that check doesn't
exist... great! We won't be running that check anyway.

R=iannucci

Bug: 770408, 828154
Change-Id: I74478cac9988e21a1fadfb2c9d23dac1697aaa46
Reviewed-on: https://chromium-review.googlesource.com/991093
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Sean McCullough <seanmccullough@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

[modify] https://crrev.com/ecee74ca4e7487f38dbabe0388ec54ddfd512b68/presubmit_support.py
[modify] https://crrev.com/ecee74ca4e7487f38dbabe0388ec54ddfd512b68/tests/presubmit_unittest.py
Project Member

Comment 23 by bugdroid1@chromium.org, Apr 3 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98af1b5696ccac71d4b141d1a0d25dc9f73091f7

commit 98af1b5696ccac71d4b141d1a0d25dc9f73091f7
Author: depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue Apr 03 00:23:19 2018

Roll src/third_party/depot_tools/ 31e7d56c2..81b26429c (6 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/31e7d56c28f1..81b26429c8f6

$ git log 31e7d56c2..81b26429c --date=short --no-merges --format='%ad %ae %s'
2018-04-02 bpastene depot_tools: Kick the recipe roller.
2018-04-02 agable Revert "Remove Rietveld support from presubmit"
2018-04-02 ehmaldonado bot_update: Don't patch if gerrit_repo or gerrit_ref are empty/None.
2018-04-02 agable Disallow TBRs to OWNERS files
2018-04-02 agable git-cl-try: document auth_config for buildbucket
2018-04-02 agable Remove Rietveld support from presubmit

Created with:
  roll-dep src/third_party/depot_tools
BUG=chromium:828154,chromium:770408, chromium:643346 ,chromium:688115,chromium:770408


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I830e86112dda7d11bdca0537ab8879e1a8d745b2
Reviewed-on: https://chromium-review.googlesource.com/991085
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#547578}
[modify] https://crrev.com/98af1b5696ccac71d4b141d1a0d25dc9f73091f7/DEPS
Project Member

Comment 24 by bugdroid1@chromium.org, Apr 3 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4124e572393b02841fa871c52e23008c694c45ac

commit 4124e572393b02841fa871c52e23008c694c45ac
Author: depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue Apr 03 02:02:42 2018

Roll src/third_party/depot_tools/ 81b26429c..c7d0b3408 (3 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/81b26429c8f6..c7d0b34084e5

$ git log 81b26429c..c7d0b3408 --date=short --no-merges --format='%ad %ae %s'
2018-03-28 ehmaldonado presubmit support: Run all tests in parallel.
2018-04-02 agable Kick recipe roller
2018-04-02 agable presubmit: don't die when skipping unknown checks

Created with:
  roll-dep src/third_party/depot_tools
BUG=chromium:819774,chromium:828154,chromium:770408,chromium:828154


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I25169163511e6438ed68514290681cc3213ab7d1
Reviewed-on: https://chromium-review.googlesource.com/991352
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#547600}
[modify] https://crrev.com/4124e572393b02841fa871c52e23008c694c45ac/DEPS
Project Member

Comment 25 by bugdroid1@chromium.org, Apr 3 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/668c1d8d1f1a6c26b088b5bff1203e35c74943a0

commit 668c1d8d1f1a6c26b088b5bff1203e35c74943a0
Author: Aaron Gable <agable@chromium.org>
Date: Tue Apr 03 18:00:08 2018

Reland "Remove Rietveld support from presubmit"

Since no one can upload or land changes from Rietveld anymore,
PRESUBMIT and its support files no longer need to be able to
support it.

Bug: 770408
Change-Id: I4ca6391291e7b0755c78af453c3d006ad3666a17
Reviewed-on: https://chromium-review.googlesource.com/991053
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

[modify] https://crrev.com/668c1d8d1f1a6c26b088b5bff1203e35c74943a0/presubmit_canned_checks.py
[modify] https://crrev.com/668c1d8d1f1a6c26b088b5bff1203e35c74943a0/presubmit_support.py
[modify] https://crrev.com/668c1d8d1f1a6c26b088b5bff1203e35c74943a0/git_cl.py
[modify] https://crrev.com/668c1d8d1f1a6c26b088b5bff1203e35c74943a0/tests/presubmit_unittest.py
Project Member

Comment 26 by bugdroid1@chromium.org, Apr 3 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/12e642b4df14be3728f975ba3dacaf5abd17b8db

commit 12e642b4df14be3728f975ba3dacaf5abd17b8db
Author: Aaron Gable <agable@chromium.org>
Date: Tue Apr 03 19:41:59 2018

run_presubmit: don't skip a check which doesn't exist anymore

This depends on
https://chromium-review.googlesource.com/#/c/chromium/tools/depot_tools/+/991053

Bug: 770408, 828154
Change-Id: I7b51f16fed1ebc014c9164819ce3f3444b68b5ce
Reviewed-on: https://chromium-review.googlesource.com/991054
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: Sean McCullough <seanmccullough@chromium.org>

[modify] https://crrev.com/12e642b4df14be3728f975ba3dacaf5abd17b8db/scripts/slave/recipes/run_presubmit.expected/presubmit-infra-failure.json
[modify] https://crrev.com/12e642b4df14be3728f975ba3dacaf5abd17b8db/scripts/slave/recipes/run_presubmit.expected/chrome_golo.json
[modify] https://crrev.com/12e642b4df14be3728f975ba3dacaf5abd17b8db/scripts/slave/recipes/run_presubmit.expected/gyp.json
[modify] https://crrev.com/12e642b4df14be3728f975ba3dacaf5abd17b8db/scripts/slave/recipes/run_presubmit.expected/skia.json
[modify] https://crrev.com/12e642b4df14be3728f975ba3dacaf5abd17b8db/scripts/slave/recipes/run_presubmit.expected/v8_with_cache.json
[modify] https://crrev.com/12e642b4df14be3728f975ba3dacaf5abd17b8db/scripts/slave/recipes/run_presubmit.expected/webports.json
[modify] https://crrev.com/12e642b4df14be3728f975ba3dacaf5abd17b8db/scripts/slave/recipes/run_presubmit.expected/pdfium.json
[modify] https://crrev.com/12e642b4df14be3728f975ba3dacaf5abd17b8db/scripts/slave/recipes/run_presubmit.expected/catapult.json
[modify] https://crrev.com/12e642b4df14be3728f975ba3dacaf5abd17b8db/scripts/slave/recipes/run_presubmit.expected/build.json
[modify] https://crrev.com/12e642b4df14be3728f975ba3dacaf5abd17b8db/scripts/slave/recipes/run_presubmit.expected/internal_deps.json
[modify] https://crrev.com/12e642b4df14be3728f975ba3dacaf5abd17b8db/scripts/slave/recipes/run_presubmit.expected/presubmit-failure.json
[modify] https://crrev.com/12e642b4df14be3728f975ba3dacaf5abd17b8db/scripts/slave/recipes/run_presubmit.expected/chromium_timeout.json
[modify] https://crrev.com/12e642b4df14be3728f975ba3dacaf5abd17b8db/scripts/slave/recipes/run_presubmit.expected/infra_with_runhooks.json
[modify] https://crrev.com/12e642b4df14be3728f975ba3dacaf5abd17b8db/scripts/slave/recipes/run_presubmit.expected/recipes-py.json
[modify] https://crrev.com/12e642b4df14be3728f975ba3dacaf5abd17b8db/scripts/slave/recipes/run_presubmit.expected/v8.json
[modify] https://crrev.com/12e642b4df14be3728f975ba3dacaf5abd17b8db/scripts/slave/recipes/run_presubmit.expected/luci-py.json
[modify] https://crrev.com/12e642b4df14be3728f975ba3dacaf5abd17b8db/scripts/slave/recipes/run_presubmit.expected/build_internal_scripts_slave.json
[modify] https://crrev.com/12e642b4df14be3728f975ba3dacaf5abd17b8db/scripts/slave/recipes/run_presubmit.expected/depot_tools.json
[modify] https://crrev.com/12e642b4df14be3728f975ba3dacaf5abd17b8db/scripts/slave/recipes/run_presubmit.expected/chromium.json
[modify] https://crrev.com/12e642b4df14be3728f975ba3dacaf5abd17b8db/scripts/slave/recipes/run_presubmit.expected/webrtc.json
[modify] https://crrev.com/12e642b4df14be3728f975ba3dacaf5abd17b8db/scripts/slave/recipes/run_presubmit.expected/chromium_dry_run.json
[modify] https://crrev.com/12e642b4df14be3728f975ba3dacaf5abd17b8db/scripts/slave/recipes/run_presubmit.expected/repository_url.json
[modify] https://crrev.com/12e642b4df14be3728f975ba3dacaf5abd17b8db/scripts/slave/recipes/run_presubmit.expected/master_deps.json
[modify] https://crrev.com/12e642b4df14be3728f975ba3dacaf5abd17b8db/scripts/slave/recipes/run_presubmit.py
[modify] https://crrev.com/12e642b4df14be3728f975ba3dacaf5abd17b8db/scripts/slave/README.recipes.md
[modify] https://crrev.com/12e642b4df14be3728f975ba3dacaf5abd17b8db/scripts/slave/recipes/run_presubmit.expected/build_internal.json
[modify] https://crrev.com/12e642b4df14be3728f975ba3dacaf5abd17b8db/scripts/slave/recipes/run_presubmit.expected/slave_deps.json
[modify] https://crrev.com/12e642b4df14be3728f975ba3dacaf5abd17b8db/scripts/slave/recipes/run_presubmit.expected/nacl.json
Project Member

Comment 28 by bugdroid1@chromium.org, Apr 3 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27cedda28dafb2bf30b845df324bc4ea671bf56e

commit 27cedda28dafb2bf30b845df324bc4ea671bf56e
Author: depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue Apr 03 21:08:55 2018

Roll src/third_party/depot_tools/ c7d0b3408..668c1d8d1 (1 commit)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c7d0b34084e5..668c1d8d1f1a

$ git log c7d0b3408..668c1d8d1 --date=short --no-merges --format='%ad %ae %s'
2018-04-03 agable Reland "Remove Rietveld support from presubmit"

Created with:
  roll-dep src/third_party/depot_tools
BUG=chromium:770408


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I53ce76b816ba6f936c0e1bbf43218203325f1cca
Reviewed-on: https://chromium-review.googlesource.com/992856
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#547827}
[modify] https://crrev.com/27cedda28dafb2bf30b845df324bc4ea671bf56e/DEPS
Project Member

Comment 30 by bugdroid1@chromium.org, May 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/4b23a2c6d7e2036160f17307ea8d95693a4e4168

commit 4b23a2c6d7e2036160f17307ea8d95693a4e4168
Author: Aaron Gable <agable@chromium.org>
Date: Thu May 24 18:00:10 2018

Remove more Rietveld support from presubmit

This simplifies future removals of unnecessary code from git-cl.

Bug: 770408
Change-Id: I20329fb6d93b349bf2e9f4aebc795b3f7ef0b646
Reviewed-on: https://chromium-review.googlesource.com/1070588
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>

[modify] https://crrev.com/4b23a2c6d7e2036160f17307ea8d95693a4e4168/presubmit_support.py
[modify] https://crrev.com/4b23a2c6d7e2036160f17307ea8d95693a4e4168/tests/presubmit_unittest.py
Project Member

Comment 31 by bugdroid1@chromium.org, May 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/5a90f51fc1e2484111b1209a4c806dcc86e59fce

commit 5a90f51fc1e2484111b1209a4c806dcc86e59fce
Author: Aaron Gable <agable@chromium.org>
Date: Thu May 24 18:03:08 2018

Remove apply_issue from buildbot commands

apply_issue only works for Rietveld, which doesn't have any active
issues anymore.

Bug: 770408
Change-Id: Ia0bf6a8ba1e724b73d395f538d04c85874e6db93
Reviewed-on: https://chromium-review.googlesource.com/1070869
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/5a90f51fc1e2484111b1209a4c806dcc86e59fce/scripts/master/factory/commands.py
[modify] https://crrev.com/5a90f51fc1e2484111b1209a4c806dcc86e59fce/scripts/master/factory/gclient_factory.py
Project Member

Comment 32 by bugdroid1@chromium.org, May 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/b09e03ecb190822b030a63f8be5dc40fa3c13c0d

commit b09e03ecb190822b030a63f8be5dc40fa3c13c0d
Author: Aaron Gable <agable@chromium.org>
Date: Thu May 24 18:05:20 2018

Remove Rietveld-only apply_issue

This script only works (worked) for Rietveld issues, which
effectively no longer exist. It serves no purpose anymore.

Bug: 770408
Change-Id: Ic93ab3ce90d9c35b3bf5189e2beb4aa0c3983d44
Reviewed-on: https://chromium-review.googlesource.com/1070859
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

[modify] https://crrev.com/b09e03ecb190822b030a63f8be5dc40fa3c13c0d/.gitattributes
[delete] https://crrev.com/4b23a2c6d7e2036160f17307ea8d95693a4e4168/apply_issue.bat
[delete] https://crrev.com/4b23a2c6d7e2036160f17307ea8d95693a4e4168/apply_issue.py
[delete] https://crrev.com/4b23a2c6d7e2036160f17307ea8d95693a4e4168/apply_issue
Project Member

Comment 33 by bugdroid1@chromium.org, May 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/751966ca0b152d2dcf0236d74496cbc99f74cf30

commit 751966ca0b152d2dcf0236d74496cbc99f74cf30
Author: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu May 24 20:16:16 2018

Roll src/third_party/depot_tools/ 4e9b50ab8..0115c356f (2 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4e9b50ab86b9..0115c356f675

$ git log 4e9b50ab8..0115c356f --date=short --no-merges --format='%ad %ae %s'
2018-05-24 justincohen Roll mac_toolchain to 478dc9dbb
2018-05-23 agable Remove old git-cherry-pick-upload documentation

Created with:
  roll-dep src/third_party/depot_tools
BUG=chromium:841910,chromium:770408


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I7498707ef960c6bee4e121bcae531e6a0c1022d4
Reviewed-on: https://chromium-review.googlesource.com/1072046
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#561601}
[modify] https://crrev.com/751966ca0b152d2dcf0236d74496cbc99f74cf30/DEPS
Project Member

Comment 34 by bugdroid1@chromium.org, May 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/af2ffd933d0e6d8b5bd8c48be7a2b2d568a5eea2

commit af2ffd933d0e6d8b5bd8c48be7a2b2d568a5eea2
Author: Aaron Gable <agable@chromium.org>
Date: Thu May 24 20:47:19 2018

Remove cq_client from depot_tools

This library is no longer used by anything in depot_tools.

Bug: 770408
Change-Id: I8f0a99f73cf9c52731994c830085678ca652d2c4
Reviewed-on: https://chromium-review.googlesource.com/1072491
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

[delete] https://crrev.com/b1a5e452d31e36b9b56abaa36d8f5fd6908655a5/third_party/cq_client/v2/cq_pb2.py
[delete] https://crrev.com/b1a5e452d31e36b9b56abaa36d8f5fd6908655a5/third_party/cq_client/v2/cq.proto
[delete] https://crrev.com/b1a5e452d31e36b9b56abaa36d8f5fd6908655a5/third_party/cq_client/v1/testdata/cq_gerrit.cfg
[delete] https://crrev.com/b1a5e452d31e36b9b56abaa36d8f5fd6908655a5/third_party/cq_client/v1/testdata/cq_both.cfg
[delete] https://crrev.com/b1a5e452d31e36b9b56abaa36d8f5fd6908655a5/third_party/cq_client/OWNERS
[delete] https://crrev.com/b1a5e452d31e36b9b56abaa36d8f5fd6908655a5/third_party/cq_client/v1/cq.pb.go
[delete] https://crrev.com/b1a5e452d31e36b9b56abaa36d8f5fd6908655a5/third_party/cq_client/__init__.py
[delete] https://crrev.com/b1a5e452d31e36b9b56abaa36d8f5fd6908655a5/third_party/cq_client/v1/cq_pb2.py
[delete] https://crrev.com/b1a5e452d31e36b9b56abaa36d8f5fd6908655a5/third_party/cq_client/v1/cq.proto
[delete] https://crrev.com/b1a5e452d31e36b9b56abaa36d8f5fd6908655a5/third_party/cq_client/v2/__init__.py
[delete] https://crrev.com/b1a5e452d31e36b9b56abaa36d8f5fd6908655a5/third_party/cq_client/v2/cq.pb.go
[delete] https://crrev.com/b1a5e452d31e36b9b56abaa36d8f5fd6908655a5/third_party/cq_client/README.depot_tools.md
[modify] https://crrev.com/af2ffd933d0e6d8b5bd8c48be7a2b2d568a5eea2/.gitattributes
[delete] https://crrev.com/b1a5e452d31e36b9b56abaa36d8f5fd6908655a5/third_party/cq_client/README.md
[delete] https://crrev.com/b1a5e452d31e36b9b56abaa36d8f5fd6908655a5/third_party/cq_client/v1/testdata/cq_rietveld.cfg
[delete] https://crrev.com/b1a5e452d31e36b9b56abaa36d8f5fd6908655a5/third_party/cq_client/v1/__init__.py
Project Member

Comment 35 by bugdroid1@chromium.org, May 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46b2ae1a3b4e66a9e2a960baf9e05893fb4c5f9c

commit 46b2ae1a3b4e66a9e2a960baf9e05893fb4c5f9c
Author: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu May 24 21:39:44 2018

Roll src/third_party/depot_tools/ 0115c356f..b1a5e452d (3 commits; 1 trivial rolls)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0115c356f675..b1a5e452d31e

$ git log 0115c356f..b1a5e452d --date=short --no-merges --format='%ad %ae %s'
2018-05-23 agable Remove Rietveld-only apply_issue
2018-05-24 agable Remove more Rietveld support from presubmit

Created with:
  roll-dep src/third_party/depot_tools
BUG=chromium:770408,chromium:770408


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I3c4783648fdd94df71a875e0444218c125cd94b6
Reviewed-on: https://chromium-review.googlesource.com/1072494
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#561643}
[modify] https://crrev.com/46b2ae1a3b4e66a9e2a960baf9e05893fb4c5f9c/DEPS
Project Member

Comment 36 by bugdroid1@chromium.org, May 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f51a871867e95d71118e1c3e7c2deeae3bd6a222

commit f51a871867e95d71118e1c3e7c2deeae3bd6a222
Author: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu May 24 23:42:31 2018

Roll src/third_party/depot_tools/ b1a5e452d..af2ffd933 (1 commit)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b1a5e452d31e..af2ffd933d0e

$ git log b1a5e452d..af2ffd933 --date=short --no-merges --format='%ad %ae %s'
2018-05-24 agable Remove cq_client from depot_tools

Created with:
  roll-dep src/third_party/depot_tools
BUG=chromium:770408


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: Ibd05c61891c11981e0aa3546b2aed95be31d6916
Reviewed-on: https://chromium-review.googlesource.com/1072687
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#561693}
[modify] https://crrev.com/f51a871867e95d71118e1c3e7c2deeae3bd6a222/DEPS
Project Member

Comment 37 by bugdroid1@chromium.org, May 25 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/faaf41e886aa9e2d1a75d71f03bd8a1e144d1fdf

commit faaf41e886aa9e2d1a75d71f03bd8a1e144d1fdf
Author: Aaron Gable <agable@chromium.org>
Date: Fri May 25 19:28:21 2018

Remove PatchChrome command

This command runs the 'apply_issue' script, which only works
with Rietveld changes, which no longer exist.

Bug: 770408
Change-Id: I31c9d4abb0a8e3df6ed24f7fcb66ee68e7395c75
Reviewed-on: https://chromium-review.googlesource.com/1070776
Commit-Ready: Aaron Gable <agable@chromium.org>
Tested-by: Aaron Gable <agable@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/faaf41e886aa9e2d1a75d71f03bd8a1e144d1fdf/cbuildbot/commands.py
Project Member

Comment 38 by bugdroid1@chromium.org, May 25 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57bb916db076ee56d61e61b845b9ce962c1b639d

commit 57bb916db076ee56d61e61b845b9ce962c1b639d
Author: chromite-chromium-autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri May 25 20:39:11 2018

Roll src/third_party/chromite/ 13f434375..faaf41e88 (1 commit)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/13f43437558c..faaf41e886aa

$ git log 13f434375..faaf41e88 --date=short --no-merges --format='%ad %ae %s'
2018-05-23 agable Remove PatchChrome command

Created with:
  roll-dep src/third_party/chromite
BUG=chromium:770408


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I12953870db5d4be3b20d54bbbd523559e053ea40
Reviewed-on: https://chromium-review.googlesource.com/1073661
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#561998}
[modify] https://crrev.com/57bb916db076ee56d61e61b845b9ce962c1b639d/DEPS

Comment 39 by aga...@chromium.org, Aug 10

Owner: ----
Status: Available (was: Assigned)
Tons and tons of progress have been made here, but the work isn't quite done. Unfortunately, I have to unassign from myself because I'm on sabbatical. Maybe there'll still be work to do here when I get back!
Project Member

Comment 40 by bugdroid1@chromium.org, Oct 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/f5569d26086918a2bdb350e3d813c63a20de4017

commit f5569d26086918a2bdb350e3d813c63a20de4017
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Mon Oct 15 03:35:23 2018

git cl: start deleting Rietveld support.

R=ehmaldonado

Bug: 770408
Change-Id: I5020596ada0c6fef2797fed6b78e7256a35ffc40
Reviewed-on: https://chromium-review.googlesource.com/c/1279131
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/f5569d26086918a2bdb350e3d813c63a20de4017/tests/git_cl_test.py
[modify] https://crrev.com/f5569d26086918a2bdb350e3d813c63a20de4017/git_cl.py
Project Member

Comment 41 by bugdroid1@chromium.org, Oct 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/03da150665d9d5d57db62028dd53ac7f536f043e

commit 03da150665d9d5d57db62028dd53ac7f536f043e
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Mon Oct 15 03:42:34 2018

git cl: delete Rietveld support for tryjobs.

R=ehmaldonado

Bug: 770408
Change-Id: Id070e6084b6beba7309bdc35f0f750decd77e0c9
Reviewed-on: https://chromium-review.googlesource.com/c/1279132
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/03da150665d9d5d57db62028dd53ac7f536f043e/tests/git_cl_test.py
[modify] https://crrev.com/03da150665d9d5d57db62028dd53ac7f536f043e/git_cl.py
Project Member

Comment 42 by bugdroid1@chromium.org, Oct 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b46ca1adc428bb7a4fabb3df314a6d19eec32c65

commit b46ca1adc428bb7a4fabb3df314a6d19eec32c65
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Mon Oct 15 06:02:41 2018

Roll src/third_party/depot_tools 76988a8c5288..03da150665d9 (3 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/76988a8c5288..03da150665d9


git log 76988a8c5288..03da150665d9 --date=short --no-merges --format='%ad %ae %s'
2018-10-15 tandrii@chromium.org git cl: delete Rietveld support for tryjobs.
2018-10-15 tandrii@chromium.org git cl: start deleting Rietveld support.
2018-10-15 tandrii@chromium.org git cl: find which reviewers and ccs are OK for Gerrit before upload.


Created with:
  gclient setdep -r src/third_party/depot_tools@03da150665d9

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:770408,chromium:770408, chromium:877717 
TBR=agable@chromium.org

Change-Id: Ifec259dcabd7bbfc452b6add83110b2d377dd29f
Reviewed-on: https://chromium-review.googlesource.com/c/1280103
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599573}
[modify] https://crrev.com/b46ca1adc428bb7a4fabb3df314a6d19eec32c65/DEPS
Project Member

Comment 43 by bugdroid1@chromium.org, Oct 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/9f274436bd0d6eee2cf33ef5ef761f522fd1b5f7

commit 9f274436bd0d6eee2cf33ef5ef761f522fd1b5f7
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Mon Oct 15 16:40:23 2018

git cl: partially remove Rietveld support for uploading code.

Also deletes lots of tests which provided coverage for Rietveld only,
and hence no longer useful.

R=ehmaldonado

Bug: 770408
Change-Id: I31195f7819a52d1063ed28064a74fd70fbc39357
Reviewed-on: https://chromium-review.googlesource.com/c/1279133
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/9f274436bd0d6eee2cf33ef5ef761f522fd1b5f7/tests/git_cl_test.py
[modify] https://crrev.com/9f274436bd0d6eee2cf33ef5ef761f522fd1b5f7/git_cl.py
Project Member

Comment 44 by bugdroid1@chromium.org, Oct 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7de4dc916681148b3363a764c469ff07d84aa4bb

commit 7de4dc916681148b3363a764c469ff07d84aa4bb
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Mon Oct 15 18:13:40 2018

Roll src/third_party/depot_tools 03da150665d9..9f274436bd0d (1 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/03da150665d9..9f274436bd0d


git log 03da150665d9..9f274436bd0d --date=short --no-merges --format='%ad %ae %s'
2018-10-15 tandrii@chromium.org git cl: partially remove Rietveld support for uploading code.


Created with:
  gclient setdep -r src/third_party/depot_tools@9f274436bd0d

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:770408
TBR=agable@chromium.org

Change-Id: I64d34ef394a89cf80ad7604f7685c1c6d3b143fd
Reviewed-on: https://chromium-review.googlesource.com/c/1280420
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599683}
[modify] https://crrev.com/7de4dc916681148b3363a764c469ff07d84aa4bb/DEPS
Project Member

Comment 45 by bugdroid1@chromium.org, Oct 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/7d7bbc3b530f11eec8fa347d330c16006390cd65

commit 7d7bbc3b530f11eec8fa347d330c16006390cd65
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Mon Oct 15 19:26:26 2018

git cl upload: delete no longer supported flags.

--email
--emulate-svn-auto-props

R=ehmaldonado

Bug: 770408
Change-Id: I645342e5735313055c713bc8f8b68eee353aba49
Reviewed-on: https://chromium-review.googlesource.com/c/1279134
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/7d7bbc3b530f11eec8fa347d330c16006390cd65/git_cl.py
Project Member

Comment 47 by bugdroid1@chromium.org, Oct 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/feec80e97144d81bb6fc7d1c8c9e4cb90019f4bc

commit feec80e97144d81bb6fc7d1c8c9e4cb90019f4bc
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Tue Oct 16 01:00:47 2018

git cl: no longer support --rietveld flag when forcing codereview.

R=ehmaldonado

Bug: 770408
Change-Id: I980487aacd115535d0ca855cd1edfcfc18fc5cbe
Reviewed-on: https://chromium-review.googlesource.com/c/1279138
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/feec80e97144d81bb6fc7d1c8c9e4cb90019f4bc/tests/git_cl_test.py
[modify] https://crrev.com/feec80e97144d81bb6fc7d1c8c9e4cb90019f4bc/git_cl.py
Project Member

Comment 48 by bugdroid1@chromium.org, Oct 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/688f3549decda6dbb8312e932c67ffa11403e89e

commit 688f3549decda6dbb8312e932c67ffa11403e89e
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Tue Oct 16 02:34:24 2018

Roll src/third_party/depot_tools 2f727917ac25..7d7bbc3b530f (1 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2f727917ac25..7d7bbc3b530f


git log 2f727917ac25..7d7bbc3b530f --date=short --no-merges --format='%ad %ae %s'
2018-10-15 tandrii@chromium.org git cl upload: delete no longer supported flags.


Created with:
  gclient setdep -r src/third_party/depot_tools@7d7bbc3b530f

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:770408
TBR=agable@chromium.org

Change-Id: If4f421e036ff5a4a81d8b95ecbaab9df5e016a16
Reviewed-on: https://chromium-review.googlesource.com/c/1281842
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599823}
[modify] https://crrev.com/688f3549decda6dbb8312e932c67ffa11403e89e/DEPS
Project Member

Comment 49 by bugdroid1@chromium.org, Oct 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc19f75afbb7037103193b2f9ce80bfb7fc41f57

commit bc19f75afbb7037103193b2f9ce80bfb7fc41f57
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Tue Oct 16 05:11:30 2018

Roll src/third_party/depot_tools 7d7bbc3b530f..feec80e97144 (1 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7d7bbc3b530f..feec80e97144


git log 7d7bbc3b530f..feec80e97144 --date=short --no-merges --format='%ad %ae %s'
2018-10-16 tandrii@chromium.org git cl: no longer support --rietveld flag when forcing codereview.


Created with:
  gclient setdep -r src/third_party/depot_tools@feec80e97144

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:770408
TBR=agable@chromium.org

Change-Id: I5dc25649db0f7eebc765c911d2ff94268c2a73eb
Reviewed-on: https://chromium-review.googlesource.com/c/1282345
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599863}
[modify] https://crrev.com/bc19f75afbb7037103193b2f9ce80bfb7fc41f57/DEPS
Project Member

Comment 50 by bugdroid1@chromium.org, Oct 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/642641d03012ad1504e6bb6a385f819da9ba9e60

commit 642641d03012ad1504e6bb6a385f819da9ba9e60
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Tue Oct 16 05:54:41 2018

git cl comments: remove Rietveld support.

R=ehmaldonado

Bug: 770408
Change-Id: Ib3120b5fd09c35be691c025d0d69ceda60f2ec7f
Reviewed-on: https://chromium-review.googlesource.com/c/1279135
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/642641d03012ad1504e6bb6a385f819da9ba9e60/tests/git_cl_test.py
[modify] https://crrev.com/642641d03012ad1504e6bb6a385f819da9ba9e60/git_cl.py
Project Member

Comment 51 by bugdroid1@chromium.org, Oct 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/dd672fb3c5916a8ccd12593593c895c785c1cbe4

commit dd672fb3c5916a8ccd12593593c895c785c1cbe4
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Tue Oct 16 06:09:51 2018

git cl description: rename gerrit test.

R=ehmaldonado

Bug: 770408
Change-Id: I211ad8e67e9486b974eed7694436afb15ecf21a2
Reviewed-on: https://chromium-review.googlesource.com/c/1279136
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/dd672fb3c5916a8ccd12593593c895c785c1cbe4/tests/git_cl_test.py
[modify] https://crrev.com/dd672fb3c5916a8ccd12593593c895c785c1cbe4/git_cl.py
Project Member

Comment 52 by bugdroid1@chromium.org, Oct 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/38d36a616db2bfd86379225cc45c981f89161ced

commit 38d36a616db2bfd86379225cc45c981f89161ced
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Tue Oct 16 06:22:31 2018

git cl: delete no longer used Rietveld methods.

R=ehmaldonado

Bug: 770408
Change-Id: I4dc034839180a7587ee368793547c5b74c2572f6
Reviewed-on: https://chromium-review.googlesource.com/c/1279139
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/38d36a616db2bfd86379225cc45c981f89161ced/git_cl.py

Comment 53 by machenb...@chromium.org, Oct 16

Blockedon: v8:8310
Project Member

Comment 54 by bugdroid1@chromium.org, Oct 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/c68a1753c53a02b1bd292035e4a72a18e55814f3

commit c68a1753c53a02b1bd292035e4a72a18e55814f3
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Tue Oct 16 06:55:41 2018

git cl try-results: delete Rietveld support.

R=ehmaldonado

Bug: 770408
Change-Id: I94ff37f198937dc7d341a859a71becd91cf3a706
Reviewed-on: https://chromium-review.googlesource.com/c/1279140
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/c68a1753c53a02b1bd292035e4a72a18e55814f3/tests/git_cl_test.py
[modify] https://crrev.com/c68a1753c53a02b1bd292035e4a72a18e55814f3/git_cl.py
Project Member

Comment 55 by bugdroid1@chromium.org, Oct 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a8d631a2c9015dc6898e6ba5e844b96e179e040

commit 9a8d631a2c9015dc6898e6ba5e844b96e179e040
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Tue Oct 16 07:23:41 2018

Roll src/third_party/depot_tools feec80e97144..642641d03012 (1 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/feec80e97144..642641d03012


git log feec80e97144..642641d03012 --date=short --no-merges --format='%ad %ae %s'
2018-10-16 tandrii@chromium.org git cl comments: remove Rietveld support.


Created with:
  gclient setdep -r src/third_party/depot_tools@642641d03012

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:770408
TBR=agable@chromium.org

Change-Id: I75683978717cf07b9ec40131dbec4a525168fdbb
Reviewed-on: https://chromium-review.googlesource.com/c/1282349
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599899}
[modify] https://crrev.com/9a8d631a2c9015dc6898e6ba5e844b96e179e040/DEPS
Project Member

Comment 56 by bugdroid1@chromium.org, Oct 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20c65bd3a4aa9b4f6456d8bf4641a97a49abf5ad

commit 20c65bd3a4aa9b4f6456d8bf4641a97a49abf5ad
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Tue Oct 16 09:33:02 2018

Roll src/third_party/depot_tools 642641d03012..c68a1753c53a (4 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/642641d03012..c68a1753c53a


git log 642641d03012..c68a1753c53a --date=short --no-merges --format='%ad %ae %s'
2018-10-16 tandrii@chromium.org git cl try-results: delete Rietveld support.
2018-10-16 tandrii@chromium.org git cl: delete no longer used Rietveld methods.
2018-10-16 tandrii@chromium.org git cl: rename and relocate CreateDescriptionFromLog func.
2018-10-16 tandrii@chromium.org git cl description: rename gerrit test.


Created with:
  gclient setdep -r src/third_party/depot_tools@c68a1753c53a

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:770408,chromium:770408,chromium:770408
TBR=agable@chromium.org

Change-Id: Ic4f1250d1162d63fd94b4636004ba2ce4a2ffc17
Reviewed-on: https://chromium-review.googlesource.com/c/1282350
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599927}
[modify] https://crrev.com/20c65bd3a4aa9b4f6456d8bf4641a97a49abf5ad/DEPS
Project Member

Comment 57 by bugdroid1@chromium.org, Oct 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/1e488131ffcde9e4df573c9be3514c0cdc42d28b

commit 1e488131ffcde9e4df573c9be3514c0cdc42d28b
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Tue Oct 16 21:37:21 2018

Revert "git cl: delete no longer used Rietveld methods."

This reverts commit 38d36a616db2bfd86379225cc45c981f89161ced.

Reason for revert: breaks git cl archive for old rietveld branches.

Original change's description:
> git cl: delete no longer used Rietveld methods.
> 
> R=​ehmaldonado
> 
> Bug: 770408
> Change-Id: I4dc034839180a7587ee368793547c5b74c2572f6
> Reviewed-on: https://chromium-review.googlesource.com/c/1279139
> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

TBR=tandrii@chromium.org,ehmaldonado@chromium.org

Change-Id: Ifff7b5e13b104841ecf2c190b043ad23f9dbcccd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 770408
Reviewed-on: https://chromium-review.googlesource.com/c/1284990
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/1e488131ffcde9e4df573c9be3514c0cdc42d28b/git_cl.py
Project Member

Comment 58 by bugdroid1@chromium.org, Oct 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/753767aeb8cd6f3e60dba09bf2c744f5ab988e7f

commit 753767aeb8cd6f3e60dba09bf2c744f5ab988e7f
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Tue Oct 16 23:01:25 2018

Roll src/third_party/depot_tools 74b702466046..1e488131ffcd (1 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/74b702466046..1e488131ffcd


git log 74b702466046..1e488131ffcd --date=short --no-merges --format='%ad %ae %s'
2018-10-16 tandrii@chromium.org Revert "git cl: delete no longer used Rietveld methods."


Created with:
  gclient setdep -r src/third_party/depot_tools@1e488131ffcd

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:770408
TBR=agable@chromium.org

Change-Id: Ib3aabc30311a4f0e4dc70da08f5d7029be183e89
Reviewed-on: https://chromium-review.googlesource.com/c/1284758
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#600168}
[modify] https://crrev.com/753767aeb8cd6f3e60dba09bf2c744f5ab988e7f/DEPS
Project Member

Comment 59 by bugdroid1@chromium.org, Oct 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/51bdf8c8dda4b8861e50be686fb3847606deba07

commit 51bdf8c8dda4b8861e50be686fb3847606deba07
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Thu Oct 18 01:07:58 2018

Reland "git cl: delete no longer used Rietveld methods."

This is a reland of 38d36a616db2bfd86379225cc45c981f89161ced
but now
 $ git cl status
 $ git cl archive
actually work.

Original change's description:
> git cl: delete no longer used Rietveld methods.
>
> R=ehmaldonado
>
> Bug: 770408
> Change-Id: I4dc034839180a7587ee368793547c5b74c2572f6
> Reviewed-on: https://chromium-review.googlesource.com/c/1279139
> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

Bug: 770408,  895784 
Change-Id: Id1dbf31dc19d693f1c4636c9558e1ac99fe6a77b
Reviewed-on: https://chromium-review.googlesource.com/c/1287245
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/51bdf8c8dda4b8861e50be686fb3847606deba07/git_cl.py
Project Member

Comment 60 by bugdroid1@chromium.org, Oct 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/3e002fb86279bda61e475ab9224046152448830d

commit 3e002fb86279bda61e475ab9224046152448830d
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Thu Oct 18 01:17:19 2018

git cl land: remove Rietveld-only options.

R=ehmaldonado

Bug: 770408
Change-Id: I6f460902e3282451f5761bebf176d180a8f88d26
Reviewed-on: https://chromium-review.googlesource.com/c/1279141
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/3e002fb86279bda61e475ab9224046152448830d/git_cl.py
Project Member

Comment 61 by bugdroid1@chromium.org, Oct 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3fdee98c1c33b01fcfe216f15e73d991d3bc1d1e

commit 3fdee98c1c33b01fcfe216f15e73d991d3bc1d1e
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Thu Oct 18 04:38:04 2018

Roll src/third_party/depot_tools 08faab99d41b..488362624b6d (5 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/08faab99d41b..488362624b6d


git log 08faab99d41b..488362624b6d --date=short --no-merges --format='%ad %ae %s'
2018-10-18 ehmaldonado@chromium.org metrics: Add a mechanism to notify users when we want to collect additional metrics.
2018-10-18 tandrii@chromium.org git cl land: remove Rietveld-only options.
2018-10-18 tandrii@chromium.org Reland "git cl: delete no longer used Rietveld methods."
2018-10-18 ehmaldonado@chromium.org Use lowercase machine architecture.
2018-10-17 jbudorick@chromium.org bot_update: stop failing with a KeyError in the recipe on failure.


Created with:
  gclient setdep -r src/third_party/depot_tools@488362624b6d

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:None,chromium:770408,chromium:770408,chromium:895784,chromium:896355
TBR=agable@chromium.org

Change-Id: I0a0fc6c3a5b488b1480c808f4b0d2f5d791cfa38
Reviewed-on: https://chromium-review.googlesource.com/c/1288015
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#600659}
[modify] https://crrev.com/3fdee98c1c33b01fcfe216f15e73d991d3bc1d1e/DEPS
Project Member

Comment 62 by bugdroid1@chromium.org, Dec 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/61ea30737c65fb3a6ad7096f447465e58f8b915c

commit 61ea30737c65fb3a6ad7096f447465e58f8b915c
Author: Edward Lemur <ehmaldonado@chromium.org>
Date: Sat Dec 01 00:34:36 2018

git-cl: Remove unused settings.

Bug: 770408
Change-Id: Ic5029d6b12cdb6ea30704d90229ab7e365dc7273
Reviewed-on: https://chromium-review.googlesource.com/c/1354384
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/61ea30737c65fb3a6ad7096f447465e58f8b915c/tests/git_cl_test.py
[modify] https://crrev.com/61ea30737c65fb3a6ad7096f447465e58f8b915c/git_cl.py
Project Member

Comment 63 by bugdroid1@chromium.org, Dec 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec1778686aaaeac58fc5978b9261fc183a0a1867

commit ec1778686aaaeac58fc5978b9261fc183a0a1867
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Sat Dec 01 02:17:43 2018

Roll src/third_party/depot_tools b0ee5ee22d88..61ea30737c65 (1 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b0ee5ee22d88..61ea30737c65


git log b0ee5ee22d88..61ea30737c65 --date=short --no-merges --format='%ad %ae %s'
2018-12-01 ehmaldonado@chromium.org git-cl: Remove unused settings.


Created with:
  gclient setdep -r src/third_party/depot_tools@61ea30737c65

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:770408
TBR=agable@chromium.org

Change-Id: I307ebc5be3bfc635802fbf580676a82769b809f8
Reviewed-on: https://chromium-review.googlesource.com/c/1357659
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612906}
[modify] https://crrev.com/ec1778686aaaeac58fc5978b9261fc183a0a1867/DEPS
►

Sign in to add a comment