vm_launcher: use crosvm socket for things |
|||
Issue descriptioncrosvm has a nice socket interface that can do many things. We should use this. For things. At least this could provide a step in between maitred asking the VM to shutdown, and trying to kill with SIGTERM/SIGKILL.
,
Nov 18 2017
,
Nov 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/03182d1215d94bc5c4b4927d855444b8a96aa391 commit 03182d1215d94bc5c4b4927d855444b8a96aa391 Author: Stephen Barber <smbarber@chromium.org> Date: Mon Nov 20 20:21:15 2017 vm_tools: launcher: use control socket to stop crosvm crosvm provides a control socket that can be used to stop a running VM more cleanly than SIGTERM/SIGKILL. Use this as a nicer fallback in the event that maitred is unable to shutdown in a timely manner. Since maitred now attempts a cleaner guest shutdown, also extend the timeout for the shutdown command to give it a better chance to complete successfully. BUG= chromium:770404 TEST=`vm_launcher stop all` doesn't leave stray crosvm instances Change-Id: Ib476e090b451c278910261054ebd829013953f4f Reviewed-on: https://chromium-review.googlesource.com/773664 Commit-Ready: Stephen Barber <smbarber@chromium.org> Tested-by: Stephen Barber <smbarber@chromium.org> Reviewed-by: Stephen Barber <smbarber@chromium.org> [modify] https://crrev.com/03182d1215d94bc5c4b4927d855444b8a96aa391/vm_tools/launcher/crosvm.h [modify] https://crrev.com/03182d1215d94bc5c4b4927d855444b8a96aa391/vm_tools/launcher/crosvm.cc
,
May 9 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by smbar...@chromium.org
, Nov 18 2017