New issue
Advanced search Search tips

Issue 770402 link

Starred by 1 user
Status: Archived
Owner: ----
Closed: Sep 13
Cc:
pbos@chromium.org
bsep@chromium.org
wzang@chromium.org
jdufault@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Password replace character shouldn't be font dependent

Project Member Reported by pbos@chromium.org, Sep 29 2017 
On ChromeOS the system font for U+2022 looks significantly worse for passwords (SetObscured) than U+2219 (which is in use for a login dialog).

Ideally this look shouldn't be system-font dependent, we're not trying to express a bullet character or a bullet operator, we just want a good circle that's evenly spaced to match an obscured password.

Cleaning this up might be low prio / I'm not sure how easy this would be to get into views::Label (if it could easily render non-fonts or not).

Comment 1 by pbos@chromium.org, Oct 2 2017 

Less critical, wzang@ found that the bad font example was from a Linux system font and not CrOS. It still shows that 2022's look that we depend on is highly font dependent, and for ChromeOS it seems like neither glyphs are especially good.
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2999c671325f380b10d90daddc7cbb5547fe12dd

commit 2999c671325f380b10d90daddc7cbb5547fe12dd
Author: Peter Boström <pbos@chromium.org>
Date: Tue Oct 03 00:43:29 2017

Unify password-replacement character.

Changes the RenderText default password character to be a bullet on all
platforms instead of just Mac, as part of Harmony unification of UI.

This changes the ash LoginPasswordView from using the U+2219 bullet
operator glyph to the RenderText default bullet glyph.

Removes SetPasswordReplacementChar as it is no longer meaningfully used.

BUG= chromium:654115 ,  chromium:770402 

Change-Id: Ia323917a7dcf3a4b303d74d3488b3da7bf2d65ca
Reviewed-on: https://chromium-review.googlesource.com/693279
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505890}
[modify] https://crrev.com/2999c671325f380b10d90daddc7cbb5547fe12dd/ash/login/ui/login_password_view.cc
[modify] https://crrev.com/2999c671325f380b10d90daddc7cbb5547fe12dd/ui/gfx/render_text.cc
[modify] https://crrev.com/2999c671325f380b10d90daddc7cbb5547fe12dd/ui/gfx/render_text.h
[modify] https://crrev.com/2999c671325f380b10d90daddc7cbb5547fe12dd/ui/gfx/render_text_unittest.cc
[modify] https://crrev.com/2999c671325f380b10d90daddc7cbb5547fe12dd/ui/views/controls/textfield/textfield.cc
[modify] https://crrev.com/2999c671325f380b10d90daddc7cbb5547fe12dd/ui/views/controls/textfield/textfield.h
[modify] https://crrev.com/2999c671325f380b10d90daddc7cbb5547fe12dd/ui/views/controls/textfield/textfield_unittest.cc

Comment 3 by drott@chromium.org, Oct 11 2017 

See also issue 486880

Comment 4 by pbos@chromium.org, Oct 11 2017 

That issue is within Blink, this is for gfx::RenderText. I wouldn't be surprised if it's relevant though because >2 byte characters possibly don't fit well within a base::string16.

Comment 5 by robliao@chromium.org, Sep 13

Status: Archived (was: Untriaged)
Archiving old bugs that haven't been actively assigned in over 180 days.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!
►

Sign in to add a comment