New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 770401 link

Starred by 1 user
Status: Fixed
Owner:
█ vollick@chromium.org
Last visit > 30 days ago
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Ensure that we do not access stale data in the frame lifecycle

Project Member Reported by vollick@chromium.org, Sep 29 2017 
Certain values (eg size) are not valid until certain operations in the frame lifecycle have completed (in this case, texture updates).

We should track our progress through the frame lifecycle and begin to add DCHECK's where appropriate to police our usage of various properties.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/733580614ade43cb248eecdcb04642514b90925b

commit 733580614ade43cb248eecdcb04642514b90925b
Author: Ian Vollick <vollick@chromium.org>
Date: Mon Oct 02 23:28:49 2017

[vr] Introduce the frame lifecycle

With this CL we start to track our progress through the frame lifecycle
in order to check that we don't use values that are stale or invalid.

Bug:  770401 
Change-Id: I50ffc569a6baeae9d0d43e2ed0b84b7a5b701cc0
Reviewed-on: https://chromium-review.googlesource.com/693226
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505851}
[modify] https://crrev.com/733580614ade43cb248eecdcb04642514b90925b/chrome/browser/android/vr_shell/vr_shell_gl.cc
[modify] https://crrev.com/733580614ade43cb248eecdcb04642514b90925b/chrome/browser/vr/elements/textured_element.cc
[modify] https://crrev.com/733580614ade43cb248eecdcb04642514b90925b/chrome/browser/vr/elements/transient_element.cc
[modify] https://crrev.com/733580614ade43cb248eecdcb04642514b90925b/chrome/browser/vr/elements/transient_element.h
[modify] https://crrev.com/733580614ade43cb248eecdcb04642514b90925b/chrome/browser/vr/elements/transient_element_unittest.cc
[modify] https://crrev.com/733580614ade43cb248eecdcb04642514b90925b/chrome/browser/vr/elements/ui_element.cc
[modify] https://crrev.com/733580614ade43cb248eecdcb04642514b90925b/chrome/browser/vr/elements/ui_element.h
[modify] https://crrev.com/733580614ade43cb248eecdcb04642514b90925b/chrome/browser/vr/elements/ui_element_unittest.cc
[modify] https://crrev.com/733580614ade43cb248eecdcb04642514b90925b/chrome/browser/vr/elements/viewport_aware_root.cc
[modify] https://crrev.com/733580614ade43cb248eecdcb04642514b90925b/chrome/browser/vr/elements/viewport_aware_root.h
[modify] https://crrev.com/733580614ade43cb248eecdcb04642514b90925b/chrome/browser/vr/test/constants.h
[modify] https://crrev.com/733580614ade43cb248eecdcb04642514b90925b/chrome/browser/vr/test/ui_pixel_test.cc
[modify] https://crrev.com/733580614ade43cb248eecdcb04642514b90925b/chrome/browser/vr/test/ui_scene_manager_test.cc
[modify] https://crrev.com/733580614ade43cb248eecdcb04642514b90925b/chrome/browser/vr/testapp/vr_test_context.cc
[modify] https://crrev.com/733580614ade43cb248eecdcb04642514b90925b/chrome/browser/vr/ui_scene.cc
[modify] https://crrev.com/733580614ade43cb248eecdcb04642514b90925b/chrome/browser/vr/ui_scene.h
[modify] https://crrev.com/733580614ade43cb248eecdcb04642514b90925b/chrome/browser/vr/ui_scene_manager.cc
[modify] https://crrev.com/733580614ade43cb248eecdcb04642514b90925b/chrome/browser/vr/ui_scene_unittest.cc

Comment 2 by vollick@chromium.org, Oct 3 2017

Status: Fixed (was: Started)
►

Sign in to add a comment