Issue metadata
Sign in to add a comment
|
ClickHoldButtonCell causing accessibility exception throw |
||||||||||||||||||||||||
Issue descriptionChrome Version: 61.0.3163.100 OS: 10.12 The crash crash/7280a1ddd8ef2dfb shows the following exception being thrown (not saying it's the cause of the crash): NSAccessibilityException reason "AXChildren" attribute unsupported by: <ClickHoldButtonCell: 0x7fdf80573be0> -> ellyjones@ for triage and assignment
,
Oct 2 2017
We're tracking this particular crash in a different bug ( issue 684388 ). I filed this one to get the exception fixed (the exception and crash are not necessarily related). > I think that exception happens "normally" and is eaten by AppKit, but we end up logging it anyway. As far as I can tell ClickHoldButtonCell is code we own, so this seems like a bug we should fix for correctness?
,
Oct 12 2017
Hm, I'm not sure what to make of this exception. When testing locally, ClickHoldButtonCell *does* support AXChildren, via inheritance from NSButtonCell, which implements it. NSButtonCell returns nil for AXChildren instead of the expected @[], which is surprising. If the reports of this were from 10.9, I'd be prepared to blame the OS version, but the linked report is from 10.12.6. I don't really understand what's going on here. I can't see any concrete negative consequences of this exception being thrown & caught inside AppKit, except that it's probably pretty slow and overwrites the "last exception" field inside our crash reports. We could add a value for NSAccessibilityChildrenAttribute in -[ClickHoldButtonCell accessibilityAttributeValue:], but since there already is one on NSButtonCell, I'm puzzled by this exception being thrown, and not confident that such a change would fix it. I'm going to drop this to Pri-3 in the absence of either a path forward or a user impact.
,
Oct 12 2017
<https://chromium-review.googlesource.com/c/chromium/src/+/716456> is what a fix for this would look like perhaps.
,
Mar 14 2018
Triaging: it's not likely I will make time to fix this while ClickHoldButtonCell is still in existence. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by ellyjo...@chromium.org
, Oct 2 2017Owner: spqc...@chromium.org